Commit notifications for all Sup repositories
 help / color / mirror / Atom feed
* [sup-heliotrope/sup] 4e23e1: fix handling of contacts with no alias
@ 2026-04-20  9:14 Dan Callaghan
  0 siblings, 0 replies; only message in thread
From: Dan Callaghan @ 2026-04-20  9:14 UTC (permalink / raw)
  To: djc, sup-commits

  Branch: refs/heads/develop
  Home:   https://github.com/sup-heliotrope/sup
  Commit: 4e23e13e705c02f9a341a04338b5b46994c01d24
      https://github.com/sup-heliotrope/sup/commit/4e23e13e705c02f9a341a04338b5b46994c01d24
  Author: Dan Callaghan <djc@djc.id.au>
  Date:   2026-04-11 (Sat, 11 Apr 2026)

  Changed paths:
    M lib/sup/contact.rb
    M test/fixtures/contacts.txt
    M test/unit/test_contact.rb

  Log Message:
  -----------
  fix handling of contacts with no alias

This avoids showing empty parentheses (displaying an alias which is
empty string) after contacts' email addresses in ThreadViewMode.


  Commit: b570d0cd16c9176cebf70739fd02ddf7f84a8c06
      https://github.com/sup-heliotrope/sup/commit/b570d0cd16c9176cebf70739fd02ddf7f84a8c06
  Author: Dan Callaghan <djc@djc.id.au>
  Date:   2026-04-12 (Sun, 12 Apr 2026)

  Changed paths:
    M lib/sup/rfc2047.rb
    M test/fixtures/rfc2047-header-encoding.eml
    M test/test_message.rb

  Log Message:
  -----------
  fix handling of RFC2047 words containing invalid bytes after decoding

Yet another bad case somehow not covered by all the tests. If the
encoding is recognised, and the word is successfully decoded, but the
resulting string contains an invalid byte sequence for its declared
encoding, Sup would crash with ArgumentError.

Only use the decoded word if the end result has a valid encoding.


Compare: https://github.com/sup-heliotrope/sup/compare/ad657e383d69...b570d0cd16c9

To unsubscribe from these emails, change your notification settings at https://github.com/sup-heliotrope/sup/settings/notifications

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-21 12:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-20  9:14 [sup-heliotrope/sup] 4e23e1: fix handling of contacts with no alias Dan Callaghan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox