From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from djc.id.au (180-150-43-123.b4962b.syd.static.aussiebb.net [180.150.43.123])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)
	(No client certificate requested)
	by bl2.djc.id.au (Postfix) with ESMTPS id 81A4B1C2C49
	for <sup-commits@supmua.dev>; Tue, 21 Apr 2026 22:02:34 +1000 (AEST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)
	(No client certificate requested)
	by djc.id.au (Postfix) with ESMTPS id C3D1B3579982
	for <sup-commits@supmua.dev>; Mon, 20 Apr 2026 19:14:46 +1000 (AEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
	s=pf2023; t=1776676482;
	bh=ACWlb9AX4UiC3gW5Rh9mbwNLhE5qg2ML4yNEfpnglPk=;
	h=Date:From:To:Subject:List-Unsubscribe:From;
	b=G8cWUcBrNOXlCS+o24xxYDIzvwTi5pIUefhKEl7V5adIDNdZT4ZLEslDVYsbEqn5D
	 X59L5qX/Gkqp8pagJvJA5SNvuQ91dQeIyCXRUytPXNcWe+2iQO3EpRAGq+fPODxj3D
	 /G7ktGpzBV/jjI+PLylqseVpX0oSpxCQ0cBge8Fs=
Received: from github.com (hubbernetes-node-a3d5730.ac4-iad.github.net [10.52.221.67])
	by smtp.github.com (Postfix) with ESMTPA id A38E4781175;
	Mon, 20 Apr 2026 02:14:42 -0700 (PDT)
Date: Mon, 20 Apr 2026 02:14:42 -0700
From: Dan Callaghan <noreply@github.com>
To: djc@djc.id.au, 
 sup-commits@supmua.dev
Message-ID: <sup-heliotrope/sup/push/refs/heads/develop/ad657e-b570d0@github.com>
Subject: [sup-heliotrope/sup] 4e23e1: fix handling of contacts with no alias
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Unsubscribe: <https://github.com/sup-heliotrope/sup/settings/notifications>
X-GitHub-Recipient-Address: djc@djc.id.au,sup-commits@supmua.dev
X-Auto-Response-Suppress: All
X-Rspamd-Queue-Id: 81A4B1C2C49
List-Id: <sup-commits.supmua.dev>

  Branch: refs/heads/develop
  Home:   https://github.com/sup-heliotrope/sup
  Commit: 4e23e13e705c02f9a341a04338b5b46994c01d24
      https://github.com/sup-heliotrope/sup/commit/4e23e13e705c02f9a341a04338b5b46994c01d24
  Author: Dan Callaghan <djc@djc.id.au>
  Date:   2026-04-11 (Sat, 11 Apr 2026)

  Changed paths:
    M lib/sup/contact.rb
    M test/fixtures/contacts.txt
    M test/unit/test_contact.rb

  Log Message:
  -----------
  fix handling of contacts with no alias

This avoids showing empty parentheses (displaying an alias which is
empty string) after contacts' email addresses in ThreadViewMode.


  Commit: b570d0cd16c9176cebf70739fd02ddf7f84a8c06
      https://github.com/sup-heliotrope/sup/commit/b570d0cd16c9176cebf70739fd02ddf7f84a8c06
  Author: Dan Callaghan <djc@djc.id.au>
  Date:   2026-04-12 (Sun, 12 Apr 2026)

  Changed paths:
    M lib/sup/rfc2047.rb
    M test/fixtures/rfc2047-header-encoding.eml
    M test/test_message.rb

  Log Message:
  -----------
  fix handling of RFC2047 words containing invalid bytes after decoding

Yet another bad case somehow not covered by all the tests. If the
encoding is recognised, and the word is successfully decoded, but the
resulting string contains an invalid byte sequence for its declared
encoding, Sup would crash with ArgumentError.

Only use the decoded word if the end result has a valid encoding.


Compare: https://github.com/sup-heliotrope/sup/compare/ad657e383d69...b570d0cd16c9

To unsubscribe from these emails, change your notification settings at https://github.com/sup-heliotrope/sup/settings/notifications