From: Dan Callaghan <noreply@github.com>
To: djc@djc.id.au, sup-commits@supmua.dev
Subject: [sup-heliotrope/sup] 4e23e1: fix handling of contacts with no alias
Date: Mon, 20 Apr 2026 02:14:42 -0700 [thread overview]
Message-ID: <sup-heliotrope/sup/push/refs/heads/develop/ad657e-b570d0@github.com> (raw)
Branch: refs/heads/develop
Home: https://github.com/sup-heliotrope/sup
Commit: 4e23e13e705c02f9a341a04338b5b46994c01d24
https://github.com/sup-heliotrope/sup/commit/4e23e13e705c02f9a341a04338b5b46994c01d24
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-04-11 (Sat, 11 Apr 2026)
Changed paths:
M lib/sup/contact.rb
M test/fixtures/contacts.txt
M test/unit/test_contact.rb
Log Message:
-----------
fix handling of contacts with no alias
This avoids showing empty parentheses (displaying an alias which is
empty string) after contacts' email addresses in ThreadViewMode.
Commit: b570d0cd16c9176cebf70739fd02ddf7f84a8c06
https://github.com/sup-heliotrope/sup/commit/b570d0cd16c9176cebf70739fd02ddf7f84a8c06
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-04-12 (Sun, 12 Apr 2026)
Changed paths:
M lib/sup/rfc2047.rb
M test/fixtures/rfc2047-header-encoding.eml
M test/test_message.rb
Log Message:
-----------
fix handling of RFC2047 words containing invalid bytes after decoding
Yet another bad case somehow not covered by all the tests. If the
encoding is recognised, and the word is successfully decoded, but the
resulting string contains an invalid byte sequence for its declared
encoding, Sup would crash with ArgumentError.
Only use the decoded word if the end result has a valid encoding.
Compare: https://github.com/sup-heliotrope/sup/compare/ad657e383d69...b570d0cd16c9
To unsubscribe from these emails, change your notification settings at https://github.com/sup-heliotrope/sup/settings/notifications
reply other threads:[~2026-04-21 12:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sup-heliotrope/sup/push/refs/heads/develop/ad657e-b570d0@github.com \
--to=noreply@github.com \
--cc=djc@djc.id.au \
--cc=sup-commits@supmua.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox