Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: Pi <pi+sup@pihost.us>
To: sup-devel@rubyforge.org
Subject: [sup-devel] [PATCH] If the name cannot be parsed out, return "" instead of nil.
Date: Sun, 23 Jan 2011 15:04:02 -0800	[thread overview]
Message-ID: <1295823842-6042-1-git-send-email-pi+sup@pihost.us> (raw)

From: Anthony Martinez <pi+sup@pihost.us>

This un-breaks some recent change between e0191b4b64e and ec13fa74d that
I haven't tracked down.
---
 lib/sup/person.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/person.rb b/lib/sup/person.rb
index ee23fc5..19459e0 100644
--- a/lib/sup/person.rb
+++ b/lib/sup/person.rb
@@ -103,7 +103,7 @@ class Person
       when /((\S+?)@\S+)/
         [$2, $1]
       else
-        [nil, s]
+        ["", s]
       end
 
     Person.new name, email
-- 
1.6.6

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


                 reply	other threads:[~2011-01-23 23:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295823842-6042-1-git-send-email-pi+sup@pihost.us \
    --to=pi+sup@pihost.us \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox