From: Dan Callaghan <noreply@github.com>
To: djc@djc.id.au, sup-commits@supmua.dev
Subject: [sup-heliotrope/ncursesw-ruby] b76063: fix wrong argument passed to wenclose()
Date: Sat, 10 Oct 2026 19:50:03 -0700 [thread overview]
Message-ID: <sup-heliotrope/ncursesw-ruby/push/refs/heads/master/b81325-07ac8c@github.com> (raw)
Branch: refs/heads/master
Home: https://github.com/sup-heliotrope/ncursesw-ruby
Commit: b760630f6ccbfa3c14ed552b6913b179475dc402
https://github.com/sup-heliotrope/ncursesw-ruby/commit/b760630f6ccbfa3c14ed552b6913b179475dc402
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M ncurses_wrap.c
Log Message:
-----------
fix wrong argument passed to wenclose()
Commit: 4e4c03b8b720253a90fb6298a8b7857571f8c60d
https://github.com/sup-heliotrope/ncursesw-ruby/commit/4e4c03b8b720253a90fb6298a8b7857571f8c60d
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M ncurses_wrap.c
Log Message:
-----------
fix wrong argument handling in mvwgetch()
Commit: 4f55077757cf64d7d402983d05964e2a98a6499c
https://github.com/sup-heliotrope/ncursesw-ruby/commit/4f55077757cf64d7d402983d05964e2a98a6499c
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M form_wrap.c
M menu_wrap.c
M ncurses_wrap.c
Log Message:
-----------
fix missing NULL checks for return values
Commit: ecd4c8300b813f6dc26c7ffe2ba4b0bbad124415
https://github.com/sup-heliotrope/ncursesw-ruby/commit/ecd4c8300b813f6dc26c7ffe2ba4b0bbad124415
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M form_wrap.c
M menu_wrap.c
M ncurses_wrap.c
M panel_wrap.c
Log Message:
-----------
migrate to TypedData_Wrap_Struct() and family
This provides type checking before dereferencing the wrapped pointers
passed back from Ruby, avoiding potential segfaults due to memory
reinterpretation.
Commit: 412d8fc2a66d20da280daa2536dd53d57d1232fe
https://github.com/sup-heliotrope/ncursesw-ruby/commit/412d8fc2a66d20da280daa2536dd53d57d1232fe
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M panel_wrap.c
Log Message:
-----------
add GC mark function for PANEL to mark userptr
Otherwise a Ruby object saved in userptr may be garbage collected while
it is still referenced by the PANEL, resulting in a user-after-free.
Commit: 63c77b2506f6bb994f15f6bd5db25beb4754e747
https://github.com/sup-heliotrope/ncursesw-ruby/commit/63c77b2506f6bb994f15f6bd5db25beb4754e747
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M ncurses_wrap.c
Log Message:
-----------
fix add_wch()
Make it construct an actual cchar_t value like wadd_wch() already does,
rather than wrongly casting a wchar_t.
Commit: ab7ef7466ce78093d4c97ae014c3d345dc71ac99
https://github.com/sup-heliotrope/ncursesw-ruby/commit/ab7ef7466ce78093d4c97ae014c3d345dc71ac99
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M ncurses_wrap.c
Log Message:
-----------
fix duplicate definition of pair_content method
It was causing a warning in Sup's test suite, now that there is a call
to Ncurses.newterm:
test/unit/test_line_cursor_mode.rb:15: warning: method redefined; discarding old pair_content
Commit: 07ac8c9b0b9c31b91e6c5192efdd79e96733a394
https://github.com/sup-heliotrope/ncursesw-ruby/commit/07ac8c9b0b9c31b91e6c5192efdd79e96733a394
Author: Dan Callaghan <djc@djc.id.au>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M ncurses_wrap.c
Log Message:
-----------
ensure definitions are only done once
Init_ncurses_full() is called from a number of places, which may happen
multiple times after the module is initially require'd. In this case it
would produce a huge number of "method redefined" warnings, for example
in Sup's test suite now that there is a call to Ncurses.new_term.
Compare: https://github.com/sup-heliotrope/ncursesw-ruby/compare/b8132587a1c0...07ac8c9b0b9c
To unsubscribe from these emails, change your notification settings at https://github.com/sup-heliotrope/ncursesw-ruby/settings/notifications
reply other threads:[~2026-10-11 2:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sup-heliotrope/ncursesw-ruby/push/refs/heads/master/b81325-07ac8c@github.com \
--to=noreply@github.com \
--cc=djc@djc.id.au \
--cc=sup-commits@supmua.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox