From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by bl2.djc.id.au (Postfix) with ESMTPS id 048E8296446 for ; Sun, 11 Oct 2026 13:50:04 +1100 (AEDT) Authentication-Results: bl2.djc.id.au; dkim=pass (2048-bit key; unprotected) header.d=github.com header.i=@github.com header.a=rsa-sha256 header.s=pf2026 header.b=kX+qeMEe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2026; t=1791687003; bh=aiiGaHa9EqIYH0NQjIwGWDZqpBavVZoiC+Tn3FDdrTw=; h=Date:From:To:Subject:List-Unsubscribe:From; b=kX+qeMEei/XAiV/6XT8+9MnT6w5hbdPycqwdgqQ1GdqKXK7r3el8IzNCgtpRJrrCO wGf6JujPn5iBDaaKXy9mVasAm0Xw/HReyEB0jCGIAxMmQxnNq6aOnsVjBDqSt7IYlm wlPqgyuRFca/jKm7NIN5cm5ek1Oht9l5eDSCBG/C+qhuMIez17yG15O3bFYjE4HX+x bbUJz3tASQGZ/7Q3TcpAVFuAsQUQq+D3HR9TeY0kS0HVM6JTxWL0mvQCb7SUx4rRlF w160+WOkKfvFSRZGbV8VF0ReesSE/rpsCgYVpce+szb8kE3EvVZHdFijgerwtYY9J3 Y7ReeRCoxygxQ== Received: from github.com (hubbernetes-node-defb1b7.ash1-iad.github.net [10.56.191.36]) by smtp.github.com (Postfix) with ESMTPA id 30F1F3606B0; Sat, 10 Oct 2026 19:50:03 -0700 (PDT) Date: Sat, 10 Oct 2026 19:50:03 -0700 From: Dan Callaghan To: djc@djc.id.au, sup-commits@supmua.dev Message-ID: Subject: [sup-heliotrope/ncursesw-ruby] b76063: fix wrong argument passed to wenclose() Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Unsubscribe: X-GitHub-Recipient-Address: djc@djc.id.au,sup-commits@supmua.dev X-Auto-Response-Suppress: All X-Rspamd-Queue-Id: 048E8296446 List-Id: Branch: refs/heads/master Home: https://github.com/sup-heliotrope/ncursesw-ruby Commit: b760630f6ccbfa3c14ed552b6913b179475dc402 https://github.com/sup-heliotrope/ncursesw-ruby/commit/b760630f6ccbfa3c14ed552b6913b179475dc402 Author: Dan Callaghan Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M ncurses_wrap.c Log Message: ----------- fix wrong argument passed to wenclose() Commit: 4e4c03b8b720253a90fb6298a8b7857571f8c60d https://github.com/sup-heliotrope/ncursesw-ruby/commit/4e4c03b8b720253a90fb6298a8b7857571f8c60d Author: Dan Callaghan Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M ncurses_wrap.c Log Message: ----------- fix wrong argument handling in mvwgetch() Commit: 4f55077757cf64d7d402983d05964e2a98a6499c https://github.com/sup-heliotrope/ncursesw-ruby/commit/4f55077757cf64d7d402983d05964e2a98a6499c Author: Dan Callaghan Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M form_wrap.c M menu_wrap.c M ncurses_wrap.c Log Message: ----------- fix missing NULL checks for return values Commit: ecd4c8300b813f6dc26c7ffe2ba4b0bbad124415 https://github.com/sup-heliotrope/ncursesw-ruby/commit/ecd4c8300b813f6dc26c7ffe2ba4b0bbad124415 Author: Dan Callaghan Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M form_wrap.c M menu_wrap.c M ncurses_wrap.c M panel_wrap.c Log Message: ----------- migrate to TypedData_Wrap_Struct() and family This provides type checking before dereferencing the wrapped pointers passed back from Ruby, avoiding potential segfaults due to memory reinterpretation. Commit: 412d8fc2a66d20da280daa2536dd53d57d1232fe https://github.com/sup-heliotrope/ncursesw-ruby/commit/412d8fc2a66d20da280daa2536dd53d57d1232fe Author: Dan Callaghan Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M panel_wrap.c Log Message: ----------- add GC mark function for PANEL to mark userptr Otherwise a Ruby object saved in userptr may be garbage collected while it is still referenced by the PANEL, resulting in a user-after-free. Commit: 63c77b2506f6bb994f15f6bd5db25beb4754e747 https://github.com/sup-heliotrope/ncursesw-ruby/commit/63c77b2506f6bb994f15f6bd5db25beb4754e747 Author: Dan Callaghan Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M ncurses_wrap.c Log Message: ----------- fix add_wch() Make it construct an actual cchar_t value like wadd_wch() already does, rather than wrongly casting a wchar_t. Commit: ab7ef7466ce78093d4c97ae014c3d345dc71ac99 https://github.com/sup-heliotrope/ncursesw-ruby/commit/ab7ef7466ce78093d4c97ae014c3d345dc71ac99 Author: Dan Callaghan Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M ncurses_wrap.c Log Message: ----------- fix duplicate definition of pair_content method It was causing a warning in Sup's test suite, now that there is a call to Ncurses.newterm: test/unit/test_line_cursor_mode.rb:15: warning: method redefined; discarding old pair_content Commit: 07ac8c9b0b9c31b91e6c5192efdd79e96733a394 https://github.com/sup-heliotrope/ncursesw-ruby/commit/07ac8c9b0b9c31b91e6c5192efdd79e96733a394 Author: Dan Callaghan Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M ncurses_wrap.c Log Message: ----------- ensure definitions are only done once Init_ncurses_full() is called from a number of places, which may happen multiple times after the module is initially require'd. In this case it would produce a huge number of "method redefined" warnings, for example in Sup's test suite now that there is a call to Ncurses.new_term. Compare: https://github.com/sup-heliotrope/ncursesw-ruby/compare/b8132587a1c0...07ac8c9b0b9c To unsubscribe from these emails, change your notification settings at https://github.com/sup-heliotrope/ncursesw-ruby/settings/notifications