community/pipermail-archives/sup-devel/2010-03.txt (113929B) - raw
1 From michael+sup@stapelberg.de Mon Mar 1 08:45:54 2010
2 From: michael+sup@stapelberg.de (Michael Stapelberg)
3 Date: Mon, 01 Mar 2010 14:45:54 +0100
4 Subject: [sup-devel] [PATCH] Implement inline GPG
5 In-Reply-To: <1267293663-sup-2241@zyrg.net>
6 References: <1266493070-sup-7733@midna.zekjur.net>
7 <1267219197-sup-2428@zyrg.net>
8 <1267276103-sup-6406@midna.zekjur.net>
9 <1267293663-sup-2241@zyrg.net>
10 Message-ID: <1267450467-sup-4411@midna.zekjur.net>
11
12 Hi Rich,
13
14 Excerpts from Rich Lane's message of Sa Feb 27 19:05:58 +0100 2010:
15 > The problem is sign_start will be nil if the text isn't on a line by
16 > itself, causing a crash a few lines later. This happened to me when I
17 How about using the following solution?
18
19 gpg_start = "-----BEGIN PGP SIGNED MESSAGE-----"
20 gpg_end = "-----END PGP SIGNED MESSAGE-----"
21 gpg = lines.select { |l| true if l =~ /#{gpg_start}/ .. l =~ /#{gpg_end}/ }
22 msg.body = gpg.join("\n")
23
24 Is there a way to avoid the ugly "true if"? When just leaving it out, ruby
25 complained saying "ArgumentError: bad value for range".
26
27 Best regards,
28 Michael
29
30 From stettberger@dokucode.de Mon Mar 1 09:36:10 2010
31 From: stettberger@dokucode.de (Christian Dietrich)
32 Date: Mon, 01 Mar 2010 15:36:10 +0100
33 Subject: [sup-devel] [PATCH] Implement inline GPG
34 In-Reply-To: <1267450467-sup-4411@midna.zekjur.net>
35 References: <1266493070-sup-7733@midna.zekjur.net>
36 <1267219197-sup-2428@zyrg.net>
37 <1267276103-sup-6406@midna.zekjur.net>
38 <1267293663-sup-2241@zyrg.net>
39 <1267450467-sup-4411@midna.zekjur.net>
40 Message-ID: <1267454104-sup-9569@peer.zerties.org>
41
42 Excerpts from Michael Stapelberg's message of Mo M?r 01 14:45:54 +0100 2010:
43 > Hi Rich,
44 >
45 > Excerpts from Rich Lane's message of Sa Feb 27 19:05:58 +0100 2010:
46 > > The problem is sign_start will be nil if the text isn't on a line by
47 > > itself, causing a crash a few lines later. This happened to me when I
48 > How about using the following solution?
49 >
50 > gpg_start = "-----BEGIN PGP SIGNED MESSAGE-----"
51 > gpg_end = "-----END PGP SIGNED MESSAGE-----"
52 > gpg = lines.select { |l| true if l =~ /#{gpg_start}/ .. l =~ /#{gpg_end}/ }
53 > msg.body = gpg.join("\n")
54 >
55 > Is there a way to avoid the ugly "true if"? When just leaving it out, ruby
56 > complained saying "ArgumentError: bad value for range".
57
58 Hi, there,
59 tried this, but broke on this specific message, cause the string was
60 included but there was no signature.
61
62 This works for me:
63
64 517 ## Check for inline-PGP
65 518 if body =~ /^-----BEGIN PGP SIGNED MESSAGE-----/
66 519 gpg_start = "^-----BEGIN PGP SIGNED MESSAGE-----"
67 520 gpg_signature = "^-----BEGIN PGP SIGNATURE-----"
68 521 gpg_end = "^-----END PGP SIGNED MESSAGE-----"
69 522 gpg = lines.select { |l| true if l =~ /#{gpg_start}/ .. l =~ /#{gpg_end}/ }
70 523 body = lines.select { |l| true if l =~ /#{gpg_start}/ .. l =~ /#{gpg_signature}/ }
71 524 msg = RMail::Message.new
72 525 msg.body = gpg.join("\n")
73 526
74 527 payload = RMail::Message.new
75 528 payload.body = body[1..-2].join("\n")
76 529
77 530 File.open("/tmp/msg", "w+") {|f| f.write(msg.body)}
78 531 File.open("/tmp/payload", "w+") {|f| f.write(payload.body)}
79 532 return [CryptoManager.verify(nil, msg, false), message_to_chunks(payload)].flatten.compact
80 533 end
81
82 greetz didi
83 --
84 No documentation is better than bad documentation
85 -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
86 -------------- next part --------------
87 A non-text attachment was scrubbed...
88 Name: signature.asc
89 Type: application/pgp-signature
90 Size: 836 bytes
91 Desc: not available
92 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100301/ff92d5b2/attachment.bin>
93
94 From stettberger@dokucode.de Mon Mar 1 09:49:08 2010
95 From: stettberger@dokucode.de (Christian Dietrich)
96 Date: Mon, 01 Mar 2010 15:49:08 +0100
97 Subject: [sup-devel] [PATCH] fix textfield truncation
98 In-Reply-To: <1264146400-2101-1-git-send-email-rlane@club.cc.cmu.edu>
99 References: <1264146400-2101-1-git-send-email-rlane@club.cc.cmu.edu>
100 Message-ID: <1267454855-sup-1443@peer.zerties.org>
101
102 Excerpts from Rich Lane's message of Fr Jan 22 08:46:40 +0100 2010:
103 > Long query strings (for example) are (for some people) silently truncated.
104 > Other people have seen large amounts of whitespace inserted at word boundaries.
105 > These issues are caused by using a multiline text field. This patch uses a
106 > single-line dynamically growable textfield instead. It also disables the
107 > field-blanking misfeature.
108 > ---
109 > lib/sup/textfield.rb | 4 +++-
110 > 1 files changed, 3 insertions(+), 1 deletions(-)
111 >
112 > diff --git a/lib/sup/textfield.rb b/lib/sup/textfield.rb
113 > index 9afeb34..1c19751 100644
114 > --- a/lib/sup/textfield.rb
115 > +++ b/lib/sup/textfield.rb
116 > @@ -33,7 +33,9 @@ class TextField
117 > @w, @y, @x, @width = window, y, x, width
118 > @question = question
119 > @completion_block = block
120 > - @field = Ncurses::Form.new_field 1, @width - question.length, @y, @x + question.length, 256, 0
121 > + @field = Ncurses::Form.new_field 1, @width - question.length, @y, @x + question.length, 0, 0
122 > + @field.opts_off Ncurses::Form::O_STATIC
123 > + @field.opts_off Ncurses::Form::O_BLANK
124 > @form = Ncurses::Form.new_form [@field]
125 > @value = default || ''
126 > Ncurses::Form.post_form @form
127
128 Breaks sup here, says opts_off isn't a method, using
129
130 iU libncurses-ruby1.8 1.2.4-2 ruby Extension for the ncurses C library
131
132 from debian sid. What version should i use, in order to make this
133 work?
134
135 greetz didi
136
137 --
138 No documentation is better than bad documentation
139 -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
140 -------------- next part --------------
141 A non-text attachment was scrubbed...
142 Name: signature.asc
143 Type: application/pgp-signature
144 Size: 836 bytes
145 Desc: not available
146 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100301/43cbf62c/attachment.bin>
147
148 From stettberger@dokucode.de Mon Mar 1 09:50:14 2010
149 From: stettberger@dokucode.de (Christian Dietrich)
150 Date: Mon, 01 Mar 2010 15:50:14 +0100
151 Subject: [sup-devel] [PATCH] fix textfield truncation
152 In-Reply-To: <1267454855-sup-1443@peer.zerties.org>
153 References: <1264146400-2101-1-git-send-email-rlane@club.cc.cmu.edu>
154 <1267454855-sup-1443@peer.zerties.org>
155 Message-ID: <1267454978-sup-2249@peer.zerties.org>
156
157 Excerpts from Christian Dietrich's message of Mo M?r 01 15:49:08 +0100 2010:
158 > Breaks sup here, says opts_off isn't a method, using
159 >
160 > iU libncurses-ruby1.8 1.2.4-2 ruby Extension for the ncurses C library
161 >
162 > from debian sid. What version should i use, in order to make this
163 > work?
164
165 Sorry, didn't see the other message with the explanation yet.
166 --
167 No documentation is better than bad documentation
168 -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
169 -------------- next part --------------
170 A non-text attachment was scrubbed...
171 Name: signature.asc
172 Type: application/pgp-signature
173 Size: 836 bytes
174 Desc: not available
175 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100301/946b632b/attachment.bin>
176
177 From wmorgan-sup@masanjin.net Mon Mar 1 09:58:19 2010
178 From: wmorgan-sup@masanjin.net (William Morgan)
179 Date: Mon, 01 Mar 2010 09:58:19 -0500
180 Subject: [sup-devel] [PATCH] show (recipients) instead of lone "me"
181 In-Reply-To: <1264118145-sup-5806@ntdws12.chass.utoronto.ca>
182 References: <1264087996-sup-5125@changeling.local>
183 <1264109598-sup-3164@tilus.net>
184 <1264118145-sup-5806@ntdws12.chass.utoronto.ca>
185 Message-ID: <1267455489-sup-6918@masanjin.net>
186
187 Reformatted excerpts from Ben Walton's message of 2010-01-21:
188 > I didn't get a chance today, but I'd also give this a +1. It makes a
189 > good deal of sense.
190
191 I'm really digging this too.
192 --
193 William <wmorgan-sup at masanjin.net>
194
195 From wmorgan-sup@masanjin.net Mon Mar 1 09:58:59 2010
196 From: wmorgan-sup@masanjin.net (William Morgan)
197 Date: Mon, 01 Mar 2010 09:58:59 -0500
198 Subject: [sup-devel] [PATCH] dont check thread-index-mode dirtiness on
199 every keypress
200 In-Reply-To: <1264303037-17440-1-git-send-email-rlane@club.cc.cmu.edu>
201 References: <1264303037-17440-1-git-send-email-rlane@club.cc.cmu.edu>
202 Message-ID: <1267455526-sup-1315@masanjin.net>
203
204 Reformatted excerpts from Rich Lane's message of 2010-01-23:
205 > Now that changes are instantly written to the index it's unnecessary
206 > to put the "modified" message in the status line. Removing this cuts
207 > the time for a simple action like moving the cursor by 75% or more,
208 > depending on the number of messages loaded.
209
210 This is a really nice change.
211 --
212 William <wmorgan-sup at masanjin.net>
213
214 From stettberger@dokucode.de Mon Mar 1 10:23:56 2010
215 From: stettberger@dokucode.de (Christian Dietrich)
216 Date: Mon, 01 Mar 2010 16:23:56 +0100
217 Subject: [sup-devel] Searching unread messages in label-search-mode
218 In-Reply-To: <1267117624-sup-7108@peer.zerties.org>
219 References: <1267117624-sup-7108@peer.zerties.org>
220 Message-ID: <1267457007-sup-565@peer.zerties.org>
221
222 Excerpts from Christian Dietrich's message of Do Feb 25 18:09:06 +0100 2010:
223 > Hi,
224 > i just added the keystroke 'U' to the label search mode, so you just
225 > jump into a search with "AND is:unread" directly from the
226 > label-search-mode
227 >
228 > greetz didi
229 >
230 > http://github.com/stettberger/sup-mail/commit/fbf0f92a6e65ea2e5c56565a92166af2b0c07446
231
232 Any chance this is going into next or master?
233
234 greetz didi
235 --
236 No documentation is better than bad documentation
237 -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
238 -------------- next part --------------
239 A non-text attachment was scrubbed...
240 Name: signature.asc
241 Type: application/pgp-signature
242 Size: 836 bytes
243 Desc: not available
244 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100301/6927e4f8/attachment.bin>
245
246 From michael+sup@stapelberg.de Mon Mar 1 11:49:30 2010
247 From: michael+sup@stapelberg.de (Michael Stapelberg)
248 Date: Mon, 01 Mar 2010 17:49:30 +0100
249 Subject: [sup-devel] [PATCH] Implement inline GPG
250 In-Reply-To: <1267454104-sup-9569@peer.zerties.org>
251 References: <1266493070-sup-7733@midna.zekjur.net>
252 <1267219197-sup-2428@zyrg.net>
253 <1267276103-sup-6406@midna.zekjur.net>
254 <1267293663-sup-2241@zyrg.net>
255 <1267450467-sup-4411@midna.zekjur.net>
256 <1267454104-sup-9569@peer.zerties.org>
257 Message-ID: <1267462001-sup-1957@midna.zekjur.net>
258
259 Hi didi,
260
261 Excerpts from Christian Dietrich's message of Mo M?r 01 15:36:10 +0100 2010:
262 > tried this, but broke on this specific message, cause the string was
263 > included but there was no signature.
264 Can you forward this message so that I can have a look, please?
265
266 > 517 ## Check for inline-PGP
267 > 518 if body =~ /^-----BEGIN PGP SIGNED MESSAGE-----/
268 > 519 gpg_start = "^-----BEGIN PGP SIGNED MESSAGE-----"
269 > 520 gpg_signature = "^-----BEGIN PGP SIGNATURE-----"
270 > 521 gpg_end = "^-----END PGP SIGNED MESSAGE-----"
271 Why do you use ^ in the beginning but not $ in the end?
272
273 Best regards,
274 Michael
275
276 From rlane@club.cc.cmu.edu Mon Mar 1 11:56:43 2010
277 From: rlane@club.cc.cmu.edu (Rich Lane)
278 Date: Mon, 01 Mar 2010 11:56:43 -0500
279 Subject: [sup-devel] Searching unread messages in label-search-mode
280 In-Reply-To: <1267457007-sup-565@peer.zerties.org>
281 References: <1267117624-sup-7108@peer.zerties.org>
282 <1267457007-sup-565@peer.zerties.org>
283 Message-ID: <1267462086-sup-6796@zyrg.net>
284
285 Please resubmit using git-send-email.
286
287 Instead of constructing a query string and spawning a SearchResultsMode,
288 take advantage of LabelSearchResultsMode.new accepting an array
289 of labels. I suggest modifying LabelSearchResultsMode#spawn_nicely to
290 take a *labels argument instead of just one label.
291
292 From stettberger@dokucode.de Mon Mar 1 12:46:52 2010
293 From: stettberger@dokucode.de (Christian Dietrich)
294 Date: Mon, 01 Mar 2010 18:46:52 +0100
295 Subject: [sup-devel] [PATCH] Implement inline GPG
296 In-Reply-To: <1267462001-sup-1957@midna.zekjur.net>
297 References: <1266493070-sup-7733@midna.zekjur.net>
298 <1267219197-sup-2428@zyrg.net>
299 <1267276103-sup-6406@midna.zekjur.net>
300 <1267293663-sup-2241@zyrg.net>
301 <1267450467-sup-4411@midna.zekjur.net>
302 <1267454104-sup-9569@peer.zerties.org>
303 <1267462001-sup-1957@midna.zekjur.net>
304 Message-ID: <1267465546-sup-2321@peer.zerties.org>
305
306 Excerpts from Michael Stapelberg's message of Mo M?r 01 17:49:30 +0100 2010:
307 > Hi didi,
308 >
309 > Excerpts from Christian Dietrich's message of Mo M??r 01 15:36:10 +0100 2010:
310 > > tried this, but broke on this specific message, cause the string was
311 > > included but there was no signature.
312 > Can you forward this message so that I can have a look, please?
313
314 It was your message with the patch.
315
316 <1267450467-sup-4411 at midna.zekjur.net>
317
318 >
319 > > 517 ## Check for inline-PGP
320 > > 518 if body =~ /^-----BEGIN PGP SIGNED MESSAGE-----/
321 > > 519 gpg_start = "^-----BEGIN PGP SIGNED MESSAGE-----"
322 > > 520 gpg_signature = "^-----BEGIN PGP SIGNATURE-----"
323 > > 521 gpg_end = "^-----END PGP SIGNED MESSAGE-----"
324 > Why do you use ^ in the beginning but not $ in the end?
325
326 You never know what kind of crude mailers are out there.
327
328 greetz didi
329 --
330 No documentation is better than bad documentation
331 -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.
332 -------------- next part --------------
333 A non-text attachment was scrubbed...
334 Name: signature.asc
335 Type: application/pgp-signature
336 Size: 836 bytes
337 Desc: not available
338 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100301/f8508232/attachment.bin>
339
340 From tarko@lanparty.ee Tue Mar 2 09:47:42 2010
341 From: tarko@lanparty.ee (Tarko Tikan)
342 Date: Tue, 02 Mar 2010 16:47:42 +0200
343 Subject: [sup-devel] [issue47] utf-8 regression: search&inbox views has
344 garbled utf-8
345 In-Reply-To: <1264352828.18.0.950975059303.issue47@masanjin.net>
346 References: <1264352828.18.0.950975059303.issue47@masanjin.net>
347 Message-ID: <1267541118-sup-2994@lanparty.ee>
348
349 hey,
350
351 I hit the same bug after upgrade and I've logged my findings (and workarounds) to http://masanjin.net/sup-bugs/issue47
352
353 I think the snippet issue might be because http://gitorious.org/sup/mainline/commit/f26d4052c5bf5f327239e8555f4167a2cfa0e00f - snippet might already be wrongly converted in index or needs conversion before display.
354
355 --
356 tarko
357
358 From rlane@club.cc.cmu.edu Thu Mar 4 02:48:16 2010
359 From: rlane@club.cc.cmu.edu (Rich Lane)
360 Date: Thu, 04 Mar 2010 02:48:16 -0500
361 Subject: [sup-devel] now in next: sup-cmd
362 Message-ID: <1267687531-sup-5689@zyrg.net>
363
364 I already had the code for a sup-server sup-cmd sitting around, so I
365 wrote a small compatibility layer that lets it run using the mainline
366 index API. It outputs YAML.
367
368 Usage:
369 sup-cmd count 'is:inbox'
370 sup-cmd query --offset 10 --limit 5 'is:unread'
371 sup-cmd label --add-labels 'bugs' --remove-labels 'inbox' 'is:inbox AND from:bugzilla'
372 sup-cmd add --labels 'sent' < email
373
374 From nicolas.pouillard@gmail.com Thu Mar 4 08:10:39 2010
375 From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
376 Date: Thu, 04 Mar 2010 05:10:39 -0800 (PST)
377 Subject: [sup-devel] now in next: sup-cmd
378 In-Reply-To: <1267687531-sup-5689@zyrg.net>
379 References: <1267687531-sup-5689@zyrg.net>
380 Message-ID: <4b8fb14f.0702d00a.5427.ffffe469@mx.google.com>
381
382 On Thu, 04 Mar 2010 02:48:16 -0500, Rich Lane <rlane at club.cc.cmu.edu> wrote:
383 > I already had the code for a sup-server sup-cmd sitting around, so I
384 > wrote a small compatibility layer that lets it run using the mainline
385 > index API. It outputs YAML.
386 >
387 > Usage:
388 > sup-cmd count 'is:inbox'
389 > sup-cmd query --offset 10 --limit 5 'is:unread'
390 > sup-cmd label --add-labels 'bugs' --remove-labels 'inbox' 'is:inbox AND from:bugzilla'
391 > sup-cmd add --labels 'sent' < email
392
393 This is great!
394
395 BTW is there any hope to reach a kind of concensus of a nice CLI API with
396 notmuch people?
397
398 --
399 Nicolas Pouillard
400 http://nicolaspouillard.fr
401
402 From cworth@cworth.org Thu Mar 4 13:25:06 2010
403 From: cworth@cworth.org (Carl Worth)
404 Date: Thu, 04 Mar 2010 10:25:06 -0800
405 Subject: [sup-devel] now in next: sup-cmd
406 In-Reply-To: <4b8fb14f.0702d00a.5427.ffffe469@mx.google.com>
407 References: <1267687531-sup-5689@zyrg.net>
408 <4b8fb14f.0702d00a.5427.ffffe469@mx.google.com>
409 Message-ID: <87bpf4eygt.fsf@yoom.home.cworth.org>
410
411 On Thu, 04 Mar 2010 05:10:39 -0800 (PST), Nicolas Pouillard <nicolas.pouillard at gmail.com> wrote:
412 > > sup-cmd count 'is:inbox'
413 > > sup-cmd query --offset 10 --limit 5 'is:unread'
414 > > sup-cmd label --add-labels 'bugs' --remove-labels 'inbox' 'is:inbox AND from:bugzilla'
415 > > sup-cmd add --labels 'sent' < email
416 >
417 > This is great!
418 >
419 > BTW is there any hope to reach a kind of concensus of a nice CLI API with
420 > notmuch people?
421
422 It seems to me, at least, like that would be a worthwhile effort.
423
424 I still consider the notmuch UI young enough that it's still quite
425 flexible. And I'm here on the sup list if we want to talk here.
426
427 For reference, the rough equivalent of the above commands in notmuch
428 would be (with footnotes where things don't match exactly):
429
430 notmuch count 'tag:inbox'
431 notmuch search 'tag:unread' [*]
432 notmuch tag +bugs -inbox 'tag:inbox AND from:bugzilla'
433 notmuch new [**]
434
435 So, I obviously switched from "label" to "tag" when I moved from sup to
436 notmuch. But I do like the "is:" prefix---I can easily see adding that
437 at least.
438
439 -Carl
440
441 [*] Notmuch currently doesn't have an equivalent of --offset and --limit
442 but did have --first and --max-threads for a while, (and we'll probably
443 be adding the same feature back again). The names of "offset" and "limit"
444 sound good to me.
445
446 [**] "notmuch new" is certainly only a very poor approximation of
447 "sup-cmd add". The notmuch cli does not currently have any way to add an
448 explicit file, (instead, "notmuch new" simply finds all new, renamed,
449 and deleted files within the mail store). By the way, what's the
450 semantic for "sup-cmd add" when it accepts a message on stdin? How is
451 the message content every returned later?
452 -------------- next part --------------
453 A non-text attachment was scrubbed...
454 Name: not available
455 Type: application/pgp-signature
456 Size: 189 bytes
457 Desc: not available
458 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100304/e5f1bcfd/attachment.bin>
459
460 From nicolas.pouillard@gmail.com Fri Mar 5 03:40:27 2010
461 From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
462 Date: Fri, 05 Mar 2010 00:40:27 -0800 (PST)
463 Subject: [sup-devel] now in next: sup-cmd
464 In-Reply-To: <87bpf4eygt.fsf@yoom.home.cworth.org>
465 References: <1267687531-sup-5689@zyrg.net>
466 <4b8fb14f.0702d00a.5427.ffffe469@mx.google.com>
467 <87bpf4eygt.fsf@yoom.home.cworth.org>
468 Message-ID: <4b90c37b.1701d00a.2f5e.2688@mx.google.com>
469
470 On Thu, 04 Mar 2010 10:25:06 -0800, Carl Worth <cworth at cworth.org> wrote:
471 > On Thu, 04 Mar 2010 05:10:39 -0800 (PST), Nicolas Pouillard <nicolas.pouillard at gmail.com> wrote:
472 > > > sup-cmd count 'is:inbox'
473 > > > sup-cmd query --offset 10 --limit 5 'is:unread'
474 > > > sup-cmd label --add-labels 'bugs' --remove-labels 'inbox' 'is:inbox AND from:bugzilla'
475 > > > sup-cmd add --labels 'sent' < email
476 > >
477 > > This is great!
478 > >
479 > > BTW is there any hope to reach a kind of concensus of a nice CLI API with
480 > > notmuch people?
481 >
482 > It seems to me, at least, like that would be a worthwhile effort.
483 >
484 > I still consider the notmuch UI young enough that it's still quite
485 > flexible. And I'm here on the sup list if we want to talk here.
486 >
487 > For reference, the rough equivalent of the above commands in notmuch
488 > would be (with footnotes where things don't match exactly):
489 >
490 > notmuch count 'tag:inbox'
491 > notmuch search 'tag:unread' [*]
492 > notmuch tag +bugs -inbox 'tag:inbox AND from:bugzilla'
493 > notmuch new [**]
494
495 About the sup-cmd label vs notmuch tag commands, I prefer the notmuch syntax.
496 Moreover an alias could be added to both to unify between label and tag.
497
498 > So, I obviously switched from "label" to "tag" when I moved from sup to
499 > notmuch. But I do like the "is:" prefix---I can easily see adding that
500 > at least.
501
502 Yes please add the is: prefix too, tag: was added to sup.
503
504 Regards,
505
506 --
507 Nicolas Pouillard
508 http://nicolaspouillard.fr
509
510 From scott@foolishpride.org Mon Mar 8 00:45:54 2010
511 From: scott@foolishpride.org (Scott Henson)
512 Date: Mon, 8 Mar 2010 00:45:54 -0500
513 Subject: [sup-devel] Writing changes back to sources
514 Message-ID: <6c0c31751003072145r13f3bdd0m37f47c71995af06e@mail.gmail.com>
515
516 I've been working on getting writing changes back to maildirs. I've got a
517 stab that basically re-implements sup-sync-back in its own script, but I'm
518 not really satisfied with it. What I would like to be is create a script
519 that will modify a source with an arbitrary sup expression. I guess some
520 examples would be a good way to show what I am talking about.
521
522 $ sup-write --drop "is:deleted" maildir:/home/user/Mail/INBOX
523
524 This would drop all mail matching the expression "is:deleted" from the INBOX
525 source.
526
527 $ sup-write --archive maildir:/home/user/Mail/Archives "!label:inbox"
528 maildir:/home/user/Mail/INBOX
529
530 This would move all messages from the INBOX to Archives that have been
531 archived.
532
533 $ sup-write --store "has:mailist" maildir:/home/user/Mail/Lists
534
535 This would find all messages in the Index and write them to the source.
536
537 You could put any valid sup expression in the above and have it push the
538 results out to the requested sources. You could specify multiple sources to
539 have it applied across all of them. My thought is that you would write a
540 series of scripts to push changes to the index down to the sources. For
541 instance, remove all deleted mail and spam, then store labels to their own
542 sources (good for gmail integration) and finally archive what is left.
543
544 To do the above I think we probably need standardize how messages are added
545 and removed from sources. The maildir source has store_message and delete.
546 I would suppose that we would need to implement something similar for the
547 other sources (is mbox the only other one left?). Does this seem to be a
548 good idea or do we want to continue having different ways of writing back to
549 sources?
550
551 --
552 Scott Henson
553 -------------- next part --------------
554 An HTML attachment was scrubbed...
555 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100308/2d44d282/attachment.html>
556
557 From scott@foolishpride.org Mon Mar 8 00:41:28 2010
558 From: scott@foolishpride.org (Scott Henson)
559 Date: Mon, 8 Mar 2010 00:41:28 -0500
560 Subject: [sup-devel] Maildir souce id rework
561 In-Reply-To: <6c0c31751003072119i4c330800s6b508157544165e6@mail.gmail.com>
562 References: <6c0c31751003072119i4c330800s6b508157544165e6@mail.gmail.com>
563 Message-ID: <6c0c31751003072141mc3f0d00sfcf9cb5be18b6adc@mail.gmail.com>
564
565 On Mon, Mar 8, 2010 at 12:19 AM, Scott Henson <sjh at foolishpride.org> wrote:
566
567 > I've created a branch that changes the id that the maildir source returns,
568 > which is then used as the source_info field inside the index. It seems to
569 > work well for me and I'd appreciate some more testing. This work should
570 > make the maildir source more robust and more friendly to other clients
571 > accessing the source without completely throwing sup for a loop. It will
572 > also help sync back for maildir (more on this in a second email).
573 >
574 > A couple notes. First, the base source.rb class says that the id returned
575 > needs to be an integer, but that doesn't seem to be the case. Also, you'll
576 > note that start_offset and end_offset are not really telling the truth in my
577 > version of the maildir source. This doesn't seem to be a problem as nothing
578 > seems to be using those two functions. Second, this source might be
579 > slightly slower in some places than the original source and faster in
580 > others. I think most of the work is done in scan_mailbox and the rest of
581 > the source should be pretty light. If anyone has any ideas on how to make
582 > scan_mailbox lighter, I'd be very interested. Also, reset might take a
583 > while since it has to sort the ids array.
584 >
585 > Any help in making this better would be much appreciated. Thanks.
586 >
587 >
588 Probably need to provide a link.
589 http://github.com/shenson/sup/tree/maildir
590
591
592
593
594 --
595 Scott Henson
596 -------------- next part --------------
597 An HTML attachment was scrubbed...
598 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100308/c66a9697/attachment.html>
599
600 From rlane@club.cc.cmu.edu Mon Mar 8 00:57:40 2010
601 From: rlane@club.cc.cmu.edu (Rich Lane)
602 Date: Mon, 08 Mar 2010 00:57:40 -0500
603 Subject: [sup-devel] [ANN] Sup 0.11 released
604 Message-ID: <1268026262-sup-1918@zyrg.net>
605
606 I'm pleased to announce the release of Sup 0.11.
607
608 Sup is a console-based email client for people with a lot of email.
609 It supports tagging, very fast full-text search, automatic contact-
610 list management, and more. If you're the type of person who treats
611 email as an extension of your long-term memory, Sup is for you.
612
613 Get it: gem install sup
614 Learn it: http://sup.rubyforge.org
615 Love it: sup-talk at rubyforge.org
616
617 Release notes:
618
619 The deprecated Ferret index has been removed.
620
621 Remote sources (IMAP, IMAPS, and mbox+ssh) have been deprecated and will be
622 removed in 0.12. Tools like offlineimap, fetchmail, and rsync provide a much
623 better user experience for these mail sources than Sup would ever be able to by
624 itself.
625
626 If your terminal supports it you can now use 256 colors in your colorscheme. Run
627 the contrib/colorpicker.rb program to get the color names to put in colors.yaml.
628
629 Saved searches are now supported. Hit '%' in search-results-mode to save the
630 current search, and enter an empty search string to open the list of saved
631 searches.
632
633 Changelog for 0.11:
634 * Remove deprecated Ferret backend.
635 * Add deprecation notices to IMAP, IMAPS, and mbox+ssh sources.
636 * 256 color support.
637 * Backwards-compatible index format improvements.
638 * Saved searches.
639 * Improved support for custom keybindings.
640 * Idle detection - poll totals accumulate and index flushes on idle.
641 * Several textfield improvments.
642 * New hooks: publish, mentions-attachments, keybindings,
643 index-mode-date-widget, gpg-args, and crypto-settings.
644 * sup-cmd for easy programmatic access to a Sup index.
645 * As always, many bugfixes and tweaks.
646
647 From sup-bugs@masanjin.net Mon Mar 8 18:05:18 2010
648 From: sup-bugs@masanjin.net (anonymous)
649 Date: Mon, 08 Mar 2010 23:05:18 +0000
650 Subject: [sup-devel] [issue74] sup-dump producing empty file in latest
651 release
652 In-Reply-To: <1268089517.99.0.931999852916.issue74@masanjin.net>
653 Message-ID: <1268089517.99.0.931999852916.issue74@masanjin.net>
654
655
656 New submission from anonymous:
657
658 sup-dump produces an empty dump file with git next (0.11 is probably closest
659 release). I updated this morning after the release announcement and started the
660 process to switch to xapian. Luckily I checked the dumpfile produced because it
661 turned out empty :(
662
663 ----------
664 messages: 187
665 nosy: anonymous
666 priority: bug
667 ruby_version: 1.8.5
668 status: unread
669 sup_version: 0.11/next
670 title: sup-dump producing empty file in latest release
671
672 _________________________________________
673 Sup issue tracker <sup-bugs at masanjin.net>
674 <http://masanjin.net/sup-bugs/issue74>
675 _________________________________________
676
677 From marcus-sup@quintic.co.uk Tue Mar 9 04:48:05 2010
678 From: marcus-sup@quintic.co.uk (marcus-sup at quintic.co.uk)
679 Date: Tue, 09 Mar 2010 09:48:05 +0000
680 Subject: [sup-devel] [issue74] sup-dump producing empty file in latest
681 release
682 In-Reply-To: <1268089517.99.0.931999852916.issue74@masanjin.net>
683 References: <1268089517.99.0.931999852916.issue74@masanjin.net>
684 Message-ID: <4B961955.7000306@quintic.co.uk>
685
686 On 08/03/2010 23:05, anonymous wrote:
687 > sup-dump produces an empty dump file with git next (0.11 is probably closest
688 > release). I updated this morning after the release announcement and started the
689 > process to switch to xapian. Luckily I checked the dumpfile produced because it
690 > turned out empty:(
691
692 I reported this, so if any more information is needed I'm on this list
693 (and obviously I'm tracking it in the issue tracker).
694
695 Marcus
696
697
698 From michael+sup@stapelberg.de Tue Mar 9 11:43:03 2010
699 From: michael+sup@stapelberg.de (Michael Stapelberg)
700 Date: Tue, 09 Mar 2010 17:43:03 +0100
701 Subject: [sup-devel] [PATCH] Implement inline GPG (updated)
702 In-Reply-To: <1267465546-sup-2321@peer.zerties.org>
703 References: <1266493070-sup-7733@midna.zekjur.net>
704 <1267219197-sup-2428@zyrg.net>
705 <1267276103-sup-6406@midna.zekjur.net>
706 <1267293663-sup-2241@zyrg.net>
707 <1267450467-sup-4411@midna.zekjur.net>
708 <1267454104-sup-9569@peer.zerties.org>
709 <1267462001-sup-1957@midna.zekjur.net>
710 <1267465546-sup-2321@peer.zerties.org>
711 Message-ID: <1268152912-sup-4673@midna.zekjur.net>
712
713 Hi everybody,
714
715 Excerpts from Christian Dietrich's message of Mo M?r 01 18:46:52 +0100 2010:
716 > It was your message with the patch.
717 Alright, tested it and reworked my patch. The latest version is attached.
718
719 Hope it is good enough to get merged now ;-).
720
721 Best regards,
722 Michael
723 -------------- next part --------------
724 A non-text attachment was scrubbed...
725 Name: 0001-Implement-inline-GPG.patch
726 Type: application/octet-stream
727 Size: 7614 bytes
728 Desc: not available
729 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100309/95bc67d6/attachment.obj>
730
731 From sup-bugs@masanjin.net Tue Mar 9 12:02:56 2010
732 From: sup-bugs@masanjin.net (Peter Harkins)
733 Date: Tue, 09 Mar 2010 17:02:56 +0000
734 Subject: [sup-devel] [issue75] Crash,
735 untouchable threads - DocNotFoundError: No termlist for document
736 In-Reply-To: <1268154176.59.0.385153871492.issue75@masanjin.net>
737 Message-ID: <1268154176.59.0.385153871492.issue75@masanjin.net>
738
739
740 New submission from Peter Harkins <ph at malaprop.org>:
741
742 I have three spam threads in my inbox. If I try to interact with them in any way
743 - view them, spam them, delete them, etc. - sup crashes.
744
745 I'd appreciate any suggestions for how to get rid of them.
746
747 --- RuntimeError from thread: index sync
748 DocNotFoundError: No termlist for document 2362106147
749 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:600:in `old_add_term'
750 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:600:in `add_term'
751 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:510:in
752 `index_message_labels'
753 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:510:in `each'
754 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:510:in
755 `index_message_labels'
756 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:446:in `sync_message'
757 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/xapian_index.rb:98:in
758 `update_message_state'
759 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/index.rb:205:in `run_sync_worker'
760 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/index.rb:192:in `start_sync_worker'
761 /home/harkins/.gems/gems/sup-0.10.2/lib/sup.rb:77:in `reporting_thread'
762 /home/harkins/.gems/gems/sup-0.10.2/lib/sup.rb:75:in `initialize'
763 /home/harkins/.gems/gems/sup-0.10.2/lib/sup.rb:75:in `new'
764 /home/harkins/.gems/gems/sup-0.10.2/lib/sup.rb:75:in `reporting_thread'
765 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/index.rb:192:in `start_sync_worker'
766 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/index.rb:236:in `send'
767 /home/harkins/.gems/gems/sup-0.10.2/lib/sup/index.rb:236:in `method_missing'
768 /home/harkins/.gems/gems/sup-0.10.2/bin/sup:170
769 /home/harkins/.gems/bin/sup:19:in `load'
770 /home/harkins/.gems/bin/sup:19
771
772 ----------
773 messages: 189
774 nosy: Harkins
775 priority: bug
776 ruby_version: 1.8.7
777 status: unread
778 sup_version: 0.10.2
779 title: Crash, untouchable threads - DocNotFoundError: No termlist for document
780
781 _________________________________________
782 Sup issue tracker <sup-bugs at masanjin.net>
783 <http://masanjin.net/sup-bugs/issue75>
784 _________________________________________
785
786 From michael+sup@stapelberg.de Tue Mar 9 12:04:27 2010
787 From: michael+sup@stapelberg.de (Michael Stapelberg)
788 Date: Tue, 09 Mar 2010 18:04:27 +0100
789 Subject: [sup-devel] [PATCH] Correctly pad date strings,
790 as they might contain utf-8 characters
791 Message-ID: <1268154208-sup-7661@midna.zekjur.net>
792
793 Hi,
794
795 attached you find a patch for this problem. Quote of the commit message:
796
797 sprintf is not utf8-aware and thus the output gets a wrong padding
798 (correct in terms of bytes, not correct in terms of visible characters).
799 You can notice this using a german locale (de_DE) and viewing mails
800 from march (abbreviated "M?r" in german).
801
802 Best regards,
803 Michael
804 -------------- next part --------------
805 A non-text attachment was scrubbed...
806 Name: 0001-Correctly-pad-date-strings-as-they-might-contain-utf.patch
807 Type: application/octet-stream
808 Size: 1479 bytes
809 Desc: not available
810 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100309/1aa5e413/attachment.obj>
811
812 From michael+sup@stapelberg.de Tue Mar 9 12:54:18 2010
813 From: michael+sup@stapelberg.de (Michael Stapelberg)
814 Date: Tue, 09 Mar 2010 18:54:18 +0100
815 Subject: [sup-devel] [PATCH] new hook: compose-from
816 Message-ID: <1268157224-sup-7509@midna.zekjur.net>
817
818 Hi,
819
820 This hook is useful to use different names/addresses depending on the
821 destination address, subject, etc. of the message. Example:
822
823 if header["To"] and header["To"] =~ /^sup-(.*)@rubyforge\.org$/
824 Person.from_address "Michael Stapelberg <michael+sup at stapelberg.de>"
825 end
826
827
828 Best regards,
829 Michael
830 -------------- next part --------------
831 A non-text attachment was scrubbed...
832 Name: 0001-new-hook-compose-from.patch
833 Type: application/octet-stream
834 Size: 2209 bytes
835 Desc: not available
836 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100309/92da77e6/attachment.obj>
837
838 From ezyang@MIT.EDU Tue Mar 9 13:18:00 2010
839 From: ezyang@MIT.EDU (Edward Z. Yang)
840 Date: Tue, 09 Mar 2010 13:18:00 -0500
841 Subject: [sup-devel] [PATCH] new hook: compose-from
842 In-Reply-To: <1268157224-sup-7509@midna.zekjur.net>
843 References: <1268157224-sup-7509@midna.zekjur.net>
844 Message-ID: <1268158650-sup-7148@ezyang>
845
846 Excerpts from Michael Stapelberg's message of Tue Mar 09 12:54:18 -0500 2010:
847 > This hook is useful to use different names/addresses depending on the
848 > destination address, subject, etc. of the message. Example:
849 >
850 > if header["To"] and header["To"] =~ /^sup-(.*)@rubyforge\.org$/
851 > Person.from_address "Michael Stapelberg <michael+sup at stapelberg.de>"
852 > end
853
854 I use before-edit.rb to do a similar thing. Are the semantics the same?
855
856 Cheers,
857 Edward
858
859 From michael+sup@stapelberg.de Tue Mar 9 17:21:46 2010
860 From: michael+sup@stapelberg.de (Michael Stapelberg)
861 Date: Tue, 09 Mar 2010 23:21:46 +0100
862 Subject: [sup-devel] [PATCH] new hook: compose-from
863 In-Reply-To: <1268158650-sup-7148@ezyang>
864 References: <1268157224-sup-7509@midna.zekjur.net> <1268158650-sup-7148@ezyang>
865 Message-ID: <1268173241-sup-7958@midna.zekjur.net>
866
867 Hi Edward,
868
869 Excerpts from Edward Z. Yang's message of Di M?r 09 19:18:00 +0100 2010:
870 > I use before-edit.rb to do a similar thing. Are the semantics the same?
871 Roughly. header["To"] contains a full string (not only the entered address)
872 and you have to set header["From"] to a string instead of a Person object.
873
874 But yeah, seems like you are right and this hook is redundant.
875
876 Best regards,
877 Michael
878
879 From michael+sup@stapelberg.de Tue Mar 9 17:58:33 2010
880 From: michael+sup@stapelberg.de (Michael Stapelberg)
881 Date: Tue, 09 Mar 2010 23:58:33 +0100
882 Subject: [sup-devel] [PATCH] Use multiple body arrays when calling
883 before-edit for each reply type
884 In-Reply-To: <1267295207-sup-7090@zyrg.net>
885 References: <1264026370-sup-8092@midna.zekjur.net>
886 <1267295207-sup-7090@zyrg.net>
887 Message-ID: <1268175393-sup-8314@midna.zekjur.net>
888
889 Hi Rich,
890
891 Excerpts from Rich Lane's message of Sa Feb 27 19:29:27 +0100 2010:
892 > What happens when you edit the message and then select another reply type?
893 You are right, there was a problem here. I reworked the patch, it now behaves
894 like this:
895 As long as you did not edit the message, selecting another reply type changes
896 the body. As soon as you edit one of the bodies, only the headers will be
897 changed if you switch to a different reply type.
898
899 You find the new version of the patch attached to this mail.
900
901 Best regards,
902 Michael
903 -------------- next part --------------
904 A non-text attachment was scrubbed...
905 Name: 0001-Use-multiple-body-arrays-when-calling-before-edit-fo.patch
906 Type: application/octet-stream
907 Size: 2475 bytes
908 Desc: not available
909 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100309/024357bf/attachment.obj>
910
911 From cworth@cworth.org Tue Mar 9 19:08:11 2010
912 From: cworth@cworth.org (Carl Worth)
913 Date: Tue, 09 Mar 2010 16:08:11 -0800
914 Subject: [sup-devel] now in next: sup-cmd
915 In-Reply-To: <4b90c37b.1701d00a.2f5e.2688@mx.google.com>
916 References: <1267687531-sup-5689@zyrg.net>
917 <4b8fb14f.0702d00a.5427.ffffe469@mx.google.com>
918 <87bpf4eygt.fsf@yoom.home.cworth.org>
919 <4b90c37b.1701d00a.2f5e.2688@mx.google.com>
920 Message-ID: <87ocix82dw.fsf@yoom.home.cworth.org>
921
922 In a recent thread on the sup mailing list there was discussion of the
923 similarities of the recently-added sup-cmd command-line interface with
924 that of notmuch. And there was at least one proposal for adding some
925 syntax to notmuch:
926
927 On Fri, 05 Mar 2010 00:40:27 -0800 (PST), Nicolas Pouillard <nicolas.pouillard at gmail.com> wrote:
928 > Yes please add the is: prefix too, tag: was added to sup.
929
930 I've just added this to notmuch. So you can now search for "is:unread"
931 as a synonym for "tag:unread".
932
933 Have fun,
934
935 -Carl
936 -------------- next part --------------
937 A non-text attachment was scrubbed...
938 Name: not available
939 Type: application/pgp-signature
940 Size: 189 bytes
941 Desc: not available
942 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100309/d836a38d/attachment.bin>
943
944 From ezyang@MIT.EDU Tue Mar 9 23:50:23 2010
945 From: ezyang@MIT.EDU (Edward Z. Yang)
946 Date: Tue, 09 Mar 2010 23:50:23 -0500
947 Subject: [sup-devel] Mysterious nil errors
948 Message-ID: <1268196562-sup-1692@ezyang>
949
950 Here are some patches that correct some mysterious Nil errors. I don't
951 know what messages caused them or if they're correct. I don't really want
952 them to go in, but I would like to know further directions.
953
954 diff --git a/lib/sup/message.rb b/lib/sup/message.rb
955 index ebc73fc..ec12039 100644
956 --- a/lib/sup/message.rb
957 +++ b/lib/sup/message.rb
958 @@ -436,12 +436,12 @@ private
959 end
960
961 unless chunks
962 - sibling_types = m.body.map { |p| p.header.content_type }
963 + sibling_types = m.body.map { |p| p.header["content_type"] ? p.header.content_type : "application/unknown" }
964 chunks = m.body.map { |p| message_to_chunks p, encrypted, sibling_types }.flatten.compact
965 end
966
967 chunks
968 - elsif m.header.content_type && m.header.content_type.downcase == "message/rfc822"
969 + elsif m.header["content_type"] && m.header.content_type && m.header.content_type.downcase == "message/rfc822"
970 if m.body
971 payload = RMail::Parser.read(m.body)
972 from = payload.header.from.first ? payload.header.from.first.format : ""
973 @@ -458,7 +458,7 @@ private
974 debug "no body for message/rfc822 enclosure; skipping"
975 []
976 end
977 - elsif m.header.content_type && m.header.content_type.downcase == "application/pgp" && m.body
978 + elsif m.header["content_type"] && m.header.content_type && m.header.content_type.downcase == "application/pgp" && m.body
979 ## apparently some versions of Thunderbird generate encryped email that
980 ## does not follow RFC3156, e.g. messages with X-Enigmail-Version: 0.95.0
981 ## they have no MIME multipart and just set the body content type to
982 @@ -503,7 +503,7 @@ private
983 # Lowercase the filename because searches are easier that way
984 @attachments.push filename.downcase unless filename =~ /^sup-attachment-/
985 add_label :attachment unless filename =~ /^sup-attachment-/
986 - content_type = (m.header.content_type || "application/unknown").downcase # sometimes RubyMail gives us nil
987 + content_type = (m.header["content_type"] && m.header.content_type || "application/unknown").downcase # sometimes RubyMail gives us nil
988 [Chunk::Attachment.new(content_type, filename, m, sibling_types)]
989
990 ## otherwise, it's body text
991 diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
992 index f53001f..84399d3 100644
993 --- a/lib/sup/modes/thread-index-mode.rb
994 +++ b/lib/sup/modes/thread-index-mode.rb
995 @@ -231,7 +231,7 @@ EOS
996 old_cursor_thread = cursor_thread
997 @mutex.synchronize do
998 ## let's see you do THIS in python
999 - @threads = @ts.threads.select { |t| !@hidden_threads[t] }.sort_by { |t| [t.date, t.first.id] }.reverse
1000 + @threads = @ts.threads.select { |t| !@hidden_threads[t] && t.first }.sort_by { |t| [t.date, t.first.id] }.reverse
1001 @size_widgets = @threads.map { |t| size_widget_for_thread t }
1002 @size_widget_width = @size_widgets.max_of { |w| w.display_length }
1003 @date_widgets = @threads.map { |t| date_widget_for_thread t }
1004
1005 From ezyang@MIT.EDU Tue Mar 9 23:52:45 2010
1006 From: ezyang@MIT.EDU (Edward Z. Yang)
1007 Date: Tue, 09 Mar 2010 23:52:45 -0500
1008 Subject: [sup-devel] Mysterious nil errors
1009 In-Reply-To: <1268196562-sup-1692@ezyang>
1010 References: <1268196562-sup-1692@ezyang>
1011 Message-ID: <1268196678-sup-9427@ezyang>
1012
1013 Actually, I know precisely where this is from:
1014
1015 Content-Type:
1016 Content-Disposition: inline
1017 Content-Transfer-Encoding: base64
1018 RT-Attachment: 1176783/16113169/7868621
1019
1020 Which translates into an empty string and thus the following
1021 trace:
1022
1023 --- NoMethodError from thread: poll after loading inbox
1024 undefined method `downcase' for nil:NilClass
1025 /usr/lib/ruby/gems/1.8/gems/rmail-1.0.0/lib/rmail/header.rb:537:in `content_type'
1026 /home/ezyang/Dev/sup/lib/sup/message.rb:439:in `message_to_chunks'
1027 /home/ezyang/Dev/sup/lib/sup/message.rb:439:in `map'
1028 /home/ezyang/Dev/sup/lib/sup/message.rb:439:in `message_to_chunks'
1029 /home/ezyang/Dev/sup/lib/sup/message.rb:244:in `load_from_source!'
1030 /home/ezyang/Dev/sup/lib/sup/message.rb:340:in `build_from_source'
1031 /home/ezyang/Dev/sup/lib/sup/poll.rb:163:in `each_message_from'
1032 /home/ezyang/Dev/sup/lib/sup/maildir.rb:160:in `each'
1033 [snip]
1034
1035 I suppose this is something that should be fixed on the rmail side...
1036
1037 Cheers,
1038 Edward
1039
1040 From tero@tilus.net Wed Mar 10 01:43:12 2010
1041 From: tero@tilus.net (Tero Tilus)
1042 Date: Wed, 10 Mar 2010 08:43:12 +0200
1043 Subject: [sup-devel] Mysterious nil errors
1044 In-Reply-To: <1268196678-sup-9427@ezyang>
1045 References: <1268196562-sup-1692@ezyang> <1268196678-sup-9427@ezyang>
1046 Message-ID: <1268202637-sup-4495@tilus.net>
1047
1048 Edward Z. Yang, 2010-03-10 06:52:
1049 > I suppose this is something that should be fixed on the rmail
1050 > side...
1051
1052 And this is definitely not the only one. Unfortunately RubyMail
1053 <http://rubyforge.org/projects/rubymail/> is pretty much dead.
1054
1055 It looks like the state of art ruby mail library is currently Mail
1056 <http://github.com/mikel/mail>. I don't know how well it would serve
1057 sup, but rmail definitely has a long list of issues (already worked
1058 around in sup) and switching mail library would be a lot of work.
1059
1060 Thoughts?
1061
1062 --
1063 Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/
1064
1065 From sup-bugs@masanjin.net Wed Mar 10 09:52:46 2010
1066 From: sup-bugs@masanjin.net (anonymous)
1067 Date: Wed, 10 Mar 2010 14:52:46 +0000
1068 Subject: [sup-devel] [issue76] undefined method `new_field' for
1069 Ncurses::Form:Module
1070 In-Reply-To: <1268232766.13.0.536202344862.issue76@masanjin.net>
1071 Message-ID: <1268232766.13.0.536202344862.issue76@masanjin.net>
1072
1073
1074 New submission from anonymous:
1075
1076 Hi have no clue whether ruby and/or sup is installed correctly at all -- I am
1077 not familiar with ruby and gem and stuff.
1078
1079 What I did is:
1080
1081 - I am on SuSE 11.1
1082 - I have no admin rights here, thus I did the following to install sup from gem:
1083
1084 gem ins -r rake --install-dir /home/epple/.gem/ruby/1.8
1085 gem ins -r sup --install-dir /home/epple/.gem/ruby/1.8
1086 gem ins -r ncursesw --install-dir /home/epple/.gem/ruby/1.8
1087
1088 Then, I can invoke and run sup. (Looks promising.) When I then press "l" to add
1089 labels to a message, sup quits and prints the following:
1090
1091 [Mi M?r 10 15:47:39 +0100 2010] ERROR: oh crap, an exception
1092 ----------------------------------------------------------------
1093 I'm very sorry. It seems that an error occurred in Sup. Please
1094 accept my sincere apologies. Please submit the contents of
1095 /home/epple/.sup/exception-log.txt and a brief report of the
1096 circumstances to http://masanjin.net/sup-bugs/ so that I might
1097 address this problem. Thank you!
1098
1099 Sincerely,
1100 William
1101 ----------------------------------------------------------------
1102 --- NoMethodError from thread: main
1103 undefined method `new_field' for Ncurses::Form:Module
1104 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/textfield.rb:36:in `activate'
1105 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:575:in `ask'
1106 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:31:in `synchronize'
1107 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:31:in `sync'
1108 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:574:in `ask'
1109 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:463:in
1110 `ask_many_with_completions'
1111 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:532:in `ask_for_labels'
1112 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/util.rb:570:in `send'
1113 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/util.rb:570:in `method_missing'
1114 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/modes/thread-index-mode.rb:545:in `edit_labels'
1115 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/mode.rb:59:in `send'
1116 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/mode.rb:59:in `handle_input'
1117 /home/epple/.gem/ruby/1.8/gems/sup-0.11/lib/sup/buffer.rb:279:in `handle_input'
1118 /home/epple/.gem/ruby/1.8/gems/sup-0.11/bin/sup:279
1119 /home/epple/.gem/ruby/1.8/bin/sup:19:in `load'
1120 /home/epple/.gem/ruby/1.8/bin/sup:19
1121
1122 ----------
1123 messages: 190
1124 nosy: anonymous
1125 priority: bug
1126 ruby_version: ruby 1.8.7 (2008-08-11 patchlevel 72) [x86_64-linux]
1127 status: unread
1128 sup_version: 0.11
1129 title: undefined method `new_field' for Ncurses::Form:Module
1130
1131 _________________________________________
1132 Sup issue tracker <sup-bugs at masanjin.net>
1133 <http://masanjin.net/sup-bugs/issue76>
1134 _________________________________________
1135
1136 From rlane@club.cc.cmu.edu Wed Mar 10 12:24:12 2010
1137 From: rlane@club.cc.cmu.edu (Rich Lane)
1138 Date: Wed, 10 Mar 2010 12:24:12 -0500
1139 Subject: [sup-devel] Mysterious nil errors
1140 In-Reply-To: <1268196562-sup-1692@ezyang>
1141 References: <1268196562-sup-1692@ezyang>
1142 Message-ID: <1268241639-sup-9685@zyrg.net>
1143
1144 Excerpts from Edward Z. Yang's message of 2010-03-09 23:50:23 -0500:
1145 > - content_type = (m.header.content_type || "application/unknown").downcase # sometimes RubyMail gives us nil
1146 > + content_type = (m.header["content_type"] && m.header.content_type || "application/unknown").downcase # sometimes RubyMail gives us nil
1147
1148 Could you explain why these changes help? What's the return value of the
1149 [] call versus the method call?
1150
1151 From ezyang@MIT.EDU Wed Mar 10 12:40:19 2010
1152 From: ezyang@MIT.EDU (Edward Z. Yang)
1153 Date: Wed, 10 Mar 2010 12:40:19 -0500
1154 Subject: [sup-devel] Mysterious nil errors
1155 In-Reply-To: <1268241639-sup-9685@zyrg.net>
1156 References: <1268196562-sup-1692@ezyang> <1268241639-sup-9685@zyrg.net>
1157 Message-ID: <1268242549-sup-1852@ezyang>
1158
1159 Excerpts from Rich Lane's message of Wed Mar 10 12:24:12 -0500 2010:
1160 > Excerpts from Edward Z. Yang's message of 2010-03-09 23:50:23 -0500:
1161 > > - content_type = (m.header.content_type || "application/unknown").downcase # sometimes RubyMail gives us nil
1162 > > + content_type = (m.header["content_type"] && m.header.content_type || "application/unknown").downcase # sometimes RubyMail gives us nil
1163 >
1164 > Could you explain why these changes help? What's the return value of the
1165 > [] call versus the method call?
1166
1167 Sure! We turn our heads to exhibit 1: The rmail code that implements m.header.content_type
1168
1169 def content_type(default = nil)
1170 if value = self['content-type']
1171 value.strip.split(/\s*;\s*/)[0].downcase
1172 else
1173 if block_given?
1174 yield
1175 else
1176 default
1177 end
1178 end
1179 end
1180
1181 This code takes "text/plain; charset=utf-8" and ensures that only "text/plain"
1182 is returned. But what if self['content-type'] is empty? Then we call split
1183 on an empty string...
1184
1185 irb(main):001:0> "".strip.split(/\s*;\s*/)
1186 => []
1187
1188 Oops; the zero indexing fails.
1189
1190 Actually, the patch is buggy; I should be testing for content-type instead. :-)
1191
1192 Cheers,
1193 Edward
1194
1195 From rlane@club.cc.cmu.edu Wed Mar 10 12:59:48 2010
1196 From: rlane@club.cc.cmu.edu (Rich Lane)
1197 Date: Wed, 10 Mar 2010 12:59:48 -0500
1198 Subject: [sup-devel] Mysterious nil errors
1199 In-Reply-To: <1268242549-sup-1852@ezyang>
1200 References: <1268196562-sup-1692@ezyang> <1268241639-sup-9685@zyrg.net>
1201 <1268242549-sup-1852@ezyang>
1202 Message-ID: <1268243539-sup-5753@zyrg.net>
1203
1204 If header['content-type'] == "" then it counts as true in ruby. Maybe
1205 you wanted to check empty? instead? This is an rmail bug, so I think
1206 instead of adding workarounds to our code we should monkeypatch rmail to
1207 fix it.
1208
1209 From ezyang@MIT.EDU Wed Mar 10 13:06:19 2010
1210 From: ezyang@MIT.EDU (Edward Z. Yang)
1211 Date: Wed, 10 Mar 2010 13:06:19 -0500
1212 Subject: [sup-devel] Mysterious nil errors
1213 In-Reply-To: <1268243539-sup-5753@zyrg.net>
1214 References: <1268196562-sup-1692@ezyang> <1268241639-sup-9685@zyrg.net>
1215 <1268242549-sup-1852@ezyang> <1268243539-sup-5753@zyrg.net>
1216 Message-ID: <1268244332-sup-8923@ezyang>
1217
1218 Excerpts from Rich Lane's message of Wed Mar 10 12:59:48 -0500 2010:
1219 > If header['content-type'] == "" then it counts as true in ruby. Maybe
1220 > you wanted to check empty? instead? This is an rmail bug, so I think
1221 > instead of adding workarounds to our code we should monkeypatch rmail to
1222 > fix it.
1223
1224 Heh, my ruby-fu isn't quite there yet; I just hacked around until I made all of
1225 the errors go away. :-) Monkeypatching the rmail code would not be a bad
1226 proposition.
1227
1228 Cheers,
1229 Edward
1230
1231 From michael+sup@stapelberg.de Wed Mar 10 16:23:26 2010
1232 From: michael+sup@stapelberg.de (Michael Stapelberg)
1233 Date: Wed, 10 Mar 2010 22:23:26 +0100
1234 Subject: [sup-devel] [PATCH] Implement inline GPG (updated)
1235 In-Reply-To: <1268152912-sup-4673@midna.zekjur.net>
1236 References: <1266493070-sup-7733@midna.zekjur.net>
1237 <1267219197-sup-2428@zyrg.net>
1238 <1267276103-sup-6406@midna.zekjur.net>
1239 <1267293663-sup-2241@zyrg.net>
1240 <1267450467-sup-4411@midna.zekjur.net>
1241 <1267454104-sup-9569@peer.zerties.org>
1242 <1267462001-sup-1957@midna.zekjur.net>
1243 <1267465546-sup-2321@peer.zerties.org>
1244 <1268152912-sup-4673@midna.zekjur.net>
1245 Message-ID: <1268256145-sup-8174@midna.zekjur.net>
1246
1247 Hi,
1248
1249 Excerpts from Michael Stapelberg's message of Di M?r 09 17:43:03 +0100 2010:
1250 > Alright, tested it and reworked my patch. The latest version is attached.
1251 Updated it once again after testing with a user on sup-talk. See attachment
1252 and please merge it now :).
1253
1254 Best regards,
1255 Michael
1256 -------------- next part --------------
1257 A non-text attachment was scrubbed...
1258 Name: 0001-Implement-inline-GPG.patch
1259 Type: application/octet-stream
1260 Size: 7925 bytes
1261 Desc: not available
1262 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100310/ba9a09f8/attachment.obj>
1263
1264 From rlane@club.cc.cmu.edu Thu Mar 11 23:20:52 2010
1265 From: rlane@club.cc.cmu.edu (Rich Lane)
1266 Date: Thu, 11 Mar 2010 23:20:52 -0500
1267 Subject: [sup-devel] [PATCH] Use multiple body arrays when calling
1268 before-edit for each reply type
1269 In-Reply-To: <1268175393-sup-8314@midna.zekjur.net>
1270 References: <1264026370-sup-8092@midna.zekjur.net>
1271 <1267295207-sup-7090@zyrg.net>
1272 <1268175393-sup-8314@midna.zekjur.net>
1273 Message-ID: <1268366964-sup-2310@zyrg.net>
1274
1275 lib/sup/modes/reply-mode.rb:
1276 > + @bodies[k] = Array.new(body)
1277
1278 Why is the body in an array?
1279
1280 lib/sup/modes/reply-mode.rb:
1281 > + if !@edited
1282 > + self.body = @bodies[@type_selector.val]
1283 > + end
1284
1285 The idiomatic way to write this is:
1286 self.body = @bodies[@type_selector.val] unless @edited
1287
1288 The EditMessageMode constructor also calls the before-edit hook, but I
1289 guess if it wasn't broken before it won't be now.
1290
1291 lib/sup/modes/reply-mode.rb:
1292 > + if new_body != @bodies[@type_selector.val]
1293 > + @bodies[@type_selector.val] = new_body
1294 > + @edited = true
1295 > + end
1296
1297 Is there a reason we can't do this unconditionally?
1298
1299 From rlane@club.cc.cmu.edu Thu Mar 11 23:43:38 2010
1300 From: rlane@club.cc.cmu.edu (Rich Lane)
1301 Date: Thu, 11 Mar 2010 23:43:38 -0500
1302 Subject: [sup-devel] [PATCH] Implement inline GPG (updated)
1303 In-Reply-To: <1268256145-sup-8174@midna.zekjur.net>
1304 References: <1266493070-sup-7733@midna.zekjur.net>
1305 <1267219197-sup-2428@zyrg.net>
1306 <1267276103-sup-6406@midna.zekjur.net>
1307 <1267293663-sup-2241@zyrg.net>
1308 <1267450467-sup-4411@midna.zekjur.net>
1309 <1267454104-sup-9569@peer.zerties.org>
1310 <1267462001-sup-1957@midna.zekjur.net>
1311 <1267465546-sup-2321@peer.zerties.org>
1312 <1268152912-sup-4673@midna.zekjur.net>
1313 <1268256145-sup-8174@midna.zekjur.net>
1314 Message-ID: <1268368142-sup-4547@zyrg.net>
1315
1316 lib/sup/message.rb:
1317
1318 Since the regexes only match whole lines, why not just do string
1319 comparisons? I'd also like those strings to be constants but I won't
1320 insist on that.
1321
1322 The body assignment should be a ternary.
1323
1324 I really dislike the flip-flop operator but it looks like the best way
1325 to do this. Please package those selects into a commented Enumerable
1326 method.
1327
1328 Please factor your two cases in message_to_chunks into very well
1329 documented methods. message_to_chunks is already too complicated.
1330
1331 From rlane@club.cc.cmu.edu Thu Mar 11 23:45:06 2010
1332 From: rlane@club.cc.cmu.edu (Rich Lane)
1333 Date: Thu, 11 Mar 2010 23:45:06 -0500
1334 Subject: [sup-devel] [PATCH] Correctly pad date strings,
1335 as they might contain utf-8 characters
1336 In-Reply-To: <1268154208-sup-7661@midna.zekjur.net>
1337 References: <1268154208-sup-7661@midna.zekjur.net>
1338 Message-ID: <1268369074-sup-8727@zyrg.net>
1339
1340 Excerpts from Michael Stapelberg's message of 2010-03-09 12:04:27 -0500:
1341 > Hi,
1342 >
1343 > attached you find a patch for this problem. Quote of the commit message:
1344 >
1345 > sprintf is not utf8-aware and thus the output gets a wrong padding
1346 > (correct in terms of bytes, not correct in terms of visible characters).
1347 > You can notice this using a german locale (de_DE) and viewing mails
1348 > from march (abbreviated "M?r" in german).
1349 >
1350 > Best regards,
1351 > Michael
1352
1353 Thanks, applied directly to master.
1354
1355 From sup-bugs@masanjin.net Fri Mar 12 02:28:09 2010
1356 From: sup-bugs@masanjin.net (anonymous)
1357 Date: Fri, 12 Mar 2010 07:28:09 +0000
1358 Subject: [sup-devel] [issue77] random crash
1359 In-Reply-To: <1268378889.12.0.558023869524.issue77@masanjin.net>
1360 Message-ID: <1268378889.12.0.558023869524.issue77@masanjin.net>
1361
1362
1363 New submission from anonymous:
1364
1365 I had just filled in the To address using my external lbdb hook which has always
1366 worked before and sup crashed:
1367
1368 --- NoMethodError from thread: main
1369 undefined method `has_label?' for nil:NilClass
1370 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/modes/thread-index-
1371 mode.rb:237:in `edit_message'
1372 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/hook.rb:55:in `find'
1373 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:81:in `each'
1374 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:170:in
1375 `each_with_stuff'
1376 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:170:in
1377 `each_with_stuff'
1378 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:168:in
1379 `each_with_stuff'
1380 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:170:in
1381 `each_with_stuff'
1382 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in `each'
1383 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in
1384 `each_with_stuff'
1385 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:170:in
1386 `each_with_stuff'
1387 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in `each'
1388 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in
1389 `each_with_stuff'
1390 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:170:in
1391 `each_with_stuff'
1392 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in `each'
1393 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in
1394 `each_with_stuff'
1395 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:170:in
1396 `each_with_stuff'
1397 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in `each'
1398 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:169:in
1399 `each_with_stuff'
1400 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:78:in `each'
1401 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/thread.rb:75:in `each'
1402 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/modes/thread-index-
1403 mode.rb:237:in `find'
1404 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/modes/thread-index-
1405 mode.rb:237:in `edit_message'
1406 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/mode.rb:51:in `send'
1407 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/mode.rb:51:in
1408 `handle_input'
1409 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/lib/sup/buffer.rb:270:in
1410 `handle_input'
1411 /opt/local/lib/ruby/gems/1.8/gems/sup-0.10.2/bin/sup:270
1412 /opt/local/bin/sup:19:in `load'
1413 /opt/local/bin/sup:19
1414 Reminder: to update your Ferret index to Xapian, run sup-convert-ferret-index.
1415
1416 ----------
1417 messages: 194
1418 nosy: anonymous
1419 priority: bug
1420 ruby_version: 1.8.7
1421 status: unread
1422 sup_version: 10.2
1423 title: random crash
1424
1425 _________________________________________
1426 Sup issue tracker <sup-bugs at masanjin.net>
1427 <http://masanjin.net/sup-bugs/issue77>
1428 _________________________________________
1429
1430 From michael+sup@stapelberg.de Fri Mar 12 05:17:44 2010
1431 From: michael+sup@stapelberg.de (Michael Stapelberg)
1432 Date: Fri, 12 Mar 2010 11:17:44 +0100
1433 Subject: [sup-devel] [PATCH] Use multiple body arrays when calling
1434 before-edit for each reply type
1435 In-Reply-To: <1268366964-sup-2310@zyrg.net>
1436 References: <1264026370-sup-8092@midna.zekjur.net>
1437 <1267295207-sup-7090@zyrg.net>
1438 <1268175393-sup-8314@midna.zekjur.net>
1439 <1268366964-sup-2310@zyrg.net>
1440 Message-ID: <1268388251-sup-2106@midna.zekjur.net>
1441
1442 Hi Rich,
1443
1444 Excerpts from Rich Lane's message of Fr M?r 12 05:20:52 +0100 2010:
1445 > lib/sup/modes/reply-mode.rb:
1446 > > + @bodies[k] = Array.new(body)
1447 >
1448 > Why is the body in an array?
1449 That was left over while refactoring. It isn?t necessary.
1450
1451 > The idiomatic way to write this is:
1452 > self.body = @bodies[@type_selector.val] unless @edited
1453 Alright, changed.
1454
1455 > lib/sup/modes/reply-mode.rb:
1456 > > + if new_body != @bodies[@type_selector.val]
1457 > > + @bodies[@type_selector.val] = new_body
1458 > > + @edited = true
1459 > > + end
1460 >
1461 > Is there a reason we can't do this unconditionally?
1462 Yes, I wanted to avoid setting the @edited flag if the user exited the editor
1463 without making any changes. That way, he can benefit from the changing bodies
1464 for a longer time.
1465
1466 Updated patch attached.
1467
1468 Best regards,
1469 Michael
1470 -------------- next part --------------
1471 A non-text attachment was scrubbed...
1472 Name: 0001-Use-multiple-body-arrays-when-calling-before-edit-fo.patch
1473 Type: application/octet-stream
1474 Size: 2426 bytes
1475 Desc: not available
1476 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100312/454445e0/attachment-0001.obj>
1477
1478 From michael+sup@stapelberg.de Fri Mar 12 06:02:00 2010
1479 From: michael+sup@stapelberg.de (Michael Stapelberg)
1480 Date: Fri, 12 Mar 2010 12:02:00 +0100
1481 Subject: [sup-devel] [PATCH] Implement inline GPG (updated)
1482 In-Reply-To: <1268368142-sup-4547@zyrg.net>
1483 References: <1266493070-sup-7733@midna.zekjur.net>
1484 <1267219197-sup-2428@zyrg.net>
1485 <1267276103-sup-6406@midna.zekjur.net>
1486 <1267293663-sup-2241@zyrg.net>
1487 <1267450467-sup-4411@midna.zekjur.net>
1488 <1267454104-sup-9569@peer.zerties.org>
1489 <1267462001-sup-1957@midna.zekjur.net>
1490 <1267465546-sup-2321@peer.zerties.org>
1491 <1268152912-sup-4673@midna.zekjur.net>
1492 <1268256145-sup-8174@midna.zekjur.net>
1493 <1268368142-sup-4547@zyrg.net>
1494 Message-ID: <1268390058-sup-9413@midna.zekjur.net>
1495
1496 Hi Rich,
1497
1498 Excerpts from Rich Lane's message of Fr M?r 12 05:43:38 +0100 2010:
1499 > Since the regexes only match whole lines, why not just do string
1500 > comparisons? I'd also like those strings to be constants but I won't
1501 > insist on that.
1502 Good point, I changed that.
1503
1504 > The body assignment should be a ternary.
1505 I avoided that because the line gets incredibly long then (91 characters
1506 vs. 79 characters inside the if. Are you sure you want that ternary?
1507 If so, please just change it yourself.
1508
1509 > I really dislike the flip-flop operator but it looks like the best way
1510 > to do this. Please package those selects into a commented Enumerable
1511 > method.
1512 Done.
1513
1514 > Please factor your two cases in message_to_chunks into very well
1515 > documented methods. message_to_chunks is already too complicated.
1516 Done.
1517
1518 Best regards,
1519 Michael
1520 -------------- next part --------------
1521 A non-text attachment was scrubbed...
1522 Name: 0001-Implement-inline-GPG.patch
1523 Type: application/octet-stream
1524 Size: 8476 bytes
1525 Desc: not available
1526 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100312/0624816a/attachment.obj>
1527
1528 From bwalton@artsci.utoronto.ca Fri Mar 12 10:22:22 2010
1529 From: bwalton@artsci.utoronto.ca (Ben Walton)
1530 Date: Fri, 12 Mar 2010 10:22:22 -0500
1531 Subject: [sup-devel] Writing changes back to sources
1532 In-Reply-To: <6c0c31751003072145r13f3bdd0m37f47c71995af06e@mail.gmail.com>
1533 References: <6c0c31751003072145r13f3bdd0m37f47c71995af06e@mail.gmail.com>
1534 Message-ID: <1268407222-sup-8959@pinkfloyd.chass.utoronto.ca>
1535
1536 Excerpts from Scott Henson's message of Mon Mar 08 00:45:54 -0500 2010:
1537
1538 > To do the above I think we probably need standardize how messages
1539 > are added and removed from sources. The maildir source has
1540 > store_message and delete. I would suppose that we would need to
1541 > implement something similar for the other sources (is mbox the only
1542 > other one left?). Does this seem to be a good idea or do we want to
1543 > continue having different ways of writing back to sources?
1544
1545 This is overall a good idea, I think. I haven't looked at this in
1546 some time, so my memory may be off or the code changed in the interim,
1547 but if you did something like this, you could like do away with
1548 SentManager completely. Without the addition support of the mbox
1549 store_message method, it would be a skeleton for default_set_source
1550 (or whatever that method is)...at which point that functionality could
1551 be handled differently.
1552
1553 Just a few (hopefully valid and useful) thoughts.
1554
1555 Thanks
1556 -Ben
1557 -------------- next part --------------
1558 A non-text attachment was scrubbed...
1559 Name: signature.asc
1560 Type: application/pgp-signature
1561 Size: 189 bytes
1562 Desc: not available
1563 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100312/8f089fd7/attachment.bin>
1564
1565 From daniel.schoepe@googlemail.com Sun Mar 14 12:07:05 2010
1566 From: daniel.schoepe@googlemail.com (Daniel Schoepe)
1567 Date: Sun, 14 Mar 2010 17:07:05 +0100
1568 Subject: [sup-devel] [PATCH] Added slip_rows config option
1569 Message-ID: <1268582825-32353-1-git-send-email-daniel.schoepe@googlemail.com>
1570
1571 This patch adds a slip_rows config option used by thread-view-mode
1572 that passes the argument to scroll-mode, which already has that
1573 functionality, but it was only used by completion-mode before.
1574 The option controls how many lines of context are shown when scrolling
1575 up/down.
1576 ---
1577 lib/sup.rb | 3 ++-
1578 lib/sup/modes/thread-view-mode.rb | 2 +-
1579 2 files changed, 3 insertions(+), 2 deletions(-)
1580
1581 diff --git a/lib/sup.rb b/lib/sup.rb
1582 index 2765faa..c94c2b0 100644
1583 --- a/lib/sup.rb
1584 +++ b/lib/sup.rb
1585 @@ -264,7 +264,8 @@ else
1586 :default_attachment_save_dir => "",
1587 :sent_source => "sup://sent",
1588 :poll_interval => 300,
1589 - :wrap_width => 0
1590 + :wrap_width => 0,
1591 + :slip_rows => 0
1592 }
1593 begin
1594 FileUtils.mkdir_p Redwood::BASE_DIR
1595 diff --git a/lib/sup/modes/thread-view-mode.rb b/lib/sup/modes/thread-view-mode.rb
1596 index 63fe211..6138dc7 100644
1597 --- a/lib/sup/modes/thread-view-mode.rb
1598 +++ b/lib/sup/modes/thread-view-mode.rb
1599 @@ -111,7 +111,7 @@ EOS
1600 ## objects. @person_lines is a map from row #s to Person objects.
1601
1602 def initialize thread, hidden_labels=[], index_mode=nil
1603 - super()
1604 + super :slip_rows => $config[:slip_rows]
1605 @thread = thread
1606 @hidden_labels = hidden_labels
1607
1608 --
1609 1.7.0
1610
1611
1612 From sup-bugs@masanjin.net Sun Mar 14 20:07:36 2010
1613 From: sup-bugs@masanjin.net (Brian May)
1614 Date: Mon, 15 Mar 2010 00:07:36 +0000
1615 Subject: [sup-devel] [issue78] crashes while scrolling through results
1616 In-Reply-To: <1268611656.8.0.931978432206.issue78@masanjin.net>
1617 Message-ID: <1268611656.8.0.931978432206.issue78@masanjin.net>
1618
1619
1620 New submission from Brian May <brian at microcomaustralia.com.au>:
1621
1622 Happens when scrolling through search results, on an up to date Debian/sid
1623 system.
1624
1625 Same problem also happened on Ubuntu/Karmic.
1626
1627 [Sun Mar 14 23:59:39 +0000 2010] ERROR: oh crap, an exception
1628 ----------------------------------------------------------------
1629 I'm very sorry. It seems that an error occurred in Sup. Please
1630 accept my sincere apologies. Please submit the contents of
1631 /home/brian/.sup/exception-log.txt and a brief report of the
1632 circumstances to http://masanjin.net/sup-bugs/ so that I might
1633 address this problem. Thank you!
1634
1635 Sincerely,
1636 William
1637 ----------------------------------------------------------------
1638 --- RuntimeError from thread: load threads for thread-index-mode
1639 wrong id called on nil
1640 /home/brian/tree/sup/lib/sup.rb:17:in `id'
1641 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:234:in `update'
1642 /home/brian/tree/sup/lib/sup/hook.rb:123:in `sort_by'
1643 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:234:in `each'
1644 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:234:in `sort_by'
1645 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:234:in `update'
1646 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:232:in `synchronize'
1647 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:232:in `update'
1648 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:652:in
1649 `__unprotected_load_n_threads'
1650 (eval):12:in `load_n_threads'
1651 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:624:in
1652 `load_n_threads_background'
1653 /home/brian/tree/sup/lib/sup.rb:76:in `reporting_thread'
1654 /home/brian/tree/sup/lib/sup.rb:74:in `initialize'
1655 /home/brian/tree/sup/lib/sup.rb:74:in `new'
1656 /home/brian/tree/sup/lib/sup.rb:74:in `reporting_thread'
1657 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:623:in
1658 `load_n_threads_background'
1659 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:694:in
1660 `__unprotected_load_threads'
1661 (eval):12:in `load_threads'
1662 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:89
1663 /home/brian/tree/sup/lib/sup/modes/line-cursor-mode.rb:22:in `call'
1664 /home/brian/tree/sup/lib/sup/modes/line-cursor-mode.rb:22:in `initialize'
1665 /home/brian/tree/sup/lib/sup/modes/line-cursor-mode.rb:22:in `each'
1666 /home/brian/tree/sup/lib/sup/modes/line-cursor-mode.rb:22:in `initialize'
1667 /home/brian/tree/sup/lib/sup/modes/line-cursor-mode.rb:19:in `new'
1668 /home/brian/tree/sup/lib/sup/modes/line-cursor-mode.rb:19:in `initialize'
1669 /home/brian/tree/sup/lib/sup/modes/thread-index-mode.rb:60:in `initialize'
1670 /home/brian/tree/sup/lib/sup/modes/search-results-mode.rb:6:in `initialize'
1671 /home/brian/tree/sup/lib/sup/modes/search-results-mode.rb:46:in `new'
1672 /home/brian/tree/sup/lib/sup/modes/search-results-mode.rb:46:in
1673 `spawn_from_query'
1674 /home/brian/tree/sup/bin/sup:314
1675
1676 ----------
1677 messages: 195
1678 nosy: brian
1679 priority: bug
1680 ruby_version: 1.8
1681 status: unread
1682 sup_version: b4f256a6d030d8d07cc61561ed1c8ba27287c250
1683 title: crashes while scrolling through results
1684
1685 _________________________________________
1686 Sup issue tracker <sup-bugs at masanjin.net>
1687 <http://masanjin.net/sup-bugs/issue78>
1688 _________________________________________
1689
1690 From sup-bugs@masanjin.net Sun Mar 14 23:27:46 2010
1691 From: sup-bugs@masanjin.net (Brian May)
1692 Date: Mon, 15 Mar 2010 03:27:46 +0000
1693 Subject: [sup-devel] [issue79] crashes when sending email
1694 In-Reply-To: <1268623666.55.0.473063715174.issue79@masanjin.net>
1695 Message-ID: <1268623666.55.0.473063715174.issue79@masanjin.net>
1696
1697
1698 New submission from Brian May <brian at microcomaustralia.com.au>:
1699
1700 [Mon Mar 15 14:22:55 +1100 2010] No 'ncursesw' gem detected. Install it for wide
1701 character support.
1702 [Mon Mar 15 14:23:38 +1100 2010] ERROR: oh crap, an exception
1703 ----------------------------------------------------------------
1704 I'm very sorry. It seems that an error occurred in Sup. Please
1705 accept my sincere apologies. Please submit the contents of
1706 /home/brian/.sup/exception-log.txt and a brief report of the
1707 circumstances to http://masanjin.net/sup-bugs/ so that I might
1708 address this problem. Thank you!
1709
1710 Sincerely,
1711 William
1712 ----------------------------------------------------------------
1713 --- TypeError from thread: main
1714 can't convert nil into String
1715 /home/brian/tree/sup/lib/sup/mbox/loader.rb:117:in `exists?'
1716 /home/brian/tree/sup/lib/sup/mbox/loader.rb:117:in `store_message'
1717 /home/brian/tree/sup/lib/sup/util.rb:610:in `send'
1718 /home/brian/tree/sup/lib/sup/util.rb:610:in `__pass'
1719 /home/brian/tree/sup/lib/sup/util.rb:597:in `method_missing'
1720 /home/brian/tree/sup/lib/sup/sent.rb:28:in `write_sent_message'
1721 /home/brian/tree/sup/lib/sup/util.rb:570:in `send'
1722 /home/brian/tree/sup/lib/sup/util.rb:570:in `method_missing'
1723 /home/brian/tree/sup/lib/sup/modes/edit-message-mode.rb:346:in `send_message'
1724 /home/brian/tree/sup/lib/sup/mode.rb:59:in `send'
1725 /home/brian/tree/sup/lib/sup/mode.rb:59:in `handle_input'
1726 /home/brian/tree/sup/lib/sup/buffer.rb:279:in `handle_input'
1727 /home/brian/tree/sup/bin/sup:279
1728
1729 ----------
1730 messages: 196
1731 nosy: brian
1732 priority: bug
1733 ruby_version: 1.8
1734 status: unread
1735 sup_version: b4f256a6d030d8d07cc61561ed1c8ba27287c250
1736 title: crashes when sending email
1737
1738 _________________________________________
1739 Sup issue tracker <sup-bugs at masanjin.net>
1740 <http://masanjin.net/sup-bugs/issue79>
1741 _________________________________________
1742
1743 From rlane@club.cc.cmu.edu Mon Mar 15 01:09:23 2010
1744 From: rlane@club.cc.cmu.edu (Rich Lane)
1745 Date: Mon, 15 Mar 2010 01:09:23 -0400
1746 Subject: [sup-devel] [PATCH] Use multiple body arrays when calling
1747 before-edit for each reply type
1748 In-Reply-To: <1268388251-sup-2106@midna.zekjur.net>
1749 References: <1264026370-sup-8092@midna.zekjur.net>
1750 <1267295207-sup-7090@zyrg.net>
1751 <1268175393-sup-8314@midna.zekjur.net>
1752 <1268366964-sup-2310@zyrg.net>
1753 <1268388251-sup-2106@midna.zekjur.net>
1754 Message-ID: <1268629722-sup-6122@zyrg.net>
1755
1756 Applied to master.
1757
1758 From rlane@club.cc.cmu.edu Mon Mar 15 01:12:52 2010
1759 From: rlane@club.cc.cmu.edu (Rich Lane)
1760 Date: Mon, 15 Mar 2010 01:12:52 -0400
1761 Subject: [sup-devel] [PATCH] Added slip_rows config option
1762 In-Reply-To: <1268582825-32353-1-git-send-email-daniel.schoepe@googlemail.com>
1763 References: <1268582825-32353-1-git-send-email-daniel.schoepe@googlemail.com>
1764 Message-ID: <1268629958-sup-6763@zyrg.net>
1765
1766 Applied to master.
1767
1768 From rlane@club.cc.cmu.edu Mon Mar 15 01:19:59 2010
1769 From: rlane@club.cc.cmu.edu (Rich Lane)
1770 Date: Mon, 15 Mar 2010 01:19:59 -0400
1771 Subject: [sup-devel] [PATCH] Implement inline GPG (updated)
1772 In-Reply-To: <1268390058-sup-9413@midna.zekjur.net>
1773 References: <1266493070-sup-7733@midna.zekjur.net>
1774 <1267219197-sup-2428@zyrg.net>
1775 <1267276103-sup-6406@midna.zekjur.net>
1776 <1267293663-sup-2241@zyrg.net>
1777 <1267450467-sup-4411@midna.zekjur.net>
1778 <1267454104-sup-9569@peer.zerties.org>
1779 <1267462001-sup-1957@midna.zekjur.net>
1780 <1267465546-sup-2321@peer.zerties.org>
1781 <1268152912-sup-4673@midna.zekjur.net>
1782 <1268256145-sup-8174@midna.zekjur.net>
1783 <1268368142-sup-4547@zyrg.net>
1784 <1268390058-sup-9413@midna.zekjur.net>
1785 Message-ID: <1268630380-sup-8431@zyrg.net>
1786
1787 Branch inline-gpg, merged to next.
1788
1789 From sup-bugs@masanjin.net Wed Mar 17 15:19:57 2010
1790 From: sup-bugs@masanjin.net (Derek Hval)
1791 Date: Wed, 17 Mar 2010 19:19:57 +0000
1792 Subject: [sup-devel] [issue80] test
1793 In-Reply-To: <1268853597.35.0.801379860174.issue80@masanjin.net>
1794 Message-ID: <1268853597.35.0.801379860174.issue80@masanjin.net>
1795
1796
1797 New submission from Derek Hval <derekhval at yahoo.com>:
1798
1799 test
1800
1801 ----------
1802 messages: 197
1803 nosy: der74hva3
1804 priority: feature request
1805 ruby_version: 1
1806 status: resolved
1807 sup_version: 1
1808 title: test
1809
1810 _________________________________________
1811 Sup issue tracker <sup-bugs at masanjin.net>
1812 <http://masanjin.net/sup-bugs/issue80>
1813 _________________________________________
1814
1815 From sup-bugs@masanjin.net Thu Mar 18 18:20:36 2010
1816 From: sup-bugs@masanjin.net (anonymous)
1817 Date: Thu, 18 Mar 2010 22:20:36 +0000
1818 Subject: [sup-devel] [issue81] View all headers in thread view mode on/off
1819 In-Reply-To: <1268950835.93.0.894979057024.issue81@masanjin.net>
1820 Message-ID: <1268950835.93.0.894979057024.issue81@masanjin.net>
1821
1822
1823 New submission from anonymous:
1824
1825 A config option that when enabled shows the detailed headers (what you get when
1826 you press h in threadview) for all messages when you enter threadview mode, or
1827 if this is impossible, a key that would toggle the detailed headers for all
1828 messages in a thread, not just the message you're on.
1829
1830 ----------
1831 messages: 198
1832 nosy: anonymous
1833 priority: feature request
1834 ruby_version: 1.8.7.249-1 (debian)
1835 status: unread
1836 sup_version: 0.10.2-1 (debian)
1837 title: View all headers in thread view mode on/off
1838
1839 _________________________________________
1840 Sup issue tracker <sup-bugs at masanjin.net>
1841 <http://masanjin.net/sup-bugs/issue81>
1842 _________________________________________
1843
1844 From sup-bugs@masanjin.net Thu Mar 18 18:31:18 2010
1845 From: sup-bugs@masanjin.net (anonymous)
1846 Date: Thu, 18 Mar 2010 22:31:18 +0000
1847 Subject: [sup-devel] [issue82] Customizing the color of the selector/cursor
1848 In-Reply-To: <1268951478.07.0.666387744958.issue82@masanjin.net>
1849 Message-ID: <1268951478.07.0.666387744958.issue82@masanjin.net>
1850
1851
1852 New submission from anonymous:
1853
1854 The cursor/selector doesn't seem to be in colors.yaml, would be nice if we
1855 could customize the colour of the cursor.
1856
1857 ----------
1858 messages: 199
1859 nosy: anonymous
1860 priority: feature request
1861 ruby_version: 1.8.7.249-1
1862 status: unread
1863 sup_version: 0.10.2-1
1864 title: Customizing the color of the selector/cursor
1865
1866 _________________________________________
1867 Sup issue tracker <sup-bugs at masanjin.net>
1868 <http://masanjin.net/sup-bugs/issue82>
1869 _________________________________________
1870
1871 From sup-bugs@masanjin.net Fri Mar 19 05:01:00 2010
1872 From: sup-bugs@masanjin.net (anonymous)
1873 Date: Fri, 19 Mar 2010 09:01:00 +0000
1874 Subject: [sup-devel] [issue83] search for a message, not a thread
1875 In-Reply-To: <1268989260.29.0.892032759501.issue83@masanjin.net>
1876 Message-ID: <1268989260.29.0.892032759501.issue83@masanjin.net>
1877
1878
1879 New submission from anonymous:
1880
1881 When I use 'F' to search a message, sup returns a thread, and most of the time,
1882 I have to use '/' again to select the right message.
1883 I would like that, after a search, matching messages are highlighted in some
1884 way.
1885
1886 ----------
1887 messages: 200
1888 nosy: anonymous
1889 priority: feature request
1890 ruby_version: 1.8.7
1891 status: unread
1892 sup_version: 0.11
1893 title: search for a message, not a thread
1894
1895 _________________________________________
1896 Sup issue tracker <sup-bugs at masanjin.net>
1897 <http://masanjin.net/sup-bugs/issue83>
1898 _________________________________________
1899
1900 From michael+sup@stapelberg.de Fri Mar 19 11:34:26 2010
1901 From: michael+sup@stapelberg.de (Michael Stapelberg)
1902 Date: Fri, 19 Mar 2010 16:34:26 +0100
1903 Subject: [sup-devel] [PATCH 1/2] Make sup-tweak-labels work with ruby 1.9
1904 Message-ID: <1269012800-sup-3632@midna.zekjur.net>
1905
1906 Hi,
1907
1908 attached you find a patch to make sup-tweak-labels work with 1.9. Maybe the
1909 line can be written more beautifully.
1910
1911 Best regards,
1912 Michael
1913 -------------- next part --------------
1914 A non-text attachment was scrubbed...
1915 Name: 0001-Make-sup-tweak-labels-work-with-ruby-1.9.patch
1916 Type: application/octet-stream
1917 Size: 881 bytes
1918 Desc: not available
1919 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100319/2e41714d/attachment.obj>
1920
1921 From michael+sup@stapelberg.de Fri Mar 19 11:36:37 2010
1922 From: michael+sup@stapelberg.de (Michael Stapelberg)
1923 Date: Fri, 19 Mar 2010 16:36:37 +0100
1924 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
1925 generating the unique id for each message
1926 Message-ID: <1269012878-sup-691@midna.zekjur.net>
1927
1928 Hi,
1929
1930 the attached patch uses nanosecond resolution to generate the unique id for
1931 each message of a maildir. This is necessary because I have about 2000 messages
1932 which have the same mtime and size. I am not sure on how to properly check for
1933 ruby 1.9 and do the right thing. Also, the user probably needs to run sup-sync
1934 after this change. Maybe it should be implemented as a config option and be
1935 enabled by default on new configs by sup-config? Thoughts?
1936
1937 Best regards,
1938 Michael
1939 -------------- next part --------------
1940 A non-text attachment was scrubbed...
1941 Name: 0002-Use-nanosecond-resolution-of-mtime-for-generating-th.patch
1942 Type: application/octet-stream
1943 Size: 893 bytes
1944 Desc: not available
1945 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100319/bf56ea36/attachment.obj>
1946
1947 From michael+sup@stapelberg.de Fri Mar 19 14:53:04 2010
1948 From: michael+sup@stapelberg.de (Michael Stapelberg)
1949 Date: Fri, 19 Mar 2010 19:53:04 +0100
1950 Subject: [sup-devel] [PATCH] Start gpg with LC_MESSAGES=C
1951 Message-ID: <1269024593-sup-9101@midna.zekjur.net>
1952
1953 Hi,
1954
1955 attached you find a patch which ensures that LC_MESSAGES=C is set when starting
1956 gpg so that the regexps for interpreting the gpg output work.
1957
1958 Best regards,
1959 Michael
1960 -------------- next part --------------
1961 A non-text attachment was scrubbed...
1962 Name: 0001-Use-LC_MESSAGES-C-when-starting-gpg-so-that-the-rege.patch
1963 Type: application/octet-stream
1964 Size: 813 bytes
1965 Desc: not available
1966 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100319/dd22a1ab/attachment.obj>
1967
1968 From marka@pobox.com Fri Mar 19 15:17:01 2010
1969 From: marka@pobox.com (Mark Alexander)
1970 Date: Fri, 19 Mar 2010 15:17:01 -0400
1971 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
1972 generating the unique id for each message
1973 In-Reply-To: <1269012878-sup-691@midna.zekjur.net>
1974 References: <1269012878-sup-691@midna.zekjur.net>
1975 Message-ID: <1269026068-sup-6868@r61>
1976
1977 Excerpts from Michael Stapelberg's message of Fri Mar 19 11:36:37 -0400 2010:
1978 > the attached patch uses nanosecond resolution to generate the unique id for
1979 > each message of a maildir. This is necessary because I have about 2000 messages
1980 > which have the same mtime and size.
1981
1982 This a great idea, but if I understand correctly, it requires a file
1983 system that supports nanosecond resolution on timestamps, like ext4.
1984 Those of us on ext3 are out of luck, apparently:
1985
1986 https://ext4.wiki.kernel.org/index.php/Ext4_Howto#Inode-related_features
1987
1988 From michael+sup@stapelberg.de Fri Mar 19 15:27:36 2010
1989 From: michael+sup@stapelberg.de (Michael Stapelberg)
1990 Date: Fri, 19 Mar 2010 20:27:36 +0100
1991 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
1992 generating the unique id for each message
1993 In-Reply-To: <1269026068-sup-6868@r61>
1994 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
1995 Message-ID: <1269026769-sup-3830@midna.zekjur.net>
1996
1997 Hi Mark,
1998
1999 Excerpts from Mark Alexander's message of 2010-03-19 20:17:01 +0100:
2000 > This a great idea, but if I understand correctly, it requires a file
2001 > system that supports nanosecond resolution on timestamps, like ext4.
2002 > Those of us on ext3 are out of luck, apparently:
2003 > https://ext4.wiki.kernel.org/index.php/Ext4_Howto#Inode-related_features
2004 Looks like you are right. The change won?t break on ext3, though, the
2005 nanoseconds will just be zero. Time to upgrade to ext4, I?d say ;-).
2006
2007 Best regards,
2008 Michael
2009
2010 From hyperbolist@gmail.com Fri Mar 19 15:34:32 2010
2011 From: hyperbolist@gmail.com (Eric Sherman)
2012 Date: Fri, 19 Mar 2010 15:34:32 -0400
2013 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2014 generating the unique id for each message
2015 In-Reply-To: <1269026068-sup-6868@r61>
2016 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2017 Message-ID: <1269026805-sup-2720@changeling.local>
2018
2019 Excerpts from Mark Alexander's message of Fri Mar 19 15:17:01 -0400 2010:
2020 > Excerpts from Michael Stapelberg's message of Fri Mar 19 11:36:37 -0400 2010:
2021 > > the attached patch uses nanosecond resolution to generate the unique id for
2022 > > each message of a maildir. This is necessary because I have about 2000 messages
2023 > > which have the same mtime and size.
2024 >
2025 > This a great idea, but if I understand correctly, it requires a file
2026 > system that supports nanosecond resolution on timestamps, like ext4.
2027 > Those of us on ext3 are out of luck, apparently:
2028 >
2029 > https://ext4.wiki.kernel.org/index.php/Ext4_Howto#Inode-related_features
2030
2031 Would inserting an SHA1 into the id solve these problems, or does it just
2032 introduce more problems?
2033
2034 From bwalton@artsci.utoronto.ca Fri Mar 19 15:35:31 2010
2035 From: bwalton@artsci.utoronto.ca (Ben Walton)
2036 Date: Fri, 19 Mar 2010 15:35:31 -0400
2037 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2038 generating the unique id for each message
2039 In-Reply-To: <1269026769-sup-3830@midna.zekjur.net>
2040 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2041 <1269026769-sup-3830@midna.zekjur.net>
2042 Message-ID: <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2043
2044 Excerpts from Michael Stapelberg's message of Fri Mar 19 15:27:36 -0400 2010:
2045
2046 Hi Michael,
2047
2048 > Looks like you are right. The change won?t break on ext3, though, the
2049 > nanoseconds will just be zero. Time to upgrade to ext4, I?d say ;-).
2050
2051 I like the idea here, but requiring ruby 1.9 _and_ a filesystem
2052 upgrade for a _mail client_ is a bit of a stretch, don't you think?
2053 Isn't there a more portable solution?
2054
2055 Thanks
2056 -Ben
2057 --
2058 Ben Walton
2059 Systems Programmer - CHASS
2060 University of Toronto
2061 C:416.407.5610 | W:416.978.4302
2062
2063
2064 From michael+sup@stapelberg.de Fri Mar 19 15:46:29 2010
2065 From: michael+sup@stapelberg.de (Michael Stapelberg)
2066 Date: Fri, 19 Mar 2010 20:46:29 +0100
2067 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2068 generating the unique id for each message
2069 In-Reply-To: <1269026805-sup-2720@changeling.local>
2070 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2071 <1269026805-sup-2720@changeling.local>
2072 Message-ID: <1269027951-sup-4565@midna.zekjur.net>
2073
2074 Hi Eric,
2075
2076 Excerpts from Eric Sherman's message of 2010-03-19 20:34:32 +0100:
2077 > Would inserting an SHA1 into the id solve these problems, or does it just
2078 > introduce more problems?
2079 The latter. The ID needs to be linear, not only unique.
2080
2081 Best regards,
2082 Michael
2083
2084 From michael+sup@stapelberg.de Fri Mar 19 15:47:53 2010
2085 From: michael+sup@stapelberg.de (Michael Stapelberg)
2086 Date: Fri, 19 Mar 2010 20:47:53 +0100
2087 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2088 generating the unique id for each message
2089 In-Reply-To: <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2090 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2091 <1269026769-sup-3830@midna.zekjur.net>
2092 <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2093 Message-ID: <1269027991-sup-5670@midna.zekjur.net>
2094
2095 Hi Ben,
2096
2097 Excerpts from Ben Walton's message of 2010-03-19 20:35:31 +0100:
2098 > I like the idea here, but requiring ruby 1.9 _and_ a filesystem
2099 > upgrade for a _mail client_ is a bit of a stretch, don't you think?
2100 > Isn't there a more portable solution?
2101 There is: Rich mentioned that proper move/delete handling for maildirs also
2102 solves the problem. However that doesn?t seem to be planned for the very near
2103 future, so I posted my patch which fixes the problem right now (given that
2104 you use ruby 1.9 and a decent filesystem).
2105
2106 Best regards,
2107 Michael
2108
2109 From bwalton@artsci.utoronto.ca Fri Mar 19 16:05:06 2010
2110 From: bwalton@artsci.utoronto.ca (Ben Walton)
2111 Date: Fri, 19 Mar 2010 16:05:06 -0400
2112 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2113 generating the unique id for each message
2114 In-Reply-To: <1269027991-sup-5670@midna.zekjur.net>
2115 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2116 <1269026769-sup-3830@midna.zekjur.net>
2117 <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2118 <1269027991-sup-5670@midna.zekjur.net>
2119 Message-ID: <1269029060-sup-9476@pinkfloyd.chass.utoronto.ca>
2120
2121 Excerpts from Michael Stapelberg's message of Fri Mar 19 15:47:53 -0400 2010:
2122
2123 > There is: Rich mentioned that proper move/delete handling for
2124 > maildirs also solves the problem. However that doesn?t seem to be
2125 > planned for the very near future, so I posted my patch which fixes
2126 > the problem right now (given that you use ruby 1.9 and a decent
2127 > filesystem).
2128
2129 Ok. I'd rather work with you towards implementing this handling than
2130 force an upgrade on myself that would be both ruby and filesystem
2131 (incl servers and nfs).
2132
2133 Thanks
2134 -Ben
2135 --
2136 Ben Walton
2137 Systems Programmer - CHASS
2138 University of Toronto
2139 C:416.407.5610 | W:416.978.4302
2140
2141
2142 From marka@pobox.com Fri Mar 19 16:35:38 2010
2143 From: marka@pobox.com (Mark Alexander)
2144 Date: Fri, 19 Mar 2010 16:35:38 -0400
2145 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2146 generating the unique id for each message
2147 In-Reply-To: <1269027991-sup-5670@midna.zekjur.net>
2148 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2149 <1269026769-sup-3830@midna.zekjur.net>
2150 <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2151 <1269027991-sup-5670@midna.zekjur.net>
2152 Message-ID: <1269030873-sup-4844@r61>
2153
2154 Excerpts from Michael Stapelberg's message of Fri Mar 19 15:47:53 -0400 2010:
2155 > Excerpts from Ben Walton's message of 2010-03-19 20:35:31 +0100:
2156 > > Isn't there a more portable solution?
2157 > There is: Rich mentioned that proper move/delete handling for maildirs also
2158 > solves the problem.
2159
2160 I must have missed that message. What is the proposed solution?
2161 How does it solve the problem of out-of-order maildir IDs?
2162
2163 From hyperbolist@gmail.com Fri Mar 19 16:40:46 2010
2164 From: hyperbolist@gmail.com (Eric Sherman)
2165 Date: Fri, 19 Mar 2010 16:40:46 -0400
2166 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2167 generating the unique id for each message
2168 In-Reply-To: <1269027951-sup-4565@midna.zekjur.net>
2169 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2170 <1269026805-sup-2720@changeling.local>
2171 <1269027951-sup-4565@midna.zekjur.net>
2172 Message-ID: <1269029869-sup-4474@changeling.local>
2173
2174 Excerpts from Michael Stapelberg's message of Fri Mar 19 15:46:29 -0400 2010:
2175 > Excerpts from Eric Sherman's message of 2010-03-19 20:34:32 +0100:
2176 > > Would inserting an SHA1 into the id solve these problems, or does it just
2177 > > introduce more problems?
2178 > The latter. The ID needs to be linear, not only unique.
2179
2180 Oh I see.
2181
2182 Is it fair to say that if a set of messages are can only be disambiguated
2183 by adding nanosecond precision to their timestamps, the ordering across
2184 such a set may as well be arbitrary?
2185
2186 In looking at make_id, it seems like we should be able to simply append
2187 more numeric noise at the end of the id. The file size is already appended
2188 to the mtime, potentially making the ordering arbitrary for equivalent
2189 mtimes.
2190
2191 Would appending x-digits of numeric noise, probably derived from SHA1, be
2192 suitable?
2193
2194 From rlane@club.cc.cmu.edu Fri Mar 19 17:02:44 2010
2195 From: rlane@club.cc.cmu.edu (Rich Lane)
2196 Date: Fri, 19 Mar 2010 17:02:44 -0400
2197 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2198 generating the unique id for each message
2199 In-Reply-To: <1269029060-sup-9476@pinkfloyd.chass.utoronto.ca>
2200 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2201 <1269026769-sup-3830@midna.zekjur.net>
2202 <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2203 <1269027991-sup-5670@midna.zekjur.net>
2204 <1269029060-sup-9476@pinkfloyd.chass.utoronto.ca>
2205 Message-ID: <1269029524-sup-9834@zyrg.net>
2206
2207 Excerpts from Ben Walton's message of 2010-03-19 16:05:06 -0400:
2208 > Excerpts from Michael Stapelberg's message of Fri Mar 19 15:47:53 -0400 2010:
2209 >
2210 > > There is: Rich mentioned that proper move/delete handling for
2211 > > maildirs also solves the problem. However that doesn?t seem to be
2212 > > planned for the very near future, so I posted my patch which fixes
2213 > > the problem right now (given that you use ruby 1.9 and a decent
2214 > > filesystem).
2215 >
2216 > Ok. I'd rather work with you towards implementing this handling than
2217 > force an upgrade on myself that would be both ruby and filesystem
2218 > (incl servers and nfs).
2219
2220 I'd also much rather see proper maildir handling. My objections to the
2221 current patch are Ruby 1.8 compatibility - not just the missing method,
2222 but that you'd need to reindex whenever switching between Ruby 1.8 and
2223 1.9.
2224
2225 From marka@pobox.com Fri Mar 19 17:04:11 2010
2226 From: marka@pobox.com (Mark Alexander)
2227 Date: Fri, 19 Mar 2010 17:04:11 -0400
2228 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2229 generating the unique id for each message
2230 In-Reply-To: <1269029869-sup-4474@changeling.local>
2231 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2232 <1269026805-sup-2720@changeling.local>
2233 <1269027951-sup-4565@midna.zekjur.net>
2234 <1269029869-sup-4474@changeling.local>
2235 Message-ID: <1269032594-sup-5368@r61>
2236
2237 Excerpts from Eric Sherman's message of Fri Mar 19 16:40:46 -0400 2010:
2238 > Would appending x-digits of numeric noise, probably derived from SHA1, be
2239 > suitable?
2240
2241 I was thinking the same thing. For performance, perhaps only the SHA1
2242 of the file name, not the file contents, would be adequate.
2243
2244 From rlane@club.cc.cmu.edu Fri Mar 19 17:17:50 2010
2245 From: rlane@club.cc.cmu.edu (Rich Lane)
2246 Date: Fri, 19 Mar 2010 17:17:50 -0400
2247 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2248 generating the unique id for each message
2249 In-Reply-To: <1269030873-sup-4844@r61>
2250 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2251 <1269026769-sup-3830@midna.zekjur.net>
2252 <1269027265-sup-5150@pinkfloyd.chass.utoronto.ca>
2253 <1269027991-sup-5670@midna.zekjur.net> <1269030873-sup-4844@r61>
2254 Message-ID: <1269032592-sup-2403@zyrg.net>
2255
2256 Excerpts from Mark Alexander's message of 2010-03-19 16:35:38 -0400:
2257 > Excerpts from Michael Stapelberg's message of Fri Mar 19 15:47:53 -0400 2010:
2258 > > Excerpts from Ben Walton's message of 2010-03-19 20:35:31 +0100:
2259 > > > Isn't there a more portable solution?
2260 > > There is: Rich mentioned that proper move/delete handling for maildirs also
2261 > > solves the problem.
2262 >
2263 > I must have missed that message. What is the proposed solution?
2264 > How does it solve the problem of out-of-order maildir IDs?
2265
2266 Notmuch implements this correctly. They essentially keep a sorted list
2267 of mail filenames in the index and then iterate over that and the sorted
2268 list of the filenames that are currently in the maildir to detect
2269 inserts, deletes, and renames.
2270
2271 I just rebased and pushed a multiple-locations branch I've had sitting
2272 around to mainline. It's probably buggy. It's been a while since I
2273 thought about this problem, but I think keeping track of multiple
2274 locations (source/source info) for a single message (identified by
2275 message-id) should make the maildir logic simpler.
2276
2277 From marka@pobox.com Fri Mar 19 22:23:00 2010
2278 From: marka@pobox.com (Mark Alexander)
2279 Date: Fri, 19 Mar 2010 22:23:00 -0400
2280 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2281 generating the unique id for each message
2282 In-Reply-To: <1269032594-sup-5368@r61>
2283 References: <1269012878-sup-691@midna.zekjur.net> <1269026068-sup-6868@r61>
2284 <1269026805-sup-2720@changeling.local>
2285 <1269027951-sup-4565@midna.zekjur.net>
2286 <1269029869-sup-4474@changeling.local> <1269032594-sup-5368@r61>
2287 Message-ID: <1269051705-sup-616@r61>
2288
2289 Excerpts from Mark Alexander's message of Fri Mar 19 17:04:11 -0400 2010:
2290 > Excerpts from Eric Sherman's message of Fri Mar 19 16:40:46 -0400 2010:
2291 > > Would appending x-digits of numeric noise, probably derived from SHA1, be
2292 > > suitable?
2293 >
2294 > I was thinking the same thing. For performance, perhaps only the SHA1
2295 > of the file name, not the file contents, would be adequate.
2296
2297 Never mind. This won't work because it violates the requirement
2298 that IDs must always increase.
2299
2300 From sup-bugs@masanjin.net Sat Mar 20 16:20:34 2010
2301 From: sup-bugs@masanjin.net (anonymous)
2302 Date: Sat, 20 Mar 2010 20:20:34 +0000
2303 Subject: [sup-devel] [issue84] GPG Decryption Requests
2304 In-Reply-To: <1269116433.99.0.720137867047.issue84@masanjin.net>
2305 Message-ID: <1269116433.99.0.720137867047.issue84@masanjin.net>
2306
2307
2308 New submission from anonymous:
2309
2310 Would it be possible to add a feature to prevent GPG decryption requests from
2311 occurring unless an encrypted message is actually viewed?
2312
2313 ----------
2314 messages: 201
2315 nosy: anonymous
2316 priority: feature request
2317 ruby_version: 1.8.7
2318 status: unread
2319 sup_version: 0.11
2320 title: GPG Decryption Requests
2321
2322 _________________________________________
2323 Sup issue tracker <sup-bugs at masanjin.net>
2324 <http://masanjin.net/sup-bugs/issue84>
2325 _________________________________________
2326
2327 From sup-bugs@masanjin.net Sun Mar 21 19:30:14 2010
2328 From: sup-bugs@masanjin.net (anonymous)
2329 Date: Sun, 21 Mar 2010 23:30:14 +0000
2330 Subject: [sup-devel] [issue85] GPG Decryption Key Binding
2331 In-Reply-To: <1269214214.04.0.976768799922.issue85@masanjin.net>
2332 Message-ID: <1269214214.04.0.976768799922.issue85@masanjin.net>
2333
2334
2335 New submission from anonymous:
2336
2337 It would be nice to be able to disable automatic decryption and instead use a key
2338 binding to decrypt a viewed message.
2339
2340 ----------
2341 messages: 203
2342 nosy: anonymous
2343 priority: feature request
2344 ruby_version: N/A
2345 status: unread
2346 sup_version: 0.11
2347 title: GPG Decryption Key Binding
2348
2349 _________________________________________
2350 Sup issue tracker <sup-bugs at masanjin.net>
2351 <http://masanjin.net/sup-bugs/issue85>
2352 _________________________________________
2353
2354 From michael+sup@stapelberg.de Mon Mar 22 07:30:15 2010
2355 From: michael+sup@stapelberg.de (Michael Stapelberg)
2356 Date: Mon, 22 Mar 2010 12:30:15 +0100
2357 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2358 generating the unique id for each message
2359 In-Reply-To: <1269012878-sup-691@midna.zekjur.net>
2360 References: <1269012878-sup-691@midna.zekjur.net>
2361 Message-ID: <1269257324-sup-3868@midna.zekjur.net>
2362
2363 Hi,
2364
2365 attached to this mail you can find an updated version of the patch. It now
2366 uses a fixed length in sprintf for the nanoseconds so that the IDs will be
2367 increasing.
2368
2369 Best regards,
2370 Michael
2371 -------------- next part --------------
2372 A non-text attachment was scrubbed...
2373 Name: 0002-Use-nanosecond-resolution-of-mtime-for-generating-th.patch
2374 Type: application/octet-stream
2375 Size: 895 bytes
2376 Desc: not available
2377 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100322/1f4f4250/attachment.obj>
2378
2379 From bwalton@artsci.utoronto.ca Mon Mar 22 12:25:47 2010
2380 From: bwalton@artsci.utoronto.ca (Ben Walton)
2381 Date: Mon, 22 Mar 2010 12:25:47 -0400
2382 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2383 generating the unique id for each message
2384 In-Reply-To: <1269257324-sup-3868@midna.zekjur.net>
2385 References: <1269012878-sup-691@midna.zekjur.net>
2386 <1269257324-sup-3868@midna.zekjur.net>
2387 Message-ID: <1269275101-sup-1611@pinkfloyd.chass.utoronto.ca>
2388
2389 Excerpts from Michael Stapelberg's message of Mon Mar 22 07:30:15 -0400 2010:
2390
2391 > attached to this mail you can find an updated version of the
2392 > patch. It now uses a fixed length in sprintf for the nanoseconds so
2393 > that the IDs will be increasing.
2394
2395 So we're still needing ruby 1.9 and ext4 then? That's a deal breaker
2396 for me. 1.9 I can live with, but there is no way my environment will
2397 be using ext4 any time soon.
2398
2399 Thanks
2400 -Ben
2401 --
2402 Ben Walton
2403 Systems Programmer - CHASS
2404 University of Toronto
2405 C:416.407.5610 | W:416.978.4302
2406
2407
2408 From rlane@club.cc.cmu.edu Mon Mar 22 13:00:47 2010
2409 From: rlane@club.cc.cmu.edu (Rich Lane)
2410 Date: Mon, 22 Mar 2010 13:00:47 -0400
2411 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2412 generating the unique id for each message
2413 In-Reply-To: <1269257324-sup-3868@midna.zekjur.net>
2414 References: <1269012878-sup-691@midna.zekjur.net>
2415 <1269257324-sup-3868@midna.zekjur.net>
2416 Message-ID: <1269276247-sup-3011@zyrg.net>
2417
2418 Excerpts from Michael Stapelberg's message of 2010-03-22 07:30:15 -0400:
2419 > attached to this mail you can find an updated version of the patch. It now
2420 > uses a fixed length in sprintf for the nanoseconds so that the IDs will be
2421 > increasing.
2422
2423 If you add a config option (defaulting to false) I'll accept the patch.
2424
2425 I'm going to restart looking at implementing proper maildir support.
2426 IIRC the tough part is making it fit within sup's existing source
2427 interfaces. Part of my reason for nuking IMAP/mbox+ssh sources was to
2428 make changes to the source API easier, so hopefully this will be more
2429 tractable now.
2430
2431 From kljohann@gmail.com Wed Mar 24 22:21:32 2010
2432 From: kljohann@gmail.com (=?ISO-8859-1?Q?Johann_Kl=E4hn?=)
2433 Date: Thu, 25 Mar 2010 03:21:32 +0100
2434 Subject: [sup-devel] Accept ASCII_8BIT in String.check
2435 In-Reply-To: <b0bc07101003241915t22d13ea2w26468d9d72df972f@mail.gmail.com>
2436 References: <b0bc07101003241915t22d13ea2w26468d9d72df972f@mail.gmail.com>
2437 Message-ID: <b0bc07101003241921t5183709j67e7848025aac824@mail.gmail.com>
2438
2439 I was having problems with encoded emails. Using archlinux / ruby
2440 1.9.1_p378 Iconv.iconv returns the encoding ASCII_8BIT,
2441 which was rejected by String.check.
2442
2443 Before I was getting debug messages like this when converting mails or
2444 building the index:
2445 ?couldn't transcode text from ISO-8859-1 (ISO-8859-1) to utf8) (...)
2446 (got unexpected encoding ASCII-8BIT (String::CheckError))
2447 My String.check now contains:
2448 ? if respond_to?(:encoding) && !(encoding == Encoding::UTF_8 ||
2449 encoding == Encoding::ASCII || encoding == Encoding::ASCII_8BIT)
2450 And everything is working as expected. Instead of text.ascii the real
2451 umlauts are displayed.
2452
2453 Hope that helps,
2454 Johann
2455
2456 From rlane@club.cc.cmu.edu Wed Mar 24 23:20:13 2010
2457 From: rlane@club.cc.cmu.edu (Rich Lane)
2458 Date: Wed, 24 Mar 2010 23:20:13 -0400
2459 Subject: [sup-devel] Accept ASCII_8BIT in String.check
2460 In-Reply-To: <b0bc07101003241921t5183709j67e7848025aac824@mail.gmail.com>
2461 References: <b0bc07101003241915t22d13ea2w26468d9d72df972f@mail.gmail.com>
2462 <b0bc07101003241921t5183709j67e7848025aac824@mail.gmail.com>
2463 Message-ID: <1269487066-sup-656@zyrg.net>
2464
2465 Excerpts from Johann Kl?hn's message of 2010-03-24 22:21:32 -0400:
2466 > I was having problems with encoded emails. Using archlinux / ruby
2467 > 1.9.1_p378 Iconv.iconv returns the encoding ASCII_8BIT,
2468 > which was rejected by String.check.
2469 >
2470 > Before I was getting debug messages like this when converting mails or
2471 > building the index:
2472 > ?couldn't transcode text from ISO-8859-1 (ISO-8859-1) to utf8) (...)
2473 > (got unexpected encoding ASCII-8BIT (String::CheckError))
2474 > My String.check now contains:
2475 > ? if respond_to?(:encoding) && !(encoding == Encoding::UTF_8 ||
2476 > encoding == Encoding::ASCII || encoding == Encoding::ASCII_8BIT)
2477 > And everything is working as expected. Instead of text.ascii the real
2478 > umlauts are displayed.
2479 >
2480 > Hope that helps,
2481 > Johann
2482
2483 An ASCII_8BIT string means there's a bug in sup. Please add an assertion
2484 so that the program exits when the encoding is ASCII_8BIT and post the
2485 backtrace. Also, what sup version is this?
2486
2487 From tero@tilus.net Thu Mar 25 02:25:21 2010
2488 From: tero@tilus.net (Tero Tilus)
2489 Date: Thu, 25 Mar 2010 08:25:21 +0200
2490 Subject: [sup-devel] [PATCH 2/2] Use nanosecond resolution of mtime for
2491 generating the unique id for each message
2492 In-Reply-To: <1269275101-sup-1611@pinkfloyd.chass.utoronto.ca>
2493 References: <1269012878-sup-691@midna.zekjur.net>
2494 <1269257324-sup-3868@midna.zekjur.net>
2495 <1269275101-sup-1611@pinkfloyd.chass.utoronto.ca>
2496 Message-ID: <1269497979-sup-4663@tilus.net>
2497
2498 Ben Walton, 2010-03-22 18:25:
2499 > So we're still needing ruby 1.9 and ext4 then? That's a deal
2500 > breaker for me.
2501
2502 I'm with Ben in this. I'll need to be able to do without them both
2503 for quite a while.
2504
2505 --
2506 Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/
2507
2508 From rlane@club.cc.cmu.edu Thu Mar 25 03:12:57 2010
2509 From: rlane@club.cc.cmu.edu (Rich Lane)
2510 Date: Thu, 25 Mar 2010 03:12:57 -0400
2511 Subject: [sup-devel] new branch: maildir
2512 Message-ID: <1269499582-sup-2593@zyrg.net>
2513
2514 This branch makes some drastic changes to how mbox and maildir sources
2515 work. There's no longer any state associated with a source between Sup
2516 runs - no cur_offset or mtimes in sources.yaml. Instead, the source
2517 queries the index to find out which messages it's already seen and which
2518 messages are new. This enables a much more robust maildir
2519 implementation that detects the addition or deletion of any message.
2520
2521 It's not totally done yet. It'll detect that a maildir message has been
2522 deleted, but it doesn't yet remove the old location from the index so
2523 renames are unlikely to work. There needs to be UI code to handle the
2524 case where a message matches a search but has been deleted from all
2525 sources, and probably a utility to remove such messages from the index.
2526 I expect sup-sync-back to be broken.
2527
2528 Keeping track of multiple locations per message requires an index format
2529 change. The upgrade process is trivial and done automatically but you
2530 won't be able to use that index with an older Sup. For now if you want
2531 to try this out I suggest using a different SUP_BASE.
2532
2533 I'd appreciate any comments about the code or general approach. If
2534 anyone would like to contribute an email corpus for the unwritten
2535 testsuite or pseudocode out some testcases that would be very helpful
2536 too.
2537
2538 From kljohann@gmail.com Thu Mar 25 04:02:52 2010
2539 From: kljohann@gmail.com (=?ISO-8859-1?Q?Johann_Kl=E4hn?=)
2540 Date: Thu, 25 Mar 2010 09:02:52 +0100
2541 Subject: [sup-devel] Accept ASCII_8BIT in String.check
2542 In-Reply-To: <1269487066-sup-656@zyrg.net>
2543 References: <b0bc07101003241915t22d13ea2w26468d9d72df972f@mail.gmail.com>
2544 <b0bc07101003241921t5183709j67e7848025aac824@mail.gmail.com>
2545 <1269487066-sup-656@zyrg.net>
2546 Message-ID: <b0bc07101003250102x72de338dt419fe15cd38c3e80@mail.gmail.com>
2547
2548 Ah, now it's perfectly clean to me, I guess I just shouldn't do any debugging
2549 when I'm too tired.
2550 The problem is that the call to Iconv.iconv(target, ..., ...) in
2551 Iconv.easy_decode
2552 expects target to be typed as "UTF-8", and my environment has
2553 $encoding = "utf8".
2554 Iconv can't handle this and thus returns ASCII_8BIT (does no real conversion).
2555 (I'm using sup 0.11 with ruby 1.9.1_p378.)
2556
2557 From marka@pobox.com Thu Mar 25 07:24:59 2010
2558 From: marka@pobox.com (Mark Alexander)
2559 Date: Thu, 25 Mar 2010 07:24:59 -0400
2560 Subject: [sup-devel] new branch: maildir
2561 In-Reply-To: <1269499582-sup-2593@zyrg.net>
2562 References: <1269499582-sup-2593@zyrg.net>
2563 Message-ID: <1269516077-sup-4573@r61>
2564
2565 Excerpts from Rich Lane's message of Thu Mar 25 03:12:57 -0400 2010:
2566 > This branch makes some drastic changes to how mbox and maildir sources
2567 > work.
2568
2569 Thanks for attacking this problem!
2570
2571 I just took a quick look at the diffs, and I have some concern
2572 about this line in maildir.rb:
2573
2574 Dir[File.join(subdir, '*')].map do |fn|
2575
2576 I'm worried about the memory usage with some of my maildirs that have
2577 tens of thousands of files. Would it be more memory-efficient to
2578 use Dir.open and Dir.each? You'd have to filter out "." and "..",
2579 of course.
2580
2581 From bwalton@artsci.utoronto.ca Thu Mar 25 09:30:32 2010
2582 From: bwalton@artsci.utoronto.ca (Ben Walton)
2583 Date: Thu, 25 Mar 2010 09:30:32 -0400
2584 Subject: [sup-devel] new branch: maildir
2585 In-Reply-To: <1269516077-sup-4573@r61>
2586 References: <1269499582-sup-2593@zyrg.net> <1269516077-sup-4573@r61>
2587 Message-ID: <1269523798-sup-9324@pinkfloyd.chass.utoronto.ca>
2588
2589 Excerpts from Mark Alexander's message of Thu Mar 25 07:24:59 -0400 2010:
2590
2591 > I'm worried about the memory usage with some of my maildirs that
2592 > have tens of thousands of files. Would it be more memory-efficient
2593 > to use Dir.open and Dir.each? You'd have to filter out "." and
2594 > "..", of course.
2595
2596 Agreed:
2597
2598 bwalton @ pinkfloyd : ~/Maildir/new
2599 $ ls -1 | wc -l
2600 35058
2601
2602 I do like the overall idea though. I'll try to give this a spin
2603 tonight.
2604
2605 Thanks
2606 -Ben
2607
2608 --
2609 Ben Walton
2610 Systems Programmer - CHASS
2611 University of Toronto
2612 C:416.407.5610 | W:416.978.4302
2613
2614
2615 From rlane@club.cc.cmu.edu Thu Mar 25 12:11:57 2010
2616 From: rlane@club.cc.cmu.edu (Rich Lane)
2617 Date: Thu, 25 Mar 2010 12:11:57 -0400
2618 Subject: [sup-devel] new branch: maildir
2619 In-Reply-To: <1269516077-sup-4573@r61>
2620 References: <1269499582-sup-2593@zyrg.net> <1269516077-sup-4573@r61>
2621 Message-ID: <1269532152-sup-1158@zyrg.net>
2622
2623 Excerpts from Mark Alexander's message of 2010-03-25 07:24:59 -0400:
2624 > Excerpts from Rich Lane's message of Thu Mar 25 03:12:57 -0400 2010:
2625 > > This branch makes some drastic changes to how mbox and maildir sources
2626 > > work.
2627 >
2628 > Thanks for attacking this problem!
2629 >
2630 > I just took a quick look at the diffs, and I have some concern
2631 > about this line in maildir.rb:
2632 >
2633 > Dir[File.join(subdir, '*')].map do |fn|
2634 >
2635 > I'm worried about the memory usage with some of my maildirs that have
2636 > tens of thousands of files. Would it be more memory-efficient to
2637 > use Dir.open and Dir.each? You'd have to filter out "." and "..",
2638 > of course.
2639
2640 Hence the "XXX use less memory" :). I've been doing my testing on a 30k
2641 maildir which works fine. My sup scalability target is a million
2642 messages and memory becomes a concern there. A maildir filename is about
2643 30 characters plus any Ruby overhead.
2644
2645 The primitives we have are:
2646 Iterate through filenames in a directory in arbitrary (?) order.
2647 Check the existence of a single file in a directory.
2648 Iterate through filenames with a given prefix stored in the index in lexicographical order.
2649 Any more?
2650
2651 Right now I took the easiest route which loads both the filesystem and
2652 indexed filenames into arrays and diffs them. Iterating over the index
2653 and checking the file's existence won't detect new messages. Iterating
2654 over the filesystem and checking for existence in the index won't detect
2655 deleted messages. A solution would be to do both, but that seems
2656 expensive. It would be good if we could optimize for the case where most
2657 of the maildir messages have already been indexed.
2658
2659 From michael+sup@stapelberg.de Fri Mar 26 00:33:07 2010
2660 From: michael+sup@stapelberg.de (Michael Stapelberg)
2661 Date: Fri, 26 Mar 2010 05:33:07 +0100
2662 Subject: [sup-devel] [PATCH] Bugfix: for encrypted and signed messages,
2663 run verification and decryption separately
2664 Message-ID: <1269577931-sup-7751@midna.zekjur.net>
2665
2666 Hi,
2667
2668 attached to this email you can find a patch which runs verification and
2669 decryption of signed + encrypted messages separately. This is necessary
2670 because GPG will stop decrypting a message when the signature cannot be
2671 verified for any reason (like the public key not being in your keyring).
2672
2673 Best regards,
2674 Michael
2675 -------------- next part --------------
2676 A non-text attachment was scrubbed...
2677 Name: 0001-Bugfix-for-encrypted-and-signed-messages-run-verific.patch
2678 Type: application/octet-stream
2679 Size: 2907 bytes
2680 Desc: not available
2681 URL: <http://rubyforge.org/pipermail/sup-devel/attachments/20100326/8d6b1b94/attachment.obj>
2682
2683 From rlane@club.cc.cmu.edu Sun Mar 28 17:35:08 2010
2684 From: rlane@club.cc.cmu.edu (Rich Lane)
2685 Date: Sun, 28 Mar 2010 17:35:08 -0400
2686 Subject: [sup-devel] [PATCH 1/2] Make sup-tweak-labels work with ruby 1.9
2687 In-Reply-To: <1269012800-sup-3632@midna.zekjur.net>
2688 References: <1269012800-sup-3632@midna.zekjur.net>
2689 Message-ID: <1269811961-sup-779@zyrg.net>
2690
2691 Excerpts from Michael Stapelberg's message of 2010-03-19 11:34:26 -0400:
2692 > attached you find a patch to make sup-tweak-labels work with 1.9. Maybe the
2693 > line can be written more beautifully.
2694
2695 Thanks for the bug report, I committed a change that solved it in a
2696 different way (87dcb31).
2697
2698 From rlane@club.cc.cmu.edu Sun Mar 28 17:36:54 2010
2699 From: rlane@club.cc.cmu.edu (Rich Lane)
2700 Date: Sun, 28 Mar 2010 17:36:54 -0400
2701 Subject: [sup-devel] [PATCH] Start gpg with LC_MESSAGES=C
2702 In-Reply-To: <1269024593-sup-9101@midna.zekjur.net>
2703 References: <1269024593-sup-9101@midna.zekjur.net>
2704 Message-ID: <1269812185-sup-2258@zyrg.net>
2705
2706 Excerpts from Michael Stapelberg's message of 2010-03-19 14:53:04 -0400:
2707 > attached you find a patch which ensures that LC_MESSAGES=C is set when starting
2708 > gpg so that the regexps for interpreting the gpg output work.
2709
2710 Applied to master.
2711
2712 From rlane@club.cc.cmu.edu Sun Mar 28 17:46:46 2010
2713 From: rlane@club.cc.cmu.edu (Rich Lane)
2714 Date: Sun, 28 Mar 2010 17:46:46 -0400
2715 Subject: [sup-devel] [PATCH] Bugfix: for encrypted and signed messages,
2716 run verification and decryption separately
2717 In-Reply-To: <1269577931-sup-7751@midna.zekjur.net>
2718 References: <1269577931-sup-7751@midna.zekjur.net>
2719 Message-ID: <1269812299-sup-3173@zyrg.net>
2720
2721 Excerpts from Michael Stapelberg's message of 2010-03-26 00:33:07 -0400:
2722 > attached to this email you can find a patch which runs verification and
2723 > decryption of signed + encrypted messages separately. This is necessary
2724 > because GPG will stop decrypting a message when the signature cannot be
2725 > verified for any reason (like the public key not being in your keyring).
2726
2727 Applied to branch inline-gpg and re-merged to next.
2728
2729 From sup-bugs@masanjin.net Sun Mar 28 22:21:02 2010
2730 From: sup-bugs@masanjin.net (anonymous)
2731 Date: Mon, 29 Mar 2010 02:21:02 +0000
2732 Subject: [sup-devel] [issue86] git-style delta storage
2733 In-Reply-To: <1269829261.99.0.22306257269.issue86@masanjin.net>
2734 Message-ID: <1269829261.99.0.22306257269.issue86@masanjin.net>
2735
2736
2737 New submission from anonymous:
2738
2739 Maybe this is a crazy idea, but I think it would be a well-rewarding long-term
2740 project because if it's completed, Sup would be the first mail client to
2741 implement it: have Sup store mail in delta storage.
2742
2743 An obvious raison d'?tre would be that storing a lot of mail would consume a
2744 large amount of disk space, and using delta storage would greatly reduce that
2745 amount, especially when threads that contain messages that quote each other are
2746 present.
2747
2748 See http://kerneltrap.org/mailarchive/git/2007/9/21/270502 and
2749 http://kerneltrap.org/mailarchive/git/2007/9/21/273603
2750
2751 Also see http://www.matthias-georgi.de/gitstore
2752
2753 ----------
2754 messages: 204
2755 nosy: anonymous
2756 priority: feature request
2757 ruby_version: 1.9.1_p378
2758 status: unread
2759 sup_version: 0.11
2760 title: git-style delta storage
2761
2762 _________________________________________
2763 Sup issue tracker <sup-bugs at masanjin.net>
2764 <http://masanjin.net/sup-bugs/issue86>
2765 _________________________________________
2766
2767 From sup-bugs@masanjin.net Mon Mar 29 16:38:31 2010
2768 From: sup-bugs@masanjin.net (anonymous)
2769 Date: Mon, 29 Mar 2010 20:38:31 +0000
2770 Subject: [sup-devel] [issue87] undefined method `<' for nil:NilClass
2771 in index.rb:truncate_date
2772 In-Reply-To: <1269895111.8.0.502890815182.issue87@masanjin.net>
2773 Message-ID: <1269895111.8.0.502890815182.issue87@masanjin.net>
2774
2775
2776 New submission from anonymous:
2777
2778 [Mon Mar 29 13:36:23 -0700 2010] ERROR: oh crap, an exception
2779 ----------------------------------------------------------------
2780 I'm very sorry. It seems that an error occurred in Sup. Please
2781 accept my sincere apologies. Please submit the contents of
2782 /home/emarinelli/.sup/exception-log.txt and a brief report of the
2783 circumstances to http://masanjin.net/sup-bugs/ so that I might
2784 address this problem. Thank you!
2785
2786 Sincerely,
2787 William
2788 ----------------------------------------------------------------
2789 j--- NoMethodError from thread: user-invoked poll
2790 undefined method `<' for nil:NilClass
2791 /home/emarinelli/sup_experimental/sup/lib/sup/index.rb:691:in `truncate_date'
2792 /home/emarinelli/sup_experimental/sup/lib/sup/index.rb:580:in `sync_message'
2793 /home/emarinelli/sup_experimental/sup/lib/sup/index.rb:122:in `add_message'
2794 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:570:in `send'
2795 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:570:in `method_missing'
2796 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:190:in `add_new_message'
2797 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:132:in `do_poll'
2798 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:176:in `each_message_from'
2799 /home/emarinelli/sup_experimental/sup/lib/sup/maildir.rb:160:in `each'
2800 /home/emarinelli/sup_experimental/sup/lib/sup/maildir.rb:157:in `upto'
2801 /home/emarinelli/sup_experimental/sup/lib/sup/maildir.rb:157:in `each'
2802 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:610:in `send'
2803 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:610:in `__pass'
2804 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:597:in `method_missing'
2805 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:164:in `each_message_from'
2806 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:116:in `do_poll'
2807 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:104:in `each'
2808 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:104:in `do_poll'
2809 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:103:in `synchronize'
2810 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:103:in `do_poll'
2811 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:570:in `send'
2812 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:570:in `method_missing'
2813 /home/emarinelli/sup_experimental/sup/lib/sup/modes/poll-mode.rb:15:in `poll'
2814 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:50:in `poll_with_sources'
2815 /home/emarinelli/sup_experimental/sup/lib/sup/poll.rb:69:in `poll'
2816 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:570:in `send'
2817 /home/emarinelli/sup_experimental/sup/lib/sup/util.rb:570:in `method_missing'
2818 /home/emarinelli/sup_experimental/sup/bin/sup:332
2819 /home/emarinelli/sup_experimental/sup/lib/sup.rb:76:in `reporting_thread'
2820 /home/emarinelli/sup_experimental/sup/lib/sup.rb:74:in `initialize'
2821 /home/emarinelli/sup_experimental/sup/lib/sup.rb:74:in `new'
2822 /home/emarinelli/sup_experimental/sup/lib/sup.rb:74:in `reporting_thread'
2823 /home/emarinelli/sup_experimental/sup/bin/sup:332
2824
2825 ----------
2826 messages: 206
2827 nosy: anonymous
2828 priority: bug
2829 ruby_version: ruby 1.8.7 (2009-06-12 patchlevel 174) [x86_64-linux]
2830 status: unread
2831 sup_version: 1835048a7eaffbf1823b464f219302497080c11b
2832 title: undefined method `<' for nil:NilClass in index.rb:truncate_date
2833
2834 _________________________________________
2835 Sup issue tracker <sup-bugs at masanjin.net>
2836 <http://masanjin.net/sup-bugs/issue87>
2837 _________________________________________
2838
2839 From tero@tilus.net Tue Mar 30 08:42:14 2010
2840 From: tero@tilus.net (Tero Tilus)
2841 Date: Tue, 30 Mar 2010 15:42:14 +0300
2842 Subject: [sup-devel] [issue86] git-style delta storage
2843 In-Reply-To: <1269829261.99.0.22306257269.issue86@masanjin.net>
2844 References: <1269829261.99.0.22306257269.issue86@masanjin.net>
2845 Message-ID: <1269952015-sup-624@tilus.net>
2846
2847 anonymous, 2010-03-29 05:21:
2848 > Maybe this is a crazy idea, but I think it would be a well-rewarding
2849 > long-term project because if it's completed, Sup would be the first
2850 > mail client to implement it: have Sup store mail in delta storage.
2851
2852 Storing mail in delta storage (or git repo or whatelse) is not a crazy
2853 idea at all. It has quite a few benefits. It is just that basically
2854 sup doesn't do mail _storage_ at all. It only reads mailstore
2855 (currently only Maildir) and writes to (Xapian) index, which it mainly
2856 uses.
2857
2858 I'm closing this for now, because (though it is a great idea in
2859 general) IMO this is currently out of the context of sup.
2860
2861 status: resolved
2862
2863 --
2864 Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/
2865