From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 461723664384 X-Google-Groups: supmua X-Google-Thread: 3030fda1bf,dd49f73ce9d462ba X-Google-Attributes: gid3030fda1bf,domainid0,public,googlegroup X-Google-NewGroupId: yes X-Received: by 10.112.188.199 with SMTP id gc7mr705396lbc.6.1419787903940; Sun, 28 Dec 2014 09:31:43 -0800 (PST) X-BeenThere: supmua@googlegroups.com Received: by 10.152.205.66 with SMTP id le2ls1878483lac.90.gmail; Sun, 28 Dec 2014 09:31:43 -0800 (PST) X-Received: by 10.112.137.136 with SMTP id qi8mr300lbb.13.1419787903171; Sun, 28 Dec 2014 09:31:43 -0800 (PST) Return-Path: Received: from mr.tuwien.ac.at (mr1.kom.tuwien.ac.at. [128.130.2.109]) by gmr-mx.google.com with ESMTPS id s6si340738wif.0.2014.12.28.09.31.43 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 28 Dec 2014 09:31:43 -0800 (PST) Received-SPF: none (google.com: mbaehr@email.archlab.tuwien.ac.at does not designate permitted sender hosts) client-ip=128.130.2.109; Authentication-Results: gmr-mx.google.com; spf=none (google.com: mbaehr@email.archlab.tuwien.ac.at does not designate permitted sender hosts) smtp.mail=mbaehr@email.archlab.tuwien.ac.at; dmarc=fail (p=NONE dis=NONE) header.from=tuwien.ac.at Received: from email.archlab.tuwien.ac.at (email.archlab.tuwien.ac.at [128.131.118.17]) by mr.tuwien.ac.at (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id sBSHVfH8020952; Sun, 28 Dec 2014 18:31:41 +0100 Received: from mbaehr by email.archlab.tuwien.ac.at with local (Exim 4.72) (envelope-from ) id 1Y5Hgg-0006aZ-WF; Sun, 28 Dec 2014 18:31:31 +0100 Date: Sun, 28 Dec 2014 18:31:30 +0100 From: =?utf-8?q?Martin_B=C3=A4hr?= To: Gaute Hope Cc: supmua Message-ID: <1419787476-sup-5076@email.archlab.tuwien.ac.at> In-Reply-To: <1419786092-astroid-5-92dov2kfj7-1194@strange> References: <1419701714-sup-6215@email.archlab.tuwien.ac.at> <1419775872-astroid-4-gk0eja34lo-1194@strange> <1419782945-sup-3956@email.archlab.tuwien.ac.at> <1419786092-astroid-5-92dov2kfj7-1194@strange> Subject: Re: [sup] papercuts and google code-in Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable User-Agent: Sup/git X-Virus-Scanned: by amavisd-new on vc7.kom.tuwien.ac.at Excerpts from Gaute Hope's message of 2014-12-28 18:06:10 +0100: > > though i'd appreciate a little help in reviewing pull-requests, at le= ast in > > terms of deciding whether they are good enough for merging. in partic= ular i am > > inexperienced in dealing with test-cases, and it would be nice if you= could > > indicate if an issue should have a test case or not. or point out wha= t to test for. > Yep, I can probably help a bit out there - though my time is limited. > Make sure that the code is tested by both the author and at least one > other (you?). yes, that's sensible. > E.g. #358 is difficult to write a test case for, but you > need to test how it works with: > = > - no .sup dir > - a previous config.yml but no sources.yml > - both existing, but perhaps sources empty. great, that sort of detail is very helpful. thanks! > indicate in the PR if you have tested it and what your recommendation i= s. > #357 does not need a test case, but I am not sure it is more accurate > now than before - please see my comment there. hehe, yeah, changing "found" to "loaded" was idea nr 44. adding a count i= s idea nr 45 :-) the thing that irked me with "found" was that it suggested that there are= no more threads. "loaded" is just a statement of fact without that suggestion. greetings, martin. -- = eKita - the online platform for your entire academic = life -- = chief engineer eKit= a.co pike programmer pike.lysator.liu.se caudium.net societyserver= .org BLUG secretary beijinglug= .org foresight developer foresightlinux.org realss= .com unix sysadmin Martin B=C3=A4hr working in china http://societyserver.or= g/mbaehr/