From: "Martin Bähr" <mbaehr@email.archlab.tuwien.ac.at>
To: Gaute Hope <eg@gaute.vetsj.com>
Cc: supmua <supmua@googlegroups.com>
Subject: Re: [sup] papercuts and google code-in
Date: Sun, 28 Dec 2014 18:31:30 +0100 [thread overview]
Message-ID: <1419787476-sup-5076@email.archlab.tuwien.ac.at> (raw)
In-Reply-To: <1419786092-astroid-5-92dov2kfj7-1194@strange>
Excerpts from Gaute Hope's message of 2014-12-28 18:06:10 +0100:
> > though i'd appreciate a little help in reviewing pull-requests, at least in
> > terms of deciding whether they are good enough for merging. in particular i am
> > inexperienced in dealing with test-cases, and it would be nice if you could
> > indicate if an issue should have a test case or not. or point out what to test for.
> Yep, I can probably help a bit out there - though my time is limited.
> Make sure that the code is tested by both the author and at least one
> other (you?).
yes, that's sensible.
> E.g. #358 is difficult to write a test case for, but you
> need to test how it works with:
>
> - no .sup dir
> - a previous config.yml but no sources.yml
> - both existing, but perhaps sources empty.
great, that sort of detail is very helpful. thanks!
> indicate in the PR if you have tested it and what your recommendation is.
> #357 does not need a test case, but I am not sure it is more accurate
> now than before - please see my comment there.
hehe, yeah, changing "found" to "loaded" was idea nr 44. adding a count is idea nr 45 :-)
the thing that irked me with "found" was that it suggested that there are no more threads.
"loaded" is just a statement of fact without that suggestion.
greetings, martin.
--
eKita - the online platform for your entire academic life
--
chief engineer eKita.co
pike programmer pike.lysator.liu.se caudium.net societyserver.org
BLUG secretary beijinglug.org
foresight developer foresightlinux.org realss.com
unix sysadmin
Martin Bähr working in china http://societyserver.org/mbaehr/
next prev parent reply other threads:[~2014-12-28 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 18:05 Martin Bähr
2014-12-28 14:14 ` [sup] " Gaute Hope
2014-12-28 16:12 ` Martin Bähr
2014-12-28 17:06 ` Gaute Hope
2014-12-28 17:31 ` Martin Bähr [this message]
2014-12-28 18:00 ` Gaute Hope
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419787476-sup-5076@email.archlab.tuwien.ac.at \
--to=mbaehr@email.archlab.tuwien.ac.at \
--cc=eg@gaute.vetsj.com \
--cc=supmua@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox