From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 461723664384 X-Google-Groups: supmua X-Google-Thread: 3030fda1bf,dd49f73ce9d462ba X-Google-Attributes: gid3030fda1bf,domainid0,public,googlegroup X-Google-NewGroupId: yes X-Received: by 10.112.137.70 with SMTP id qg6mr4581lbb.14.1419786350865; Sun, 28 Dec 2014 09:05:50 -0800 (PST) X-BeenThere: supmua@googlegroups.com Received: by 10.152.6.39 with SMTP id x7ls734069lax.92.gmail; Sun, 28 Dec 2014 09:05:50 -0800 (PST) X-Received: by 10.112.72.228 with SMTP id g4mr4205280lbv.4.1419786350466; Sun, 28 Dec 2014 09:05:50 -0800 (PST) Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com. [74.125.82.53]) by gmr-mx.google.com with ESMTPS id jv2si1860497wid.1.2014.12.28.09.05.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 28 Dec 2014 09:05:49 -0800 (PST) Received-SPF: none (google.com: eg@gaute.vetsj.com does not designate permitted sender hosts) client-ip=74.125.82.53; Authentication-Results: gmr-mx.google.com; spf=none (google.com: eg@gaute.vetsj.com does not designate permitted sender hosts) smtp.mail=eg@gaute.vetsj.com Received: by mail-wg0-f53.google.com with SMTP id l18so17373119wgh.40 for ; Sun, 28 Dec 2014 09:05:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :user-agent:message-id:mime-version:content-type :content-transfer-encoding; bh=I/kLb1VyfJEOSoH0I7yUub5pVjvAvcj4xPvRCtHx674=; b=EFGK/4fu5RCivUD3sh5HzU81p66lvBFwRMeemZV/e0Ruls62Vej/YAZu1JX1j6y6q2 b1ABe38BSgvTICo/HstqjQWTimKdtlIeDutZ7c5M80uKL3jJCjsbPA/HICjzM8MZ9vZj wUoEj8a2SfX03WSkH3kuFUGYNl1t+6tAgWEyu3Xe/pk9aj9pXVlPmHjzMTYKhi3eDZs5 4X9DgczVraCb1ae7v5Y/iFTrTkcUaEe7hUsJNCO44wJtEuba9hGJRchBF57ZAXkWn3Ap t3HoIfyKdlHBGRmrMPVTFUtJ/bd4WhslRwmsI/+tM+6spG0y902uHQP1YN64N14I3ixc xd2w== X-Gm-Message-State: ALoCoQkkTLNDOxvhwSjVB6+nIJhzczHo1lEkiho5yG1uN/1K7Pyz0UO6m2xkotXzszrN+o599vWX X-Received: by 10.194.104.137 with SMTP id ge9mr97817352wjb.135.1419786349716; Sun, 28 Dec 2014 09:05:49 -0800 (PST) Return-Path: Received: from localhost (216.89-20-249.enivest.net. [89.20.249.216]) by mx.google.com with ESMTPSA id bs2sm46667980wjc.43.2014.12.28.09.05.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Dec 2014 09:05:48 -0800 (PST) Date: Sun, 28 Dec 2014 17:06:10 +0000 From: Gaute Hope Subject: Re: [sup] papercuts and google code-in To: Martin =?iso-8859-1?b?QuRocg==?= Cc: supmua References: <1419701714-sup-6215@email.archlab.tuwien.ac.at> <1419775872-astroid-4-gk0eja34lo-1194@strange> <1419782945-sup-3956@email.archlab.tuwien.ac.at> In-Reply-To: <1419782945-sup-3956@email.archlab.tuwien.ac.at> User-Agent: astroid/vv0.1-39-g2bf94ba9 (https://github.com/gauteh/astroid) Message-Id: <1419786092-astroid-5-92dov2kfj7-1194@strange> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Excerpts from Martin B=C3=A4hr's message of December 28, 2014 17:12: > Excerpts from Gaute Hope's message of 2014-12-28 15:14:01 +0100: >> I invited you to become a contributor to the sup organization on github >> (embee right?). That way you can assign yourself to these issues and >> handle them on the issue-tracker. >>=20 >> Thanks for doing this, I hope there is time to polish things up enough >> to merge them. >=20 > i hope so too. > though i'd appreciate a little help in reviewing pull-requests, at least = in > terms of deciding whether they are good enough for merging. in particular= i am > inexperienced in dealing with test-cases, and it would be nice if you cou= ld > indicate if an issue should have a test case or not. or point out what to= test for. Yep, I can probably help a bit out there - though my time is limited. Make sure that the code is tested by both the author and at least one other (you?). E.g. #358 is difficult to write a test case for, but you need to test how it works with: - no .sup dir - a previous config.yml but no sources.yml - both existing, but perhaps sources empty. indicate in the PR if you have tested it and what your recommendation is. #357 does not need a test case, but I am not sure it is more accurate now than before - please see my comment there. cheers, gaute =