>== Auszüge aus der Nachricht von  Gaute Hope vom 2014-11-19 10:03:
> Excerpts from Ruthard Baudach's message of November 18, 2014 0:08:
> > If I am not mistaken, both RFC4155 and
> > http://www.qmail.org/man/man5/mbox.html
> > specify that an mbox entry is *terminated* by a blank line.
> > 
> > line 117 -124 of lib/sup/mbox.rb reads:
> > 
> >   def store_message date, from_email, &block
> >     need_blank = File.exists?(@path) && !File.zero?(@path)
> >     File.open(@path, "ab") do |f|
> >       f.puts if need_blank
> >       f.puts "From #{from_email} #{date.asctime}"
> >       yield f
> >     end
> >   end
> > 
> > As far as I understand this, sup puts a blank line *before* the
> > separator line except for the first message.
> > 
> > My old sent.mbox is terminated by the last line of the last message, my
> > old inbox.mbox is terminated by a blank line.
> > 
> > If I'm not mistaken, this could lead to problems, if the same mbox would
> > be fed by sup and another MDA, e.g. if someone would use the same mbox
> > for in- and outgoing mail (as I did when I had to setup sup anew after
> > upgrading to 0.15. Changing to maildir simultaneously safed me from this
> > bug. Huh!)
> > 
> > Changing the lines 117 - 124 of lib/sup/mbox.rb to
> > 
> >   def store_message date, from_email, &block
> >     File.open(@path, "ab") do |f|
> >       f.puts "From #{from_email} #{date.asctime}"
> >       yield f
> >       f.puts
> >     end
> >   end
> > 
> > would take care of this.
> > 
> > Do you agree?
> > 
> > Shall I submit a patch?
> > 
> > O – of course this would break existing setups with wrong formatted
> > mboxes.
> > 
> > Hmmmmmm???? 
> 
> haven't looked at the details yet, but nice catch.
> 
> oh.. that would be baad. breaking existing setups is a
> out-of-the-question though. Consequently; we need tests for whatever
> change fixing this introduces (have a look at the test folder).
> 
> I think a fix should; 
> - fix existing mboxes (on next write)
> - don't break on any existing mboxes
> - conform to standards
> - include tests of all these points
> - RMail has a mbox parser (i think) which perhaps could be used for
>   testing, i think sup included its own for performance reasons.
> 
> 
> gaute

I think

1) It's a minor bug, it would only cause problems if one would
   intermingle in- and outgoing mail. Does it has to be fixed?

2) I could either just fix it, write a script to fix wrongly formatted
   mboxes, and the next release would need a WARNING RUN SUP_FIX_MBOXES
   prior to using it after update.

3) I could check the mbox everytime a message is added and add a empty
   line as needed. Would increase disk usage.

I couldn't make any sense of the test dir in the source code, probably for
lack of knowledge, not because of lack of sense;-)

Could you point me to some documentation on testing the sup team is
using?

Yours, Ruthard

-- 

Dr. Ruthard Baudach
Speckertsweg 36a
97209 Veitshöchheim
----

Emails bitte verschlüsseln und signieren.
Meine PGP-Id: AC5AC6C2