If I am not mistaken, both RFC4155 and
http://www.qmail.org/man/man5/mbox.html
specify that an mbox entry is *terminated* by a blank line.

line 117 -124 of lib/sup/mbox.rb reads:

  def store_message date, from_email, &block
    need_blank = File.exists?(@path) && !File.zero?(@path)
    File.open(@path, "ab") do |f|
      f.puts if need_blank
      f.puts "From #{from_email} #{date.asctime}"
      yield f
    end
  end

As far as I understand this, sup puts a blank line *before* the
separator line except for the first message.

My old sent.mbox is terminated by the last line of the last message, my
old inbox.mbox is terminated by a blank line.

If I'm not mistaken, this could lead to problems, if the same mbox would
be fed by sup and another MDA, e.g. if someone would use the same mbox
for in- and outgoing mail (as I did when I had to setup sup anew after
upgrading to 0.15. Changing to maildir simultaneously safed me from this
bug. Huh!)

Changing the lines 117 - 124 of lib/sup/mbox.rb to

  def store_message date, from_email, &block
    File.open(@path, "ab") do |f|
      f.puts "From #{from_email} #{date.asctime}"
      yield f
      f.puts
    end
  end

would take care of this.

Do you agree?

Shall I submit a patch?

O – of course this would break existing setups with wrong formatted
mboxes.

Hmmmmmm???? 

Yours,

Ruthard

-- 

Please encrypt and sign emails.
My PGP-Id: AC5AC6C2