From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 212305182720 X-Google-Groups: supmua X-Google-Thread: 3030fda1bf,b742d692b79b2026 X-Google-Attributes: gid3030fda1bf,domainid0,public,googlegroup X-Google-NewGroupId: yes X-Received: by 10.181.28.169 with SMTP id jp9mr399067wid.6.1411475406430; Tue, 23 Sep 2014 05:30:06 -0700 (PDT) X-BeenThere: supmua@googlegroups.com Received: by 10.152.6.134 with SMTP id b6ls38198laa.77.gmail; Tue, 23 Sep 2014 05:30:05 -0700 (PDT) X-Received: by 10.152.26.225 with SMTP id o1mr400121lag.4.1411475405784; Tue, 23 Sep 2014 05:30:05 -0700 (PDT) Return-Path: Received: from mout.web.de (mout.web.de. [212.227.17.12]) by gmr-mx.google.com with ESMTPS id fa3si1898959lbc.0.2014.09.23.05.30.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Sep 2014 05:30:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ruthard.baudach@web.de designates 212.227.17.12 as permitted sender) client-ip=212.227.17.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ruthard.baudach@web.de designates 212.227.17.12 as permitted sender) smtp.mail=ruthard.baudach@web.de Received: from localhost ([188.98.11.236]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0Lz3FM-1YIqzt0dM0-014ExQ for ; Tue, 23 Sep 2014 14:30:05 +0200 From: Ruthard Baudach To: supmua Subject: Re: [sup] ask_* functions from buffer.rb In-reply-to: <1411319537-astroid-0-fvayndb6xh-21321@strange> References: <1411313665-sup-8457@ruthard-lappi> <1411319537-astroid-0-fvayndb6xh-21321@strange> Date: Tue, 23 Sep 2014 14:20:50 +0200 Message-Id: <1411474662-sup-1726@ruthard-lappi> User-Agent: Sup/0.19.0 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; boundary="=-1411474853-576197-19885-2499-2-=" X-Provags-ID: V03:K0:+LmX7xc/NG1ruTe2wFWSCzu7GugDzEF4M9ijnzCKFDWajSSBANt cJe8IVERFqxoTK8VKHbCM8M9v/tMOG+Yg4sAgGgvy+JMwWbtttDz33InHJF1Ysrb30w8Brl ViNX09A158l0yIhM7ztkqMJOPw3+gBsOP/tt6CWpM6Sl0PsWuKrgilnZ1MSfqbL4vzL6oIj sGR2I+uhzX6qEtOuKg79w== X-UI-Out-Filterresults: notjunk:1; --=-1411474853-576197-19885-2499-2-= Content-Type: multipart/mixed; boundary="=-1411474850-184112-19885-7198-1-=" MIME-Version: 1.0 --=-1411474850-184112-19885-7198-1-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Dear Gaute, Warning! I never made patches before, so have a close look on this one before messing anything up. Attached is my first attempt at creating a patch for sup/lib/sup/buffer.rb adding a comment for the dialog functions >=3D=3D Ausz=C3=BCge aus der Nachricht von Gaute Hope vom 2014-09-21 19:= 14: > Excerpts from Ruthard Baudach's message of September 21, 2014 17:34: > > The ask* functions in buffer.rb are not commented. As far as I found > > out, the arguments are: > > = > > domain: token used as key for @textfields, which seems to be a > > dictionary of input field objects > > question: string used as prompt > > completions: array of possible answers, that can be completed by usin= g > > the tab key > > default: default value to return > > = > > Is this correct? > = > Most likely. > = > Correct me if I am wrong, but I don't think any of the active sup devs > were involved in writing those functions :) I would happily accept a > patch with some comments. > = > Cheers, Gaute > = --=-1411474850-184112-19885-7198-1-= Content-Disposition: attachment; filename="buffer.rb-comment.diff" Content-Type: application/octet-stream; name="buffer.rb-comment.diff" Content-Transfer-Encoding: base64 ZGlmZiAtTmF1ciBzdXAvbGliL3N1cC9idWZmZXIucmIgbXktc3VwL2xpYi9z dXAvYnVmZmVyLnJiCi0tLSBzdXAvbGliL3N1cC9idWZmZXIucmIJMjAxNC0w OS0yMyAxMzo1MzoxNi43MjMzODI2NjUgKzAyMDAKKysrIG15LXN1cC9saWIv c3VwL2J1ZmZlci5yYgkyMDE0LTA5LTIzIDE0OjE0OjU4LjE5MDEzMTk4MiAr MDIwMApAQCAtMzk2LDYgKzM5NiwyMCBAQAogICAgIGVuZAogICBlbmQKIAor ICAjIyBhc2sqIGZ1bmN0aW9ucy4gdGhlc2UgZnVuY3Rpb25zIGRpc3BsYXkg YSBvbmUtbGluZSB0ZXh0IGZpZWxkIHdpdGgKKyAgIyMgYSBwcm9tcHQgYXQg dGhlIGJvdHRvbSBvZiB0aGUgc2NyZWVuLiBhbnN3ZXJzIHR5cGVkIG9yIGNo b29zZW4gYnkKKyAgIyMgdGFiLWNvbXBsZXRpb24gCisgICMjCisgICMjIGNv bW1vbiBhcmd1bWVudHMgYXJlOgorICAjIworICAjIyBkb21haW46ICAgICAg dG9rZW4gdXNlZCBhcyBrZXkgZm9yIEB0ZXh0ZmllbGRzLCB3aGljaCBzZWVt cyB0byBiZSBhCisgICMjICAgICAgICAgICAgICBkaWN0aW9uYXJ5IG9mIGlu cHV0IGZpZWxkIG9iamVjdHMKKyAgIyMgcXVlc3Rpb246ICAgIHN0cmluZyB1 c2VkIGFzIHByb21wdAorICAjIyBjb21wbGV0aW9uczogYXJyYXkgb2YgcG9z c2libGUgYW5zd2VycywgdGhhdCBjYW4gYmUgY29tcGxldGVkIGJ5IHVzaW5n CisgICMjICAgICAgICAgICAgICB0aGUgdGFiIGtleQorICAjIyBkZWZhdWx0 OiAgICAgZGVmYXVsdCB2YWx1ZSB0byByZXR1cm4KKworCiAgIGRlZiBhc2tf d2l0aF9jb21wbGV0aW9ucyBkb21haW4sIHF1ZXN0aW9uLCBjb21wbGV0aW9u cywgZGVmYXVsdD1uaWwKICAgICBhc2sgZG9tYWluLCBxdWVzdGlvbiwgZGVm YXVsdCBkbyB8c3wKICAgICAgIHMuZml4X2VuY29kaW5nIQo= --=-1411474850-184112-19885-7198-1-=-- --=-1411474853-576197-19885-2499-2-= Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUIWWlAAoJEA852hysWsbC/h8H/0uey/QtQ6T9iVtYRFIrj/3k FhpTlltz2uK1SDiL3Jh1i/GcZPzOMPdX5yu5djOdWYHdpJb6wXWFF0WQDV8LMqV+ KJFTb4ch/9tNAVa99tzXNpr14It3vhmfNV4RKEMSysjr2ZzmqDViCL+AIpmoOkP8 2n9vAFyA1L4rsQLfEGFooo2zMimYrZBbClOxoAzmy+cW1SiFhYa5Vw8r61vlxXpw M12O+lOGAX+tBngbVLDtb0+Roi50M8eFjbcoRelYMP2ulVRPYwwIY3iNMW5v+wYu czi5vPwE9J6g3G1fH8IwISvbjtTVb4jRhqM8X1rRr5Yfr3v7QhVR+sGyAYLSkHo= =0Vsl -----END PGP SIGNATURE----- --=-1411474853-576197-19885-2499-2-=--