Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: bdwalton@gmail.com (Ben Walton)
Subject: [sup-talk] [PATCH] exception when editting empty Cc header in edit-message-mode
Date: Fri, 16 May 2008 13:00:27 -0400	[thread overview]
Message-ID: <f96e0240805161000nce9b344ref2454b0004d4df7@mail.gmail.com> (raw)

Hi All,

I bumped into this today and crafted the following small patch
(against the current head of next) to handle it.  If you press 'c' to
edit a Cc header (would happen on To or Bcc also), an exception is
generated if the field is currently empty.  Array.join is called on
nil.  The attached patch just sets the header value to an empty array
before the call to join happens.

-Ben
-- 
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <bdwalton at gmail.com>

When one person suffers from a delusion, it is called insanity. When
many people suffer from a delusion it is called Religion.
Robert M. Pirsig, Zen and the Art of Motorcycle Maintenance

---------------------------------------------------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-fix-exception-when-editting-an-empty-MULTI_HEADER.patch
Type: text/x-diff
Size: 986 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20080516/26d8c10e/attachment.bin>


             reply	other threads:[~2008-05-16 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16 17:00 Ben Walton [this message]
2008-05-19 21:40 ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f96e0240805161000nce9b344ref2454b0004d4df7@mail.gmail.com \
    --to=bdwalton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox