From: tom@dbservice.com (Tomas Carnecky)
Subject: [sup-talk] sup on opensolaris
Date: Tue, 4 Aug 2009 11:56:11 +0200 [thread overview]
Message-ID: <F8547FC4-8D0A-40AB-9604-7CB49BED27EC@dbservice.com> (raw)
In-Reply-To: <1249059559-sup-8960@matrix>
I hate mailing lists that force me to subscribe. Luckily I have a
friend who was already subscribed and forwarded me the emails.
>
>> I have an ugly patch for lib/sup/textfield.rb that uses its own
>> string
>> buffer instead of relying on field_buffer(). It's not perfect, but it
>> at least allows me to write emails and assign tags.
>
> If it's not too much work to clean up, I'd be interested in this
> patch.
> The field buffer stuff is broken in weird ways anyways (the history
> never seems to be quite right), and anything that reduces the reliance
> on ncurses is always the right approach.
I never programed in ruby before and I don't intend to learn it. Feel
free to look at the last commit in the solaris-fixes:curses-form-
buffer branch. It is the simplest possible solution to the problem at
hand that didn't require me to learn too much ruby. It still needs a
considerable amount of work before it is useful (like, being able to
delete characters in the stringio buffer etc). I'm not planing to work
on the patch in the foreseeable future, but someone else might find
the patch useful as a starting point.
>
>> - strftime("%P") is a GNU extension, I work around this by using
>> strftime("%p").downcase.
>
> Submit a patch! I'm fine with this.
>
>> - Iconv.iconv(target + "//IGNORE", charset, text + " ") <- the "//
>> IGNORE" is causing an InvalidEncoding exception, removing it didn't
>> seem to cause any regressions
>
> Hm, this is a trickier one. Allegedly the //IGNORE reduces the
> exceptions thrown by Iconv, but since we're catching them all anyways,
> we might be able to get away with removing this. Or we could
> special-case it to your arch.
Both patches are available in the solaris-fixes master branch.
tom
next parent reply other threads:[~2009-08-04 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1249059559-sup-8960@matrix>
2009-08-04 9:56 ` Tomas Carnecky [this message]
2009-07-30 18:31 Tomas Carnecky
2009-07-31 15:56 ` William Morgan
2009-07-31 16:59 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F8547FC4-8D0A-40AB-9604-7CB49BED27EC@dbservice.com \
--to=tom@dbservice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox