From mboxrd@z Thu Jan  1 00:00:00 1970
From: brabuhr@gmail.com (brabuhr at gmail.com)
Date: Fri, 8 Feb 2008 21:01:31 -0500
Subject: [sup-talk] [PATCH] first pass at a simple interface to extract
	URIs from a message
In-Reply-To: <1202007092-sup-19@south>
References: <21aa9f0801291923w2df946dbga7832a7345c09a95@mail.gmail.com>
	<1202007092-sup-19@south>
Message-ID: <55fa96700802081801mfc27b6axd68a3d640175dddd@mail.gmail.com>

On Feb 2, 2008 9:56 PM, William Morgan <wmorgan-sup at masanjin.net> wrote:
> Reformatted excerpts from brabuhr's message of 2008-01-29:
> > This adds a new key binding to the thread-view mode (L) to assist with
> > loading URIs from the body of the message.  This first pass will pull
> > the URIs from the message text and loop through them while asking if
> > that URI should be loaded.  Currently, there is no code to actually
> > perform the load.
>
> Looks good. I have a slight preference for a "if uris.size == 0" block
> that flashes a message and returns, so that the meat of the method
> doesn't have to be too indented.

I was also thinking that it would be better to display the discovered URIs
in a list instead of the prompting, but I wasn't sure how to implement that.
Another problem I see is that the extractor is too-greedy and will pull in
the punctuation following the URL; so, perhaps the list should allow
line editing before calling the view-url hook?