From: brabuhr@gmail.com (brabuhr at gmail.com)
Subject: [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message
Date: Fri, 8 Feb 2008 21:01:31 -0500 [thread overview]
Message-ID: <55fa96700802081801mfc27b6axd68a3d640175dddd@mail.gmail.com> (raw)
In-Reply-To: <1202007092-sup-19@south>
On Feb 2, 2008 9:56 PM, William Morgan <wmorgan-sup at masanjin.net> wrote:
> Reformatted excerpts from brabuhr's message of 2008-01-29:
> > This adds a new key binding to the thread-view mode (L) to assist with
> > loading URIs from the body of the message. This first pass will pull
> > the URIs from the message text and loop through them while asking if
> > that URI should be loaded. Currently, there is no code to actually
> > perform the load.
>
> Looks good. I have a slight preference for a "if uris.size == 0" block
> that flashes a message and returns, so that the meat of the method
> doesn't have to be too indented.
I was also thinking that it would be better to display the discovered URIs
in a list instead of the prompting, but I wasn't sure how to implement that.
Another problem I see is that the extractor is too-greedy and will pull in
the punctuation following the URL; so, perhaps the list should allow
line editing before calling the view-url hook?
next prev parent reply other threads:[~2008-02-09 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 3:23 brabuhr
2008-02-03 2:56 ` William Morgan
2008-02-09 2:01 ` brabuhr at gmail.com [this message]
2008-02-16 20:04 ` William Morgan
2008-02-16 20:06 ` [sup-talk] [PATCH] add URL extraction, listing, and viewing capabilities to ThreadViewMode William Morgan
2008-02-18 23:24 ` [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message Nicolas Pouillard
2008-02-19 3:12 ` Daniel Wagner
2008-02-19 10:17 ` Nicolas Pouillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fa96700802081801mfc27b6axd68a3d640175dddd@mail.gmail.com \
--to=brabuhr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox