* [sup-talk] patch with keymaps for editing message headers
@ 2007-10-11 16:19 Eyal Oren
2007-11-02 2:18 ` William Morgan
[not found] ` <320c39cf00151583@IMSS-WIN>
0 siblings, 2 replies; 4+ messages in thread
From: Eyal Oren @ 2007-10-11 16:19 UTC (permalink / raw)
Attached another small patch, adding keymaps to edit 'To:', 'Cc:', and
'Subject:' field of messages. Again something small that I missed, coming from
Mutt.
Please let me know if you don't like my coding style (it feels very stupid,
jumping fields this way, but I couldn't quickly see how to do it better), or if
you don't like these kind of added features.
-eyal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: keymap-for-to-cc-subject.patch
Type: application/octet-stream
Size: 1480 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20071011/f2866c63/attachment.obj
^ permalink raw reply [flat|nested] 4+ messages in thread* [sup-talk] patch with keymaps for editing message headers
2007-10-11 16:19 [sup-talk] patch with keymaps for editing message headers Eyal Oren
@ 2007-11-02 2:18 ` William Morgan
[not found] ` <320c39cf00151583@IMSS-WIN>
1 sibling, 0 replies; 4+ messages in thread
From: William Morgan @ 2007-11-02 2:18 UTC (permalink / raw)
Excerpts from Eyal Oren's message of Thu Oct 11 09:19:17 -0700 2007:
> Attached another small patch, adding keymaps to edit 'To:', 'Cc:', and
> 'Subject:' field of messages. Again something small that I missed,
> coming from Mutt.
Applied, thanks!
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <320c39cf00151583@IMSS-WIN>]
* [sup-talk] patch with keymaps for editing message headers
[not found] ` <320c39cf00151583@IMSS-WIN>
@ 2007-11-02 12:55 ` Marcus Williams
2007-11-02 15:23 ` William Morgan
0 siblings, 1 reply; 4+ messages in thread
From: Marcus Williams @ 2007-11-02 12:55 UTC (permalink / raw)
On 02/11/2007 William Morgan wrote:
> Excerpts from Eyal Oren's message of Thu Oct 11 09:19:17 -0700 2007:
> > > Attached another small patch, adding keymaps to edit 'To:', 'Cc:', and
> > > 'Subject:' field of messages. Again something small that I missed,
> > > coming from Mutt.
>
> Applied, thanks!
This adds a method in edit-message-mode called "edit_field" with 1
argument. reply-mode has an edit_field method that overrides this if you
are replying so you get an exception as it gets called instead when you
try to edit the field in reply mode.
It doesnt look like the reply mode edit_field method gets used anywhere
so this might need to be removed or the edit-message-mode method needs
renaming perhaps.
Marcus
^ permalink raw reply [flat|nested] 4+ messages in thread* [sup-talk] patch with keymaps for editing message headers
2007-11-02 12:55 ` Marcus Williams
@ 2007-11-02 15:23 ` William Morgan
0 siblings, 0 replies; 4+ messages in thread
From: William Morgan @ 2007-11-02 15:23 UTC (permalink / raw)
Excerpts from Marcus Williams's message of Fri Nov 02 05:55:15 -0700 2007:
> This adds a method in edit-message-mode called "edit_field" with 1
> argument. reply-mode has an edit_field method that overrides this if
> you are replying so you get an exception as it gets called instead
> when you try to edit the field in reply mode.
Good catch. I renamed the original EditMessageMode#edit_field method
(which ReplyMode overrode) to edit_field_or_message, and forgot to check
subclasses.
Who needs unit tests when you have enough users pulling the SVN head?
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-02 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-11 16:19 [sup-talk] patch with keymaps for editing message headers Eyal Oren
2007-11-02 2:18 ` William Morgan
[not found] ` <320c39cf00151583@IMSS-WIN>
2007-11-02 12:55 ` Marcus Williams
2007-11-02 15:23 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox