Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: marcus-sup@quintic.co.uk (Marcus Williams)
Subject: [sup-talk] tiny fix for sup-faked message id's crashing sup-sync
Date: Fri, 02 Nov 2007 10:01:16 +0000	[thread overview]
Message-ID: <472AF56C.5070807@quintic.co.uk> (raw)
In-Reply-To: <321bb12900151bd3@IMSS-WIN>

On 02/11/2007 William Morgan wrote:
> > I hate it when I add a puts or logging statement and it messes up
> > > ruby's returning conventions, returning nil that clobbers something
> > > elsewhere. Glad to see it happens to other people too :)
> 
> Ruby is flawless. I am to blame. Applied, thanks!

... you may want to remove the @id from the log message - wont this 
always be nil at this point (as it gets assigned by this block)?

Marcus


  parent reply	other threads:[~2007-11-02 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30  1:55 Brendan O'Connor
2007-11-02  2:35 ` William Morgan
     [not found] ` <321bb12900151bd3@IMSS-WIN>
2007-11-02 10:01   ` Marcus Williams [this message]
2007-11-02 15:17     ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472AF56C.5070807@quintic.co.uk \
    --to=marcus-sup@quintic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox