From: marcus-sup@quintic.co.uk (Marcus Williams)
Subject: [sup-talk] Seen flag treated incorrectly on IMAP mail
Date: Thu, 01 Nov 2007 09:10:26 +0000 [thread overview]
Message-ID: <47299802.50007@quintic.co.uk> (raw)
In-Reply-To: <2d4a3f900012fe89@IMSS-WIN>
On 31/10/2007 Colin Bell wrote:
> I think its caused by this code in each(...) in imap.rb
>
> labels = { :Seen => :unread,
> :Flagged => :starred,
> :Deleted => :deleted
> }.inject(@labels) do |cur, (imap, sup)|
> cur + (state[:flags].include?(imap) ? [sup] : [])
>
> This seems (to my non-existent Ruby skills) to be equating the IMAP
> Seen flag to be the same as the Sup Unread flag, instead of Seen as
> being Not Unread.
Yep, I submitted a patch earlier last month (search for imap patch) to
fix this although what it did was use the /Recent flag to check for
unread messages. This works as long as you dont use the IMAP source in
any other client before sup checks for new messages.
In reality what it should be checking for is the lack of the /Seen flag.
That requires a patch to the sources generally so they can work out if
they've been read or not (included in my patch). I've also got some
further tweaks to the patch locally that I'll submit once I've tested
them a bit more.
Marcus
next parent reply other threads:[~2007-11-01 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2d4a3f900012fe89@IMSS-WIN>
2007-11-01 9:10 ` Marcus Williams [this message]
2007-11-01 22:09 ` Colin Bell
2007-10-31 2:12 Colin Bell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47299802.50007@quintic.co.uk \
--to=marcus-sup@quintic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox