From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcus-sup@quintic.co.uk (Marcus Williams) Date: Thu, 25 Oct 2007 13:35:23 +0100 Subject: [sup-talk] [PATCH] Fix for imap based sources In-Reply-To: <0ae09eda00048831@IMSS-WIN> References: <0ae09eda00048831@IMSS-WIN> Message-ID: <47208D8B.1060503@quintic.co.uk> On 25/10/2007 I wrote: > It also fixes what I think is a bug in the imap sup source - the imap > "/Seen" flag means a message has been read from the way I interpret the > RFC, the "/Recent" flag is what you need to check for "unreadness". ... which means I should probably be using it in the imap marked_read? as well. So the marked_read? method in imap.rb should probably be: def marked_read? id return @imap_state[id][:flags].include?(:Seen) end Note that I've removed the leading ! operator as well. Marcus