Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: marcus-sup@quintic.co.uk (Marcus Williams)
Subject: [sup-talk] [PATCH] Fix for imap based sources
Date: Thu, 25 Oct 2007 13:35:23 +0100	[thread overview]
Message-ID: <47208D8B.1060503@quintic.co.uk> (raw)
In-Reply-To: <0ae09eda00048831@IMSS-WIN>

On 25/10/2007 I wrote:
> It also fixes what I think is a bug in the imap sup source - the imap
> "/Seen" flag means a message has been read from the way I interpret the
> RFC, the "/Recent" flag is what you need to check for "unreadness".

... which means I should probably be using it in the imap marked_read?
as well. So the marked_read? method in imap.rb should probably be:

  def marked_read? id
    return @imap_state[id][:flags].include?(:Seen)
  end

Note that I've removed the leading ! operator as well.

Marcus


       reply	other threads:[~2007-10-25 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0ae09eda00048831@IMSS-WIN>
2007-10-25 12:35 ` Marcus Williams [this message]
2007-10-25 10:25 Marcus Williams
2007-11-02  0:14 ` Ian Taylor
2007-11-02  1:19   ` Colin Bell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47208D8B.1060503@quintic.co.uk \
    --to=marcus-sup@quintic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox