From: marcus-sup@quintic.co.uk (Marcus Williams)
Subject: [sup-talk] [PATCH] Fix for imap based sources
Date: Thu, 25 Oct 2007 11:25:39 +0100 [thread overview]
Message-ID: <47206F23.6080400@quintic.co.uk> (raw)
Hi -
Apply this one at your peril. This patch makes the unread status
correct on sources that arent mbox - unfortunately I cant test on
Maildir so if someone wants to confirm it still works that would be
good :)
If you implement a new source, it means you now have to add a
marked_read? method to your source as well. Argument is a message id.
message.rb now calls this when source_marked_read is called.
It also fixes what I think is a bug in the imap sup source - the imap
"/Seen" flag means a message has been read from the way I interpret the
RFC, the "/Recent" flag is what you need to check for "unreadness".
This fixes my problem with imap (in that all new messages were getting
marked as read). To get just this fix all you have to do is replace Seen
for Recent in the imap.rb. The line currently looks like:
labels = { :Seen => :unread,
and it should be
labels = { :Recent => :unread,
Marcus
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: imap-diffs
Url: http://rubyforge.org/pipermail/sup-talk/attachments/20071025/f4d9e120/attachment.pl
next reply other threads:[~2007-10-25 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 10:25 Marcus Williams [this message]
2007-11-02 0:14 ` Ian Taylor
2007-11-02 1:19 ` Colin Bell
[not found] <0ae09eda00048831@IMSS-WIN>
2007-10-25 12:35 ` Marcus Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47206F23.6080400@quintic.co.uk \
--to=marcus-sup@quintic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox