From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.42.218.138 with SMTP id hq10cs42480icb; Wed, 22 Dec 2010 06:50:24 -0800 (PST) Received: by 10.229.232.133 with SMTP id ju5mr6176182qcb.221.1293029423718; Wed, 22 Dec 2010 06:50:23 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id k9si12530864qct.8.2010.12.22.06.50.23; Wed, 22 Dec 2010 06:50:23 -0800 (PST) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 4F743167832E; Wed, 22 Dec 2010 09:50:23 -0500 (EST) Received: from gateway0.EECS.Berkeley.EDU (gateway0.EECS.Berkeley.EDU [169.229.60.87]) by rubyforge.org (Postfix) with ESMTP id 7857A1858387 for ; Wed, 22 Dec 2010 09:34:45 -0500 (EST) Received: from icsi.berkeley.edu (samurai.ICIR.org [192.150.187.48]) (authenticated bits=0) by gateway0.EECS.Berkeley.EDU (8.14.4/8.13.5) with ESMTP id oBMEYfYA015335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 22 Dec 2010 06:34:43 -0800 (PST) Date: Wed, 22 Dec 2010 06:34:41 -0800 From: Matthias Vallentin To: Tero Tilus Message-ID: <20101222143441.GF60419@icsi.berkeley.edu> References: <20101221071230.GE60419@icsi.berkeley.edu> <1292928629-sup-4367@tilus.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1292928629-sup-4367@tilus.net> X-PGP-Fingerprint: 8A3B 1323 B469 CCBA 54D3 3BCC D5E7 8DF5 9C8D 4B41 User-Agent: Mutt/1.5.20 (2009-06-14) Cc: sup-talk Subject: Re: [sup-talk] Maildir sent_source X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org On Tue, Dec 21, 2010 at 12:56:23PM +0200, Tero Tilus wrote: > I do see it. ;) Yeah, me too now :-). > Judging by the code it looks like you also need to sup-add your > maildir in addition to adding it to config. If > Redwood::SourceManager.source_for doesn't find the source it silently > drops back to default sent source. IMO it should complain about > invalid config or something. I agree, this inconsistency should not go through without flagging it and terminating with an error. Alternatively, the patch below would allow for adding a maildir source before the default logic kicks in. Matthias --- a/bin/sup +++ b/bin/sup @@ -158,6 +158,9 @@ begin trap("TERM") { |x| $die = true } trap("WINCH") { |x| BufferManager.sigwinch_happened! } + HookManager.run "startup" + Redwood::Keymap.run_hook global_keymap + if(s = Redwood::SourceManager.source_for DraftManager.source_name) DraftManager.source = s else @@ -171,9 +174,6 @@ begin Redwood::SourceManager.add_source SentManager.default_source end - HookManager.run "startup" - Redwood::Keymap.run_hook global_keymap - debug "starting curses" Redwood::Logger.remove_sink $stderr start_cursing _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk