From: Matthias Vallentin <vallentin@icsi.berkeley.edu>
To: Tero Tilus <tero@tilus.net>
Cc: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] Maildir sent_source
Date: Wed, 22 Dec 2010 06:34:41 -0800 [thread overview]
Message-ID: <20101222143441.GF60419@icsi.berkeley.edu> (raw)
In-Reply-To: <1292928629-sup-4367@tilus.net>
On Tue, Dec 21, 2010 at 12:56:23PM +0200, Tero Tilus wrote:
> I do see it. ;)
Yeah, me too now :-).
> Judging by the code it looks like you also need to sup-add your
> maildir in addition to adding it to config. If
> Redwood::SourceManager.source_for doesn't find the source it silently
> drops back to default sent source. IMO it should complain about
> invalid config or something.
I agree, this inconsistency should not go through without flagging it
and terminating with an error.
Alternatively, the patch below would allow for adding a maildir source
before the default logic kicks in.
Matthias
--- a/bin/sup
+++ b/bin/sup
@@ -158,6 +158,9 @@ begin
trap("TERM") { |x| $die = true }
trap("WINCH") { |x| BufferManager.sigwinch_happened! }
+ HookManager.run "startup"
+ Redwood::Keymap.run_hook global_keymap
+
if(s = Redwood::SourceManager.source_for DraftManager.source_name)
DraftManager.source = s
else
@@ -171,9 +174,6 @@ begin
Redwood::SourceManager.add_source SentManager.default_source
end
- HookManager.run "startup"
- Redwood::Keymap.run_hook global_keymap
-
debug "starting curses"
Redwood::Logger.remove_sink $stderr
start_cursing
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
next prev parent reply other threads:[~2010-12-22 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 7:12 Matthias Vallentin
2010-12-21 10:56 ` Tero Tilus
2010-12-22 14:34 ` Matthias Vallentin [this message]
2010-12-22 17:14 ` Matthias Vallentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222143441.GF60419@icsi.berkeley.edu \
--to=vallentin@icsi.berkeley.edu \
--cc=sup-talk@rubyforge.org \
--cc=tero@tilus.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox