Re: [sup-talk] PGP INLINE - can't make it work

From: piotr.kempa@wp.eu
To: sup-talk@rubyforge.org
Subject: Re: [sup-talk] PGP INLINE - can't make it work
Date: Mon, 8 Mar 2010 11:29:47 +0100	[thread overview]
Message-ID: <201003081129.47648.piotr.kempa@wp.eu> (raw)
In-Reply-To: <201003081118.55543.piotr.kempa@wp.eu>

On Monday 08 March 2010 11:18:55 piotr.kempa@wp.eu wrote:
> On Tuesday 02 March 2010 15:19:23 piotr.kempa@wp.eu wrote:
> > Sounds cool, I can't wait then. Let's hope the patch is included in 0.11. 
> > Thanks Michael!
> > Piotr
> > 
> > On Tuesday 02 March 2010 14:59:19 Michael Stapelberg wrote:
> > > Hi Piotr,
> > > 
> > > Excerpts from piotr.kempa's message of Di Mär 02 11:49:59 +0100 2010:
> > > > So, I guess if this functionality is to be included in sup (and I 
think 
> it 
> > > > doesn't have to be since enigmail just makes broken messages and 
there's 
> > no 
> > > > reason why anybody should put up with that:) it should not be in 
> crypto.rb 
> > but 
> > > > somewhere else, where the decision is made to even use functions from 
> > > > crypto.rb (like decrypt) on a message. I'm no programmer but I guess 
it 
> > should 
> > > As mentioned, I wrote a patch to do this. It is currently in review and 
> will
> > > hopefully be included soon.
> > > 
> 
> Can anyone confirm if this patch made it to 0.11? I just installed the new 
> version and it still doesn't work but if it's there then maybe I'm doing 
> something wrong. If it didn't, is it posted anywhere? I'll be happy to patch 
> 0.11 myself instead of waiting for the next version. I really, really want 
to 
> start using sup :)
> 
> Thank you, 
> Piotr
> 
Okay, I found the patch here: http://www.mail-archive.com/sup-
talk@rubyforge.org/msg02770.html

And it is included in 0.11, I just checked in the code. 

However, this still doesn't work because the header doesn't contain Content 
Type = application/pgp, it is text/plain, which is absolutely crazy and I have 
no idea what the enigmail developers are thinking... Anyway, here's how it 
looks like (only the important part):

X-Enigmail-Version: 0.95.7
Content-Type: text/plain;
  charset=UTF-8
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP MESSAGE-----
Charset: UTF-8
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
=20
hQIOA3WKxDKSmLd7EAf9GP5JLA77IcGOAUrOZ8fGCEtK8Pm838Me+pMD94ulHlDS
LcidQKPSVGXaj4lLU8RqxoMKTpxuaZAm1u286C+SL9eQc51N3gH/X57loKhjCRb+
[...]

So in order to decide about encrypted content you actually have to look inside 
the body of the message, not just at the header. At least I couldn't find any 
indication in the headers :(

All in all, I wouldn't be surprised if you decided not to support such broken 
emails so I'll just go about learning enough ruby to patch it myself :)

Piotr
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk