From: dato@net.com.org.es (Adeodato Simó)
Subject: [sup-talk] [PATCH] mime-decode hook: provide a "charset" variable with the attachment charset
Date: Wed, 19 Aug 2009 22:22:09 +0100 [thread overview]
Message-ID: <20090819212209.GA10883@chistera.yi.org> (raw)
In-Reply-To: <20090730155656.GA20442@chistera.yi.org>
Ping?
+ Adeodato Sim? (Thu, 30 Jul 2009 17:56:56 +0200):
> + William Morgan (Mon, 27 Jul 2009 09:51:17 -0700):
> > Reformatted excerpts from Adeodato Sim?'s message of 2009-07-23:
> > > + Adeodato Sim? (Fri, 10 Jul 2009 17:00:29 +0200):
> > > > + :charset => encoded_content.charset,
> > > Hm, so apparently encoded_content doesn't always have a charset
> > > member...
> > In which case that value of that variable is nil, right? Is that a
> > problem? The patch still seems useful.
> Yes, I took a closer look and you're right the result of
> encoded_content.charset is nil in that case. I also saw (I think) where
> the traceback I was seeing is coming from: apparently it's not possible
> to pass to HookContext a local that is nil, since then "super" will get
> called in HookContext::method_missing() as far as I can see.
> So, perhaps, to fix this patch, one could do:
> :charset => encoded_content.charset || ''
> But then, I think it would be better to fix HookContext to allow for
> @__locals to contain nil. I'm not very familiar with that class, but it
> seems easy enough to fix, see upcoming patch (also found in
> ~dato/sup/sup-dato:fixes at Gitorious, if you prefer that). With it,
> this improvement to mime-decode seems to work without any further
> trouble.
> Cheers,
--
- Are you sure we're good?
- Always.
-- Rory and Lorelai
next prev parent reply other threads:[~2009-08-19 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 15:00 Adeodato Simó
2009-07-23 9:35 ` Adeodato Simó
2009-07-27 16:51 ` William Morgan
2009-07-30 15:56 ` Adeodato Simó
2009-07-30 15:57 ` [sup-talk] [PATCH] HookContext::method_missing(): allow locals to be nil Adeodato Simó
2009-08-19 21:22 ` Adeodato Simó [this message]
2009-08-22 18:15 ` [sup-talk] [PATCH] mime-decode hook: provide a "charset" variable with the attachment charset William Morgan
2009-08-22 19:16 ` Adeodato Simó
2009-08-23 17:34 ` William Morgan
2009-09-13 23:17 ` Adeodato Simó
2009-09-26 18:12 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819212209.GA10883@chistera.yi.org \
--to=dato@net.com.org.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox