From mboxrd@z Thu Jan 1 00:00:00 1970 From: dato@net.com.org.es (Adeodato =?utf-8?B?U2ltw7M=?=) Date: Fri, 7 Aug 2009 12:31:51 +0200 Subject: [sup-talk] sup ignoring SIGTERM? In-Reply-To: <1249609105-sup-5858@masanjin.net> References: <1249481294-sup-9967@chistera.yi.org> <1249502171-sup-8079@masanjin.net> <20090806183725.GA8363@chistera.yi.org> <1249609105-sup-5858@masanjin.net> Message-ID: <20090807103151.GA20799@chistera.yi.org> + William Morgan (Thu, 06 Aug 2009 18:38:53 -0700): > Reformatted excerpts from Adeodato Sim?'s message of 2009-08-06: > > Everything seems to work fine as of 3478e40, including sup terminating > > upon SIGTERM. If I may, I'd suggest normal termination instead of > > raising an exception. IMHO, it is expected that programs that capture > > SIGTERM, will do cleanup and exit normally, rather than behave as if > > an error had happened. > Good idea. Try it now. Ah, excellent: works as suggested now. Regarding 57dea7a (refactor index locking interaction and replace suicidemanager), I'll note that at least on my system, and after having moved to Xapian, those codepaths no longer execute. That is, if a sup is running and a second one is started, it never gets to ask whether to suggest dieing to the first one, because this second one dies with: [Fri Aug 07 12:31:05 +0200 2009] using character set encoding "UTF-8" [Fri Aug 07 12:31:05 +0200 2009] using index Redwood::XapianIndex [Fri Aug 07 12:31:05 +0200 2009] dynamically loading setlocale() from libc.so.6 [Fri Aug 07 12:31:05 +0200 2009] setting locale... .../lib/sup/xapian_index.rb:24:in `initialize': Resource temporarily unavailable - /home/adeodato/.sup/entries.db (Errno::EAGAIN) from .../lib/sup/xapian_index.rb:24:in `new' from .../lib/sup/xapian_index.rb:24:in `initialize' from .../bin/sup:132:in `new' from .../bin/sup:132 Thanks! -- - Are you sure we're good? - Always. -- Rory and Lorelai