From: stipim@rpi.edu (Michael John Stipicevic)
Subject: [sup-talk] (no subject)
Date: Mon, 16 Feb 2009 01:45:47 -0500 [thread overview]
Message-ID: <200902160645.n1G6jlqS003196@rmtacc26-la.rcs.rpi.edu> (raw)
From 1fd41c30189db832abb54f1cda416d0aa624e028 Mon Sep 17 00:00:00 2001
From: Mike Stipicevic <stipim at rpi.edu>
Date: Mon, 16 Feb 2009 00:11:28 -0500
Subject: [PATCH] Added undo for label edit
---
lib/sup/modes/thread-index-mode.rb | 27 +++++++++++++++++++++++++--
1 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 159839d..f28302b 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -509,6 +509,10 @@ EOS
def edit_labels
thread = cursor_thread or return
speciall = (@hidden_labels + LabelManager::RESERVED_LABELS).uniq
+
+ old_labels = thread.labels
+ pos = curpos
+
keepl, modifyl = thread.labels.partition { |t| speciall.member? t }
user_labels = BufferManager.ask_for_labels :label, "Labels for thread: ", modifyl, @hidden_labels
@@ -517,6 +521,15 @@ EOS
thread.labels = keepl + user_labels
user_labels.each { |l| LabelManager << l }
update_text_for_line curpos
+
+ undo = lambda{
+ thread.labels = old_labels
+ update_text_for_line pos
+ UpdateManager.relay self, :labeled, thread.first
+ }
+
+ UndoManager.register("labeling thread #{thread.first.id}", undo)
+
UpdateManager.relay self, :labeled, thread.first
end
@@ -526,8 +539,18 @@ EOS
hl = user_labels.select { |l| @hidden_labels.member? l }
if hl.empty?
- threads.each { |t| user_labels.each { |l| t.apply_label l } }
- user_labels.each { |l| LabelManager << l }
+ undo = threads.map { |t| old_labels = t.labels
+ user_labels.each { |l| t.apply_label l }
+ ## UpdateManager or some other regresh mechanism?
+ UpdateManager.relay self, :labeled, t.first
+ lambda {
+ t.labels = old_labels
+ UpdateManager.relay self, :labeled, t.first
+ }
+ }
+ user_labels.each { |l| LabelManager << l }
+ UndoManager.register("labeling #{threads.size} #{threads.size.pluralize 'thread'}",
+ undo << lambda { regen_text})
else
BufferManager.flash "'#{hl}' is a reserved label!"
end
--
1.5.3
next reply other threads:[~2009-02-16 6:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 6:45 Michael John Stipicevic [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-10 3:08 Jason O'Conal
2010-11-15 0:49 Matthias Vallentin
2010-11-15 1:42 ` Edward Z. Yang
2010-11-15 6:57 ` Matthias Vallentin
2010-11-15 8:06 ` Helge Titlestad
2010-11-20 19:04 ` Matthias Vallentin
2010-11-21 1:10 ` Tero Tilus
2010-11-21 1:51 ` Matthias Vallentin
2010-11-15 1:46 ` Ben Walton
2010-11-15 1:50 ` Matias Aguirre
2009-06-08 0:02 Ben Walton
2009-06-11 23:50 ` Ben Walton
2009-06-12 3:44 ` William Morgan
2009-06-12 13:15 ` Ben Walton
2009-06-12 18:23 ` William Morgan
2009-06-01 1:01 Ben Walton
2009-06-01 1:04 ` Ben Walton
2009-06-01 2:13 ` Ben Walton
2009-06-04 2:04 ` Ross Macduff
2009-02-16 6:45 Michael John Stipicevic
2009-02-16 6:45 Michael John Stipicevic
2009-02-16 6:45 Michael John Stipicevic
2009-02-16 6:45 Michael John Stipicevic
2009-02-16 6:45 Michael John Stipicevic
2009-02-16 6:45 Michael John Stipicevic
2009-02-16 6:44 Michael John Stipicevic
2009-02-16 6:27 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 8:53 ` Ian Smith
2009-02-16 14:08 ` William Morgan
2009-02-16 14:42 ` Mike Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2009-02-16 6:25 Michael John Stipicevic
2008-01-05 19:29 thefed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902160645.n1G6jlqS003196@rmtacc26-la.rcs.rpi.edu \
--to=stipim@rpi.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox