From: shot@hot.pl (Shot (Piotr Szotkowski))
Subject: [sup-talk] Util - Fixnum num_digits is wrong
Date: Mon, 3 Dec 2007 11:52:10 +0100 [thread overview]
Message-ID: <20071203105210.GO1974@durance.shot.pl> (raw)
In-Reply-To: <1196670157-sup-6857@silver>
Ian Taylor:
> class Fixnum
> def num_digits base=10
> return 1 if self == 0
> - 1 + (Math.log(self) / Math.log(10)).floor
> + 1 + (Math.log(self) / Math.log(base)).floor
> end
Math.log and Float#/ returning Floats means the above
approach is prone to the IEEE 754 representation inaccuracy.
Wouldn?t the below make more sense?
class Fixnum
def num_digits base = 10
to_s(base).size
end
end
-- Shot
--
> Who wants to recommend a Usenet reader for little ol' me?
I recommend Garrett Morris, particularly if you're hard-of-hearing.
-- jennifer friedoff and Joseph Nebus, rec.arts.tv.mst3k.misc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20071203/37b62dab/attachment.bin
next prev parent reply other threads:[~2007-12-03 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 8:25 Ian Taylor
2007-12-03 10:52 ` Shot (Piotr Szotkowski) [this message]
2007-12-08 22:13 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203105210.GO1974@durance.shot.pl \
--to=shot@hot.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox