From mboxrd@z Thu Jan  1 00:00:00 1970
From: magnus@therning.org (Magnus Therning)
Date: Sun, 16 Sep 2007 19:19:36 +0100
Subject: [sup-talk] Minor maildir change
In-Reply-To: <1189740088-sup-6296@south>
References: <20070909224034.GA3540@die.therning.org>
	<1189740088-sup-6296@south>
Message-ID: <20070916181936.GA5332@die.therning.org>

On Thu, Sep 13, 2007 at 20:33:04 -0700, William Morgan wrote:
>Excerpts from Magnus Therning's message of Sun Sep 09 15:40:34 -0700 2007:
[..]
>> I am somewhat puzzled by the labels one receives from Maildir::each,
>> it's the default labels for the source rather than the labels of the
>> actual message.
>
>It's supposed to be both sets of labels unioned together. The source
>defines any user labels the user wants to automatically apply to new
>messages (kind of a primitive filtering), and we mix these in with the
>labels that carry over the read/unread state, etc.

This is still confusing to me.

It's also a little strange that after a message is read it doesn't
necessarily end up with the correct set of labels.  Instead one has to
go to the index to get the proper set.

Another strange thing was that when using PollManager::add_messages_from
all my emails ended up being unread (according to the labels in the
message).  I tracked that down to it using the value of a header
("Status") to see whether a mail was read or not.  Is that something
that's used for mboxes?  (I've attached a patch that removes the code.)

This adds up to some smelliness IMHO.  I've done some thinking and I
think I'd like something like this:

 - A source has some default labels (including :archive).

 - A message is always loaded from a source so it'll get its labels from
   the source iff it's a new message.  If it's a known message it'll
   take its labels from the database.

 - Make all sets of labels actual sets.

Would this fit with the way the rest of sup works?

/M

-- 
Magnus Therning                             (OpenPGP: 0xAB4DFBA4)
magnus?therning?org             Jabber: magnus?therning?gmail?com
http://therning.org/magnus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sup-lblfix.diff
Type: text/x-diff
Size: 561 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20070916/6f2933e7/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20070916/6f2933e7/attachment-0001.bin