Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: magnus@therning.org (Magnus Therning)
Subject: [sup-talk] Tilde in maildir/mbox paths
Date: Fri, 14 Sep 2007 22:38:23 +0100	[thread overview]
Message-ID: <20070914213823.GA3321@die.therning.org> (raw)
In-Reply-To: <1189737312-sup-2958@south>

On Thu, Sep 13, 2007 at 19:45:56 -0700, William Morgan wrote:
>Hi Magnus,
>
>Excerpts from Magnus Therning's message of Fri Sep 07 00:37:21 -0700 2007:
>> I find it useful to be able to stick '~' in paths so here's an attempt
>> at a patch that allows a source with the URI maildir:~/mail/in.
>
>Thanks for the patch! What about modifying this slightly so that the
>~-expansion is done at the string level instead of the URI level, in a
>method called Source#expand_filesystem_uri or something. Then Maildir
>and MBox::Loader sticks the output of that method into URI.
>
>I think that change will solve two problems: it will make clear that
>the expansion method is filesystem-specific (i.e. even though the
>method is in Source, only filesystem sources want to call it), and it
>will allow us to support URIs the "right way", without the weird
>#opaque stuff and without dropping all mbox:// and maildir:// URLs.
>What do you think?

File.expand_path requires the tilde to be at the start of its argument,
so that prompted the strange #opaque stuff.  I made some changes and
stuck a modified patch in the attachment.  Let me know what you think.

/M

-- 
Magnus Therning                             (OpenPGP: 0xAB4DFBA4)
magnus?therning?org             Jabber: magnus?therning?gmail?com
http://therning.org/magnus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20070914/f67d4866/attachment.bin 


  reply	other threads:[~2007-09-14 21:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-07  7:37 Magnus Therning
     [not found] ` <20070907092109.GB23285@die.therning.org>
2007-09-07 18:47   ` Magnus Therning
2007-09-14  2:45 ` William Morgan
2007-09-14 21:38   ` Magnus Therning [this message]
2007-09-14 22:44     ` Magnus Therning
2007-09-15  3:41       ` William Morgan
2007-09-15 10:19         ` Magnus Therning
2007-09-17 17:30           ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070914213823.GA3321@die.therning.org \
    --to=magnus@therning.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox