* [sup-talk] Preparing for sup 0.13
@ 2011-10-16 12:09 Hamish D
2011-10-18 13:46 ` [sup-devel] " Mark Alexander
2011-10-19 14:31 ` [sup-devel] " Mark Alexander
0 siblings, 2 replies; 5+ messages in thread
From: Hamish D @ 2011-10-16 12:09 UTC (permalink / raw)
To: sup-talk, Sup developer discussion
I've merged the next branch into master in preparation for releasing
sup 0.13. So this is a call for people to try it out and report any
problems they have before we push it out the door. For basic details
about running from git see
http://sup.rubyforge.org/wiki/wiki.pl?Running_From_Git
The major changes since sup 0.12 are:
* crypto stuff rewritten to use the gpgme library, leading to smoother
operations with encrypted email.
* add an option for whether sent mail is archived
* added an account selector when composing email for those who have
multiple possible from addresses
* added an asynchronous edit mode - this allows you to carry on using
sup while composing a message in an external editor
along with various bug fixes large and small.
I'm hoping we can push out 0.13 in November.
Hamish
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-devel] [sup-talk] Preparing for sup 0.13
2011-10-16 12:09 [sup-talk] Preparing for sup 0.13 Hamish D
@ 2011-10-18 13:46 ` Mark Alexander
2011-10-18 17:58 ` Hamish D
2011-10-19 14:31 ` [sup-devel] " Mark Alexander
1 sibling, 1 reply; 5+ messages in thread
From: Mark Alexander @ 2011-10-18 13:46 UTC (permalink / raw)
To: Hamish D; +Cc: sup-talk, Sup developer discussion
Excerpts from Hamish D's message of Sun Oct 16 08:09:41 -0400 2011:
> * added an asynchronous edit mode - this allows you to carry on using
> sup while composing a message in an external editor
I'm not having much luck with this feature. I was able to write an
async-edit hook that spawned my editor in a separate gnome-terminal
window. But when I exited async-edit mode, sup started responding to
keystrokes weirdly. I tried to discard the message I had just
composed using 'x', so sup asked if I wanted to discard the message,
and when I hit 'y', it sent the message instead of discarding it.
After that, sup behaved as if every other keystroke was being
discarded, and I had to quit and restart.
Other than that, things look good.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-talk] Preparing for sup 0.13
2011-10-18 13:46 ` [sup-devel] " Mark Alexander
@ 2011-10-18 17:58 ` Hamish D
0 siblings, 0 replies; 5+ messages in thread
From: Hamish D @ 2011-10-18 17:58 UTC (permalink / raw)
To: Mark Alexander; +Cc: sup-talk, Sup developer discussion
On 18 October 2011 14:46, Mark Alexander <marka@pobox.com> wrote:
> Excerpts from Hamish D's message of Sun Oct 16 08:09:41 -0400 2011:
>> * added an asynchronous edit mode - this allows you to carry on using
>> sup while composing a message in an external editor
>
> I'm not having much luck with this feature. I was able to write an
> async-edit hook that spawned my editor in a separate gnome-terminal
> window. But when I exited async-edit mode, sup started responding to
> keystrokes weirdly. I tried to discard the message I had just
> composed using 'x', so sup asked if I wanted to discard the message,
> and when I hit 'y', it sent the message instead of discarding it.
> After that, sup behaved as if every other keystroke was being
> discarded, and I had to quit and restart.
Could you email me your hook so I can check if there is anything in it
that might cause trouble? I've used the mode myself a bit and not hit
that issue.
I guess it's not really a regression as the feature didn't exist in
sup 0.12, but would still be good to sort it out ...
Hamish
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-devel] [sup-talk] Preparing for sup 0.13
2011-10-16 12:09 [sup-talk] Preparing for sup 0.13 Hamish D
2011-10-18 13:46 ` [sup-devel] " Mark Alexander
@ 2011-10-19 14:31 ` Mark Alexander
2011-10-20 13:18 ` Mark Alexander
1 sibling, 1 reply; 5+ messages in thread
From: Mark Alexander @ 2011-10-19 14:31 UTC (permalink / raw)
To: Hamish D; +Cc: sup-talk, Sup developer discussion
Excerpts from Hamish D's message of Sun Oct 16 08:09:41 -0400 2011:
> * added an account selector when composing email for those who have
> multiple possible from addresses
I'm having a problem with this feature, too.
I have two main email accounts, one for personal email and one for
work email. My before-edit.rb hook figures out which account to use
as the sender (the "From" header) by looking at the recipients (the
"To" header). This worked with sup 0.12, but with 0.13 the sender is
changed back to the default as soon as I exit the editor.
I see that Sascha Silbe said something about this seven months ago:
> This one would possibly break my workflow. My From address is chosen in
> the before-edit hook based on the set of recipients. Since you only
> call before-edit once with headers_full as headers, whatever From
> address gets chosen for the initial reply mode will "stick".
Here's the sanitized before-edit.rb hook, in case that helps:
unless header["In-reply-to"]
if header["To"] =~ /widgets/
to = header["To"]
info "Sending as widgets, to = #{to}"
header["From"] = "Mark Alexander <marka@widgets.com>"
else
to = header["To"]
info "Sending as pobox, to = #{to}"
header["From"] = "Mark Alexander <marka@pobox.com>"
end
end
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-devel] [sup-talk] Preparing for sup 0.13
2011-10-19 14:31 ` [sup-devel] " Mark Alexander
@ 2011-10-20 13:18 ` Mark Alexander
0 siblings, 0 replies; 5+ messages in thread
From: Mark Alexander @ 2011-10-20 13:18 UTC (permalink / raw)
To: Mark Alexander; +Cc: sup-talk, Sup developer discussion
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Excerpts from Mark Alexander's message of Wed Oct 19 10:31:29 -0400 2011:
> Excerpts from Hamish D's message of Sun Oct 16 08:09:41 -0400 2011:
> > * added an account selector when composing email for those who have
> > multiple possible from addresses
>
> I'm having a problem with this feature, too.
>
> I have two main email accounts, one for personal email and one for
> work email. My before-edit.rb hook figures out which account to use
> as the sender (the "From" header) by looking at the recipients (the
> "To" header). This worked with sup 0.12, but with 0.13 the sender is
> changed back to the default as soon as I exit the editor.
I'm trying out the attached fix, and so far it seems to work.
it simply moves the calling of the before-edit hook before
the creation of the account selector.
[-- Attachment #2: before-edit.patch --]
[-- Type: application/octet-stream, Size: 877 bytes --]
diff --git a/lib/sup/modes/edit-message-mode.rb b/lib/sup/modes/edit-message-mode.rb
index 5947ffd..e60009f 100644
--- a/lib/sup/modes/edit-message-mode.rb
+++ b/lib/sup/modes/edit-message-mode.rb
@@ -116,6 +116,8 @@ EOS
@selector_label_width = 0
@async_mode = nil
+ HookManager.run "before-edit", :header => @header, :body => @body
+
# only show account selector if there is more than one email address
if $config[:account_selector] && AccountManager.user_emails.length > 1
## Duplicate e-mail strings to prevent a "can't modify frozen
@@ -144,7 +146,6 @@ EOS
end
add_selector @crypto_selector if @crypto_selector
- HookManager.run "before-edit", :header => @header, :body => @body
if @crypto_selector
HookManager.run "crypto-mode", :header => @header, :body => @body, :crypto_selector => @crypto_selector
end
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-20 13:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-16 12:09 [sup-talk] Preparing for sup 0.13 Hamish D
2011-10-18 13:46 ` [sup-devel] " Mark Alexander
2011-10-18 17:58 ` Hamish D
2011-10-19 14:31 ` [sup-devel] " Mark Alexander
2011-10-20 13:18 ` Mark Alexander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox