From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.52.101.196 with SMTP id fi4cs86673vdb; Thu, 14 Apr 2011 00:40:25 -0700 (PDT) Received: by 10.229.114.80 with SMTP id d16mr302283qcq.18.1302766824878; Thu, 14 Apr 2011 00:40:24 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id m13si2589320qcu.182.2011.04.14.00.40.24; Thu, 14 Apr 2011 00:40:24 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 0106C1858374; Thu, 14 Apr 2011 03:40:24 -0400 (EDT) Received: from steel.pruts.nl (pruts.nl [82.94.235.106]) by rubyforge.org (Postfix) with ESMTP id 11C421858374; Thu, 14 Apr 2011 03:39:50 -0400 (EDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by steel.pruts.nl (Postfix) with ESMTP id 3BFB6E20B6; Thu, 14 Apr 2011 09:39:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at pruts.nl Received: from steel.pruts.nl ([127.0.0.1]) by localhost (steel.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G0H9RNjTxzyH; Thu, 14 Apr 2011 09:39:44 +0200 (CEST) Received: by steel.pruts.nl (Postfix, from userid 1000) id 4E2BDE20C2; Thu, 14 Apr 2011 09:39:44 +0200 (CEST) From: Ico Doornekamp To: William Morgan In-reply-to: <1301257195-sup-9486@masanjin.net> References: <1301257195-sup-9486@masanjin.net> Date: Thu, 14 Apr 2011 09:39:44 +0200 Message-Id: <1302766464-sup-8275@pruts.nl> User-Agent: Sup/git Cc: sup-talk , sup-devel Subject: Re: [sup-talk] [sup-devel] sup v2 progress report X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org * On Sun Mar 27 22:41:59 +0200 2011, William Morgan wrote: > Heliotrope, the server component, is close to ready for a version 1 release. > You can find it at https://github.com/wmorgan/heliotrope/. Heliotrope (Actually Time.parse()) crashes on some illegaly formatted dates: /usr/lib/ruby/1.9.1/time.rb:137:in `apply_offset': undefined method `<' for nil:NilClass (NoMethodError) from /usr/lib/ruby/1.9.1/time.rb:197:in `make_time' from /usr/lib/ruby/1.9.1/time.rb:261:in `parse' from /home/ico/external/heliotrope/lib/heliotrope/message.rb:27:in `parse!' from bin/heliotrope-add:108:in `
' The date of the message was "Wed, 7 2005 22:55: 1 -0180". Fixed by adding a NoMethodError catch: diff --git a/lib/heliotrope/message.rb b/lib/heliotrope/message.rb index 1682062..d63e411 100644 --- a/lib/heliotrope/message.rb +++ b/lib/heliotrope/message.rb @@ -23,7 +23,7 @@ class Message @from = Person.from_string decode_header(validate_field(:from, @m.header["from"])) @date = begin Time.parse(validate_field(:date, @m.header["date"])).to_i - rescue ArgumentError + rescue ArgumentError, NoMethodError #puts "warning: invalid date field #{@m.header['date']}" Time.at 0 end -- :wq ^X^Cy^K^X^C^C^C^C _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk