Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: Wael Nasreddine <wael.nasreddine@gmail.com>
To: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] Hook before-add-message, any way to know if this message is in a topic I replied to ?
Date: Mon, 03 Jan 2011 22:02:06 +0100	[thread overview]
Message-ID: <1294088289-sup-6218@Phoenix> (raw)
In-Reply-To: <1294086796-sup-9450@tilus.net>

This one time, at SUP Camp, Tero Tilus said, On 2011-01-03 21:46:
> Wael Nasreddine, 2010-12-23 14:04:
> > I added this method to my before-add-message hook and I call it at the
> > very end of the before-add-hook (so it's executed at the end)

> > ------- CUT
> > def show_if_participated(message)
> >   return if message.has_label? :inbox

> >   my_emails = ['wael.nasreddine@gmail.com', 'anotheremail@example.com']
> >   ts = ThreadSet.new Index.instance, $config[:thread_by_subject]
> >   ts.load_thread_for_message message
> >   message_thread = ts.thread_for message
> >   return unless message_thread
> >   message.add_label :inbox if my_emails.any? { |email|
> > message_thread.authors.include? email }
> > end
> > ------- CUT

> > However it's not working, I remove ~/.sup/xapian and ran sup-sync,
> > this email does not have the inbox label however it's one of the
> > thread that I replied to in a mailing list, what's wrong with my
> > function?

> On the surface it looks like it should work.  Couple of questions
> raise when I look at the code.  Does the thread loading actually work
> like that?  I might have been awfully wrong.  Does #authors return
> email addresses or Person instances?
I'm not sure, someone else might know about this.


> Did your reply come from one of
> the addresses listed in my_emails?
Of course, I made sure all my aliases are listed in this Array (BTW
any way to get all the addresses listed in the config file into this
array?)

> Did you reply only once and was
> that message the last one of it's thread to be indexed?  Your first
> mail to particular thread obviously won't trigger
> show_if_participated(), but subsequent mails will.

Well This email ended up in the list_sup_talk and out of the inbox,
even though I did reply couple of times to it

> Does your hook look like this?  (Judging by your explanation, it most
> probably does)

Yes exactly like this, I'll attach the before-add-hook in another
personal email to you since it has many addresses to people I know
won't like to be spammed (@list: sorry)

>   ...
>   def show_if_participated(message)
>   end
>   ...
>   show_if_participated(message)
>   ...

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          Waël Nasreddine
website    http://wael.nasreddine.com
Blog       http://emxyptlk.com
TechnoGate http://technogate.fr
mobile     06.32.94.70.13
landline   09.70.444.236
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk

      reply	other threads:[~2011-01-03 21:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 11:45 Wael Nasreddine
2010-12-20 13:12 ` Tero Tilus
2010-12-23 12:04   ` Wael Nasreddine
2011-01-03 20:46     ` Tero Tilus
2011-01-03 21:02       ` Wael Nasreddine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294088289-sup-6218@Phoenix \
    --to=wael.nasreddine@gmail.com \
    --cc=sup-talk@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox