Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: Tero Tilus <tero@tilus.net>
To: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] Hook before-add-message, any way to know if this message is in a topic I replied to ?
Date: Mon, 03 Jan 2011 22:46:59 +0200	[thread overview]
Message-ID: <1294086796-sup-9450@tilus.net> (raw)
In-Reply-To: <1293105681-sup-7985@Phoenix>

Wael Nasreddine, 2010-12-23 14:04:
> I added this method to my before-add-message hook and I call it at the
> very end of the before-add-hook (so it's executed at the end)
> 
> ------- CUT
> def show_if_participated(message)
>   return if message.has_label? :inbox
> 
>   my_emails = ['wael.nasreddine@gmail.com', 'anotheremail@example.com']
>   ts = ThreadSet.new Index.instance, $config[:thread_by_subject]
>   ts.load_thread_for_message message
>   message_thread = ts.thread_for message
>   return unless message_thread
>   message.add_label :inbox if my_emails.any? { |email|
> message_thread.authors.include? email }
> end
> ------- CUT
> 
> However it's not working, I remove ~/.sup/xapian and ran sup-sync,
> this email does not have the inbox label however it's one of the
> thread that I replied to in a mailing list, what's wrong with my
> function?

On the surface it looks like it should work.  Couple of questions
raise when I look at the code.  Does the thread loading actually work
like that?  I might have been awfully wrong.  Does #authors return
email addresses or Person instances?  Did your reply come from one of
the addresses listed in my_emails?  Did you reply only once and was
that message the last one of it's thread to be indexed?  Your first
mail to particular thread obviously won't trigger
show_if_participated(), but subsequent mails will.

Does your hook look like this?  (Judging by your explanation, it most
probably does)

  ...
  def show_if_participated(message)
  end
  ...
  show_if_participated(message)
  ...

-- 
Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk


  reply	other threads:[~2011-01-03 20:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 11:45 Wael Nasreddine
2010-12-20 13:12 ` Tero Tilus
2010-12-23 12:04   ` Wael Nasreddine
2011-01-03 20:46     ` Tero Tilus [this message]
2011-01-03 21:02       ` Wael Nasreddine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294086796-sup-9450@tilus.net \
    --to=tero@tilus.net \
    --cc=sup-talk@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox