From: Matthias Vallentin <vallentin@icsi.berkeley.edu>
To: Sup Talk <sup-talk@rubyforge.org>
Subject: [sup-talk] Multiple execution of before-edit hook
Date: Mon, 03 Jan 2011 11:34:00 -0800 [thread overview]
Message-ID: <1294082627-sup-4287@samurai.icir.org> (raw)
I noticed that before-edit is executed several times when replying:
@headers.each do |k, v|
@bodies[k] = body
HookManager.run "before-edit", :header => v, :body => @bodies[k]
end
What's the rational behind this? Why not invoking the hook once, for all
headers and the body. (Also, the hook is executed again in the parent
class EditMessageMode.) Since I use the hook to append some text at the
end of the body
body << "foo"
the text is added multiple times. Currently I use a crude hack to avoid
the duplicate appending by
body << "foo" unless body.last == "foo"
but I wonder whether this behavior is intentional.
Matthias
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
reply other threads:[~2011-01-03 19:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294082627-sup-4287@samurai.icir.org \
--to=vallentin@icsi.berkeley.edu \
--cc=sup-talk@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox