From: arstoien <arstoien@googlemail.com>
To: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] color customization
Date: Thu, 05 Aug 2010 19:34:47 +0200 [thread overview]
Message-ID: <1281029663-sup-1555@localhost> (raw)
In-Reply-To: <1281029479-sup-2414@localhost>
Excerpts from Arian Kuschki's message of 2010-08-05 19:34:01 +0200:
> Excerpts from Gregor Hoffleit's message of 2010-08-05 18:27:57 +0200:
> >
> > * arstoien <arstoien@googlemail.com> [Do Aug 05 17:21:58 +0200 2010]
> > > * the space between the date and the sender name in the index view
> > > (where the star is when a message is starred) is still highlighted in
> > > green, but only when the message is _not_ starred. When the message is
> > > starred it is highlighted correctly.
> >
> > Search the sup-devel archive for issue58 (msg-id
> > 1264760080.41.0.139357784083.issue58@masanjin.net, from January).
> >
> > This was my fix for that problem. Nobody else seemed to care about that
> > problem, so it's only included in my private Git branch.
> >
> > Regards,
> > Gregor
> >
> >
> >
> > commit 6551fc3e5373cc9f3a32b28b4335a2de2cd2efa4
> > Author: Gregor Hoffleit <gregor@hoffleit.de>
> > Date: Thu May 27 11:40:13 2010 +0200
> >
> > Bugfix: Background for starred messages
> >
> > diff --git a/lib/sup/modes/thread-index-mode.rb
> > b/lib/sup/modes/thread-index-mode.rb
> > index 5f3499c..f012123 100644
> > --- a/lib/sup/modes/thread-index-mode.rb
> > +++ b/lib/sup/modes/thread-index-mode.rb
> > @@ -887,7 +887,7 @@ protected
> > [
> > [:tagged_color, @tags.tagged?(t) ? ">" : " "],
> > [:date_color, date_widget_text],
> > - (starred ? [:starred_color, "*"] : [:none, " "]),
> > + [:starred_color, (starred ? "*" : " ")],
> > ] +
> > from +
> > [
>
>
> Gregor, that fixes it, thank you. Any idea why this has not been merged?
> If it was just an oversight I think it would be better to merge it as
> the highlighting customisation mechanism is slightly broken without it.
>
> Now if I could only find out how to change the highlighting when
> viewing a message..
--
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
prev parent reply other threads:[~2010-08-05 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 15:12 David Rysdam
2010-07-27 2:02 ` David Rysdam
2010-08-05 15:21 ` arstoien
[not found] ` <1264760080.41.0.139357784083.issue58@masanjin.net>
2010-08-05 16:27 ` Gregor Hoffleit
[not found] ` <1281029479-sup-2414@localhost>
2010-08-05 17:34 ` arstoien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281029663-sup-1555@localhost \
--to=arstoien@googlemail.com \
--cc=sup-talk@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox