* [sup-talk] color customization
@ 2010-07-22 15:12 David Rysdam
2010-07-27 2:02 ` David Rysdam
0 siblings, 1 reply; 5+ messages in thread
From: David Rysdam @ 2010-07-22 15:12 UTC (permalink / raw)
To: sup-talk
I've customized my colors a bit, but there's a couple things I can't
find. How do I configure the color the movable horizontal "bar" (I
know there's a term for this but I don't remember it)? And more
importantly, how do I configure the color the text highlighted by that
bar? Like, I have my new messages set to red but when the bar is on
them they are black. I want them red *always*.
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-talk] color customization
2010-07-22 15:12 [sup-talk] color customization David Rysdam
@ 2010-07-27 2:02 ` David Rysdam
2010-08-05 15:21 ` arstoien
0 siblings, 1 reply; 5+ messages in thread
From: David Rysdam @ 2010-07-27 2:02 UTC (permalink / raw)
To: sup-talk
An agent or agents purporting to be David Rysdam said:
> I've customized my colors a bit, but there's a couple things I can't
> find. How do I configure the color the movable horizontal "bar" (I
> know there's a term for this but I don't remember it)? And more
> importantly, how do I configure the color the text highlighted by that
> bar? Like, I have my new messages set to red but when the bar is on
> them they are black. I want them red *always*.
Replying to myself again, for the benefit of others and after two
nights of hacking the code to try to figure this out:
Each of the colors takes a property called "highlight" that is the
name of another color in colors.yaml. That color's fg/bg indicate how
it should display when "highlighted" by the cursor. For example:
:index_new:
:highlight: index_new_highlight
:attrs:
- bold
:fg: red
:bg: default
:index_new_highlight:
:fg: red
:bg: cyan
In this example, new mails are red in the thread view on a white
background (for me) and when highlighted by the cursor they are red on
a cyan background.
This works with the code currently in the repository but not with
.10.2, the default version on Ubuntu. Since .10.2 also doesn't use
ncursesw by default, I'm going to switch the repository pretty soon.
Or maybe a few versions back to avoid any Maildir unpleasantness...
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-talk] color customization
2010-07-27 2:02 ` David Rysdam
@ 2010-08-05 15:21 ` arstoien
[not found] ` <1264760080.41.0.139357784083.issue58@masanjin.net>
0 siblings, 1 reply; 5+ messages in thread
From: arstoien @ 2010-08-05 15:21 UTC (permalink / raw)
To: sup-talk
Hi David,
thanks for this, I wanted to change the color of horizontal bar for quite
a while. It worked fine for me except in two places:
* the space between the date and the sender name in the index view
(where the star is when a message is starred) is still highlighted in
green, but only when the message is _not_ starred. When the message is
starred it is highlighted correctly.
* when I view a message thread the bar is still in the wrong color when it is
on regular body text. When it is on a quote it uses the correct
colour.
I added the :highlight: property to all color entries there are.
Do you have the same issue or does it work for you?
Excerpts from David Rysdam's message of 2010-07-27 04:02:27 +0200:
> An agent or agents purporting to be David Rysdam said:
> > I've customized my colors a bit, but there's a couple things I can't
> > find. How do I configure the color the movable horizontal "bar" (I
> > know there's a term for this but I don't remember it)? And more
> > importantly, how do I configure the color the text highlighted by that
> > bar? Like, I have my new messages set to red but when the bar is on
> > them they are black. I want them red *always*.
>
> Replying to myself again, for the benefit of others and after two
> nights of hacking the code to try to figure this out:
>
> Each of the colors takes a property called "highlight" that is the
> name of another color in colors.yaml. That color's fg/bg indicate how
> it should display when "highlighted" by the cursor. For example:
>
> :index_new:
> :highlight: index_new_highlight
> :attrs:
> - bold
> :fg: red
> :bg: default
> :index_new_highlight:
> :fg: red
> :bg: cyan
>
> In this example, new mails are red in the thread view on a white
> background (for me) and when highlighted by the cursor they are red on
> a cyan background.
>
> This works with the code currently in the repository but not with
> .10.2, the default version on Ubuntu. Since .10.2 also doesn't use
> ncursesw by default, I'm going to switch the repository pretty soon.
> Or maybe a few versions back to avoid any Maildir unpleasantness...
--
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-talk] color customization
[not found] ` <1264760080.41.0.139357784083.issue58@masanjin.net>
@ 2010-08-05 16:27 ` Gregor Hoffleit
[not found] ` <1281029479-sup-2414@localhost>
0 siblings, 1 reply; 5+ messages in thread
From: Gregor Hoffleit @ 2010-08-05 16:27 UTC (permalink / raw)
To: sup-talk
* arstoien <arstoien@googlemail.com> [Do Aug 05 17:21:58 +0200 2010]
> * the space between the date and the sender name in the index view
> (where the star is when a message is starred) is still highlighted in
> green, but only when the message is _not_ starred. When the message is
> starred it is highlighted correctly.
Search the sup-devel archive for issue58 (msg-id
1264760080.41.0.139357784083.issue58@masanjin.net, from January).
This was my fix for that problem. Nobody else seemed to care about that
problem, so it's only included in my private Git branch.
Regards,
Gregor
commit 6551fc3e5373cc9f3a32b28b4335a2de2cd2efa4
Author: Gregor Hoffleit <gregor@hoffleit.de>
Date: Thu May 27 11:40:13 2010 +0200
Bugfix: Background for starred messages
diff --git a/lib/sup/modes/thread-index-mode.rb
b/lib/sup/modes/thread-index-mode.rb
index 5f3499c..f012123 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -887,7 +887,7 @@ protected
[
[:tagged_color, @tags.tagged?(t) ? ">" : " "],
[:date_color, date_widget_text],
- (starred ? [:starred_color, "*"] : [:none, " "]),
+ [:starred_color, (starred ? "*" : " ")],
] +
from +
[
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-talk] color customization
[not found] ` <1281029479-sup-2414@localhost>
@ 2010-08-05 17:34 ` arstoien
0 siblings, 0 replies; 5+ messages in thread
From: arstoien @ 2010-08-05 17:34 UTC (permalink / raw)
To: sup-talk
Excerpts from Arian Kuschki's message of 2010-08-05 19:34:01 +0200:
> Excerpts from Gregor Hoffleit's message of 2010-08-05 18:27:57 +0200:
> >
> > * arstoien <arstoien@googlemail.com> [Do Aug 05 17:21:58 +0200 2010]
> > > * the space between the date and the sender name in the index view
> > > (where the star is when a message is starred) is still highlighted in
> > > green, but only when the message is _not_ starred. When the message is
> > > starred it is highlighted correctly.
> >
> > Search the sup-devel archive for issue58 (msg-id
> > 1264760080.41.0.139357784083.issue58@masanjin.net, from January).
> >
> > This was my fix for that problem. Nobody else seemed to care about that
> > problem, so it's only included in my private Git branch.
> >
> > Regards,
> > Gregor
> >
> >
> >
> > commit 6551fc3e5373cc9f3a32b28b4335a2de2cd2efa4
> > Author: Gregor Hoffleit <gregor@hoffleit.de>
> > Date: Thu May 27 11:40:13 2010 +0200
> >
> > Bugfix: Background for starred messages
> >
> > diff --git a/lib/sup/modes/thread-index-mode.rb
> > b/lib/sup/modes/thread-index-mode.rb
> > index 5f3499c..f012123 100644
> > --- a/lib/sup/modes/thread-index-mode.rb
> > +++ b/lib/sup/modes/thread-index-mode.rb
> > @@ -887,7 +887,7 @@ protected
> > [
> > [:tagged_color, @tags.tagged?(t) ? ">" : " "],
> > [:date_color, date_widget_text],
> > - (starred ? [:starred_color, "*"] : [:none, " "]),
> > + [:starred_color, (starred ? "*" : " ")],
> > ] +
> > from +
> > [
>
>
> Gregor, that fixes it, thank you. Any idea why this has not been merged?
> If it was just an oversight I think it would be better to merge it as
> the highlighting customisation mechanism is slightly broken without it.
>
> Now if I could only find out how to change the highlighting when
> viewing a message..
--
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-05 17:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-22 15:12 [sup-talk] color customization David Rysdam
2010-07-27 2:02 ` David Rysdam
2010-08-05 15:21 ` arstoien
[not found] ` <1264760080.41.0.139357784083.issue58@masanjin.net>
2010-08-05 16:27 ` Gregor Hoffleit
[not found] ` <1281029479-sup-2414@localhost>
2010-08-05 17:34 ` arstoien
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox