From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.204.130.91 with SMTP id r27cs73353bks; Mon, 14 Jun 2010 02:53:44 -0700 (PDT) Received: by 10.231.66.79 with SMTP id m15mr6460160ibi.139.1276509223262; Mon, 14 Jun 2010 02:53:43 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 40si6642175ibv.52.2010.06.14.02.53.42; Mon, 14 Jun 2010 02:53:43 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 682C11858377; Mon, 14 Jun 2010 05:53:42 -0400 (EDT) Received: from sam.mediasupervision.de (sam.mediasupervision.de [80.152.3.104]) by rubyforge.org (Postfix) with ESMTP id AAF571858354 for ; Mon, 14 Jun 2010 05:46:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by sam.mediasupervision.de (Postfix) with ESMTP id 627F7485C59; Mon, 14 Jun 2010 11:46:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at sam.mediasupervision.de Received: from sam.mediasupervision.de ([127.0.0.1]) by localhost (sam.mediasupervision.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MVTVKRA8sAln; Mon, 14 Jun 2010 11:46:47 +0200 (CEST) Received: by sam.mediasupervision.de (Postfix, from userid 1000) id 30B174860E0; Mon, 14 Jun 2010 11:46:47 +0200 (CEST) From: Gregor Hoffleit To: Eric Sherman In-reply-to: <1276188610-sup-3944@changeling.local> References: <1275850632-sup-6402@ubuntu.ubuntu-domain> <1275884981-sup-4509@roughage.com.au> <1275973780-sup-5206@ubuntu.ubuntu-domain> <1275997525-sup-9347@changeling.local> <1276184688-sup-7287@sam.mediasupervision.de> <1276185501-sup-3012@changeling.local> <1276185930-sup-2153@sam.mediasupervision.de> <1276188610-sup-3944@changeling.local> Date: Mon, 14 Jun 2010 11:46:47 +0200 Message-Id: <1276508193-sup-213@sam.mediasupervision.de> User-Agent: Sup/git Cc: sup-talk Subject: Re: [sup-talk] choosing signatures X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org * Eric Sherman [Do Jun 10 19:02:45 +0200 2010] > Excerpts from Gregor Hoffleit's message of Thu Jun 10 12:08:34 -0400 2010: > > Wouldn't the before-edit hook work for replying, as well? > > I imagine so, and peeking quickly at reply-mode.rb seems to confirm this. > I probably wrote these way back when starting to use sup when I assumed > that before-edit only fired on new emails and reply-from only fired on > replies. The next time I need to change their behavior I'll probably > DRY-ify my hooks. Thanks for pointing this out. Short update: When I tried your code, I couldn't get before-edit work as expected. Appearently, the before-edit hook is called multiple times in reply-mode, with varying headers, which broke my naive transformations: Subsequent calls reverted/overwrote changes made in earlier calls. I haven't looked in depth at this, though. Gregor _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk