From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.90.27.4 with SMTP id a4cs255759aga; Thu, 19 Nov 2009 20:51:40 -0800 (PST) Received: by 10.224.42.83 with SMTP id r19mr597388qae.35.1258692699502; Thu, 19 Nov 2009 20:51:39 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 4si984922qyk.76.2009.11.19.20.51.39; Thu, 19 Nov 2009 20:51:39 -0800 (PST) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 0FBB618582DE; Thu, 19 Nov 2009 23:51:39 -0500 (EST) Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88]) by rubyforge.org (Postfix) with ESMTP id 7FBC218582CE for ; Thu, 19 Nov 2009 23:51:23 -0500 (EST) Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69) (envelope-from ) id 1NBLSs-0007Om-Ra; Thu, 19 Nov 2009 23:51:22 -0500 From: Rich Lane To: Andrew Pimlott In-reply-to: <1258045702-sup-9760@pimlott.net> References: <1257409101-sup-7780@pc44es141.cs.uni-magdeburg.de> <1258045702-sup-9760@pimlott.net> Date: Thu, 19 Nov 2009 23:51:22 -0500 Message-Id: <1258692213-sup-2324@zyrg.net> User-Agent: Sup/git Cc: sup-talk Subject: Re: [sup-talk] Problems with undo archive and thread focus X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org Excerpts from Andrew Pimlott's message of Thu Nov 12 12:30:01 -0500 2009: > Excerpts from Matthias Guedemann's message of Thu Nov 05 00:27:25 -0800 2009: > > One is, if you hit 'a' in thread view mode, the thread is archived but undo does > > not work. If you go back to index view and hit 'u' the just archived thread does > > not appear, but the one before. > > I was annoyed by this too and found that undo is minimally implemented. > I added undo to thread view, at least for the cases that I care about or > were easy. I have to say I was discouraged that this was necessary: the > code to archive a thread should all be in one place, and the undo > record should be created there. There's a lot of code duplication, and > I can't tell if it's because the model and view are too coupled, or > because nobody has bothered to factor it out. > > The patch is appended. (This is the first time I've done this with git.) Branch thread-view-mode-undo, merged to master at git://github.com/rlane/sup _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk