From: Rich Lane <rlane@club.cc.cmu.edu>
To: Andrew Pimlott <andrew@pimlott.net>
Cc: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] Problems with undo archive and thread focus
Date: Thu, 19 Nov 2009 23:51:22 -0500 [thread overview]
Message-ID: <1258692213-sup-2324@zyrg.net> (raw)
In-Reply-To: <1258045702-sup-9760@pimlott.net>
Excerpts from Andrew Pimlott's message of Thu Nov 12 12:30:01 -0500 2009:
> Excerpts from Matthias Guedemann's message of Thu Nov 05 00:27:25 -0800 2009:
> > One is, if you hit 'a' in thread view mode, the thread is archived but undo does
> > not work. If you go back to index view and hit 'u' the just archived thread does
> > not appear, but the one before.
>
> I was annoyed by this too and found that undo is minimally implemented.
> I added undo to thread view, at least for the cases that I care about or
> were easy. I have to say I was discouraged that this was necessary: the
> code to archive a thread should all be in one place, and the undo
> record should be created there. There's a lot of code duplication, and
> I can't tell if it's because the model and view are too coupled, or
> because nobody has bothered to factor it out.
>
> The patch is appended. (This is the first time I've done this with git.)
Branch thread-view-mode-undo, merged to master at
git://github.com/rlane/sup
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
prev parent reply other threads:[~2009-11-20 4:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 8:27 Matthias Guedemann
2009-11-12 17:30 ` Andrew Pimlott
2009-11-16 9:42 ` Matthias Guedemann
2009-11-20 4:51 ` Rich Lane [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258692213-sup-2324@zyrg.net \
--to=rlane@club.cc.cmu.edu \
--cc=andrew@pimlott.net \
--cc=sup-talk@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox