From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.90.27.4 with SMTP id a4cs7463aga;
        Wed, 11 Nov 2009 20:57:09 -0800 (PST)
Received: by 10.224.51.205 with SMTP id e13mr1307565qag.387.1258001829268;
        Wed, 11 Nov 2009 20:57:09 -0800 (PST)
Return-Path: <sup-talk-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id 7si3557588qyk.114.2009.11.11.20.57.09;
        Wed, 11 Nov 2009 20:57:09 -0800 (PST)
Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id E90B31779938;
	Wed, 11 Nov 2009 23:57:08 -0500 (EST)
X-Greylist: delayed 1552 seconds by postgrey-1.31 at rubyforge.org;
	Wed, 11 Nov 2009 23:56:51 EST
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id F003918582BC
	for <sup-talk@rubyforge.org>; Wed, 11 Nov 2009 23:56:51 -0500 (EST)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1N8RKi-0003FK-RR; Wed, 11 Nov 2009 23:30:56 -0500
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Tero Tilus <tero@tilus.net>
In-reply-to: <1255159160-sup-8754@tilus.net>
References: <1255159160-sup-8754@tilus.net>
Date: Wed, 11 Nov 2009 23:30:56 -0500
Message-Id: <1258000130-sup-4084@zyrg.net>
User-Agent: Sup/git
Cc: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] [PATCH] moved deriving the cmd for bouncing to
	Account and fixed a bug in it
X-BeenThere: sup-talk@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: User & developer discussion of Sup <sup-talk.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-talk>,
	<mailto:sup-talk-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-talk>
List-Post: <mailto:sup-talk@rubyforge.org>
List-Help: <mailto:sup-talk-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-talk>,
	<mailto:sup-talk-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-talk-bounces@rubyforge.org
Errors-To: sup-talk-bounces@rubyforge.org

Excerpts from Tero Tilus's message of Sat Oct 10 03:21:33 -0400 2009:
> The default sendmail command used for bouncing mail was derived from
> Account#sendmail in ThreadViewMode#bounce.  Moved it to
> Account#bounce_sendmail.  Part of work towards more DRY mail bouncing
> within mark-as-spam hook. The code also had a bug, "$1" (instead of $1
> or "#{$1}").  Fixed it.
> 
> Signed-off-by: Tero Tilus <tero@tilus.net>
> ---
>  lib/sup/account.rb                |   11 +++++++++++
>  lib/sup/modes/thread-view-mode.rb |    7 +------
>  2 files changed, 12 insertions(+), 6 deletions(-)

Looks good to me. Pushed to branch fix-bounce-cmd in my repo* and merged
to master.

* git://github.com/rlane/sup
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk