From: Rich Lane <rlane@club.cc.cmu.edu>
To: Tero Tilus <tero@tilus.net>
Cc: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] [PATCH] moved deriving the cmd for bouncing to Account and fixed a bug in it
Date: Wed, 11 Nov 2009 23:30:56 -0500 [thread overview]
Message-ID: <1258000130-sup-4084@zyrg.net> (raw)
In-Reply-To: <1255159160-sup-8754@tilus.net>
Excerpts from Tero Tilus's message of Sat Oct 10 03:21:33 -0400 2009:
> The default sendmail command used for bouncing mail was derived from
> Account#sendmail in ThreadViewMode#bounce. Moved it to
> Account#bounce_sendmail. Part of work towards more DRY mail bouncing
> within mark-as-spam hook. The code also had a bug, "$1" (instead of $1
> or "#{$1}"). Fixed it.
>
> Signed-off-by: Tero Tilus <tero@tilus.net>
> ---
> lib/sup/account.rb | 11 +++++++++++
> lib/sup/modes/thread-view-mode.rb | 7 +------
> 2 files changed, 12 insertions(+), 6 deletions(-)
Looks good to me. Pushed to branch fix-bounce-cmd in my repo* and merged
to master.
* git://github.com/rlane/sup
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
prev parent reply other threads:[~2009-11-12 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 7:21 Tero Tilus
2009-11-12 4:30 ` Rich Lane [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258000130-sup-4084@zyrg.net \
--to=rlane@club.cc.cmu.edu \
--cc=sup-talk@rubyforge.org \
--cc=tero@tilus.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox