From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.90.26.14 with SMTP id 14cs92380agz;
        Sun, 8 Nov 2009 22:28:23 -0800 (PST)
Received: by 10.224.108.198 with SMTP id g6mr3892436qap.107.1257748102476;
        Sun, 08 Nov 2009 22:28:22 -0800 (PST)
Return-Path: <sup-talk-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id 37si3141151qyk.122.2009.11.08.22.28.22;
        Sun, 08 Nov 2009 22:28:22 -0800 (PST)
Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id 1EC811D78864;
	Mon,  9 Nov 2009 01:28:22 -0500 (EST)
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id B751F18582AC
	for <sup-talk@rubyforge.org>; Mon,  9 Nov 2009 01:22:03 -0500 (EST)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1N7Ndb-0007gZ-9o; Mon, 09 Nov 2009 01:22:03 -0500
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Eugene Marinelli <eugeneiiim@gmail.com>
In-reply-to: <69d60e3a0911082202t31561f18mf5e24dda7a108b58@mail.gmail.com>
References: <1257399921-26813-1-git-send-email-rlane@club.cc.cmu.edu>
	<1257399921-26813-2-git-send-email-rlane@club.cc.cmu.edu>
	<69d60e3a0911082202t31561f18mf5e24dda7a108b58@mail.gmail.com>
Date: Mon, 09 Nov 2009 01:22:03 -0500
Message-Id: <1257747131-sup-7562@zyrg.net>
User-Agent: Sup/git
Cc: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] [PATCH 2/4] async thread indexing
X-BeenThere: sup-talk@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: User & developer discussion of Sup <sup-talk.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-talk>,
	<mailto:sup-talk-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-talk>
List-Post: <mailto:sup-talk@rubyforge.org>
List-Help: <mailto:sup-talk-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-talk>,
	<mailto:sup-talk-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-talk-bounces@rubyforge.org
Errors-To: sup-talk-bounces@rubyforge.org

Excerpts from Eugene Marinelli's message of Mon Nov 09 01:02:07 -0500 2009:
> > -          Index.save_thread t
> > +          Index.save_thread_async t
> Where is the "save_thread_async" function?
> 
> In patch 3/4, this looks like a syntax error:
> > -    end
> > +    threads.each { |t| Index.save_thread async t }
> >   end

Nice catch. I'd originally named the method save_thread_async and it
looks like my search-and-replace wasn't complete. I've fixed this on the
immediate-updates branch. Thanks for the review!
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk