From: Rich Lane <rlane@club.cc.cmu.edu>
To: Eugene Marinelli <eugeneiiim@gmail.com>
Cc: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] [PATCH 2/4] async thread indexing
Date: Mon, 09 Nov 2009 01:22:03 -0500 [thread overview]
Message-ID: <1257747131-sup-7562@zyrg.net> (raw)
In-Reply-To: <69d60e3a0911082202t31561f18mf5e24dda7a108b58@mail.gmail.com>
Excerpts from Eugene Marinelli's message of Mon Nov 09 01:02:07 -0500 2009:
> > - Index.save_thread t
> > + Index.save_thread_async t
> Where is the "save_thread_async" function?
>
> In patch 3/4, this looks like a syntax error:
> > - end
> > + threads.each { |t| Index.save_thread async t }
> > end
Nice catch. I'd originally named the method save_thread_async and it
looks like my search-and-replace wasn't complete. I've fixed this on the
immediate-updates branch. Thanks for the review!
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
prev parent reply other threads:[~2009-11-09 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 5:45 [sup-talk] [PATCH 1/4] factor saving out of thread/message classes Rich Lane
2009-11-05 5:45 ` [sup-talk] [PATCH 2/4] async thread indexing Rich Lane
2009-11-05 5:45 ` [sup-talk] [PATCH 3/4] immediate " Rich Lane
2009-11-05 5:45 ` [sup-talk] [PATCH 4/4] force the index sync thread to give up the cpu Rich Lane
2009-11-09 6:02 ` [sup-talk] [PATCH 2/4] async thread indexing Eugene Marinelli
2009-11-09 6:22 ` Rich Lane [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257747131-sup-7562@zyrg.net \
--to=rlane@club.cc.cmu.edu \
--cc=eugeneiiim@gmail.com \
--cc=sup-talk@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox