Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: Mark Anderson <markr.anderson@amd.com>
To: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] Sup-sync exception
Date: Fri, 6 Nov 2009 13:06:17 -0700	[thread overview]
Message-ID: <1257537789-sup-1961@testarossa> (raw)
In-Reply-To: <1257520288-sup-8595@onnadayr.ca>

Excerpts from rick.tessner's message of Fri Nov 06 08:13:19 -0700 2009:
> I had that exact same thing.  If you applied a patch that used
> Ncurses.cols rather than WRAP_LEN to determine screen width, you'll have
> that problem in the non-curses based sup applications.
> 
> The patch came from an email with the subject
> 
>     [PATCH] Use terminal width instead of hardcoded 80 as the wrap length.

I had applied that previous patch, as you guessed.

There was another patch that is complementary in getting the console to recognize the width of the terminal, I forget the tname, but here's what I have in my message-chunks.rb:

  TERM_WIDTH = `stty size 2>/dev/null`.split[1].to_i # to_i returns 0 if it fails
  WRAP_LEN = TERM_WIDTH > 0 && TERM_WIDTH || 80 # wrap messages and text attachments at this width

I don't know why that patch preferred `stty` to ENV["COLUMNS"], since that one had worked for me.

> I initially didn't have any problems whatsoever with that patch until I ran
> sup-sync. I fixed it with the attached commit.
> 
> This patch just does a rescue on that call.  The patch is only
> applicable if you had applied a patch that came through previously on
> this list for using Ncurses.cols rather than WRAP_LEN in
> lib/sup/message-chunks.rb

Thanks, it is much happier now.

-Mark

_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk


  reply	other threads:[~2009-11-06 20:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05 20:29 Mark Anderson
2009-11-06 15:13 ` rick.tessner
2009-11-06 20:06   ` Mark Anderson [this message]
2009-11-07  2:16     ` Anthony Martinez
2009-11-07  4:10       ` Mark Alexander
2009-11-20 15:50 Ned Ludd
2009-11-21  5:18 ` Andrei Thorp
2009-11-23 23:33 ` Rich Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257537789-sup-1961@testarossa \
    --to=markr.anderson@amd.com \
    --cc=sup-talk@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox