From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.90.79.9 with SMTP id c9cs47403agb; Tue, 3 Nov 2009 11:42:17 -0800 (PST) Received: by 10.224.72.23 with SMTP id k23mr238892qaj.120.1257277337357; Tue, 03 Nov 2009 11:42:17 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 5si516493qyk.73.2009.11.03.11.42.17; Tue, 03 Nov 2009 11:42:17 -0800 (PST) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 0A6ED16782B5; Tue, 3 Nov 2009 14:42:17 -0500 (EST) Received: from tihlde.org (colargol.tihlde.org [158.38.48.10]) by rubyforge.org (Postfix) with ESMTP id 035161598031 for ; Tue, 3 Nov 2009 14:23:29 -0500 (EST) Received: by tihlde.org (Postfix, from userid 1623) id A4CC2101850A; Tue, 3 Nov 2009 20:23:28 +0100 (CET) From: Helge Titlestad To: sup-talk In-reply-to: <1257264198-sup-8152@masanjin.net> References: <1255961127-sup-3168@tihlde.org> <1257264198-sup-8152@masanjin.net> Date: Tue, 03 Nov 2009 20:23:28 +0100 Message-Id: <1257275607-sup-583@tihlde.org> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1257276208-662659-24792-2891-4-=" MIME-Version: 1.0 Subject: Re: [sup-talk] [PATCH] detect and set charset on text/* attachments X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org --=-1257276208-662659-24792-2891-4-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Excerpts from William Morgan's message of Tue Nov 03 18:16:32 +0100 2009: > It looks like the chardet gem is unmaintained. But someone decided to > make their own special version called rchardet which is completely > equivalent version but *is* maintained. > > I suggest we use rchardet instead of chardet. Would you like to change > the patch? If not, I will get to it at some point. Here you go! One thing I noticed when trying it out: It will set charset 'ascii' for ascii text, which is allowed by the RFC but "US-ASCII" is preferred. I think I prefer to not create a special case in the code to change it to US-ASCII or remove the charset for ascii text, but other people might disagree. -- alge --=-1257276208-662659-24792-2891-4-= Content-Disposition: attachment; filename="0001-Detect-charset-for-text-file-attachments.patch" Content-Type: application/octet-stream; name="0001-Detect-charset-for-text-file-attachments.patch" Content-Transfer-Encoding: base64 RnJvbSAwOTQ5NjJlMDRlYWZjNTBiYTcwN2MwYzM1ODg1ZjE2MWMwZmM5NjQx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWxnZSBUaXRsZXN0 YWQgPGhlbGdlZHRAdGlobGRlLm9yZz4KRGF0ZTogVHVlLCAzIE5vdiAyMDA5 IDIwOjExOjI1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRGV0ZWN0IGNoYXJz ZXQgZm9yIHRleHQvKiBmaWxlIGF0dGFjaG1lbnRzLgoKQWRkcyBkZXBlbmRl bmN5IG9uIHJjaGFyZGV0IGdlbSwgYW5kIHVzZXMgaXQgdG8gZGV0ZWN0IHRo ZSBjaGFyc2V0LgotLS0KIFJFQURNRS50eHQgICAgICB8ICAgIDEgKwogUmFr ZWZpbGUgICAgICAgIHwgICAgMSArCiBsaWIvc3VwL3V0aWwucmIgfCAgICA5 ICsrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1JFQURNRS50eHQgYi9S RUFETUUudHh0CmluZGV4IDQyMDQyNzAuLjE4NGRkMDkgMTAwNjQ0Ci0tLSBh L1JFQURNRS50eHQKKysrIGIvUkVBRE1FLnR4dApAQCAtMTA2LDYgKzEwNiw3 IEBAIEN1cnJlbnQgbGltaXRhdGlvbnMgd2hpY2ggd2lsbCBiZSBmaXhlZDoK ICAtIG1pbWUtdHlwZXMKICAtIGdldHRleHQKICAtIGZhc3R0aHJlYWQKKyAt IHJjaGFyZGV0CiAKID09IElOU1RBTEw6CiAKZGlmZiAtLWdpdCBhL1Jha2Vm aWxlIGIvUmFrZWZpbGUKaW5kZXggNjdjZDBkMi4uYzhkOTI0MyAxMDA2NDQK LS0tIGEvUmFrZWZpbGUKKysrIGIvUmFrZWZpbGUKQEAgLTU3LDYgKzU3LDcg QEAgc3BlYyA9IEdlbTo6U3BlY2lmaWNhdGlvbi5uZXcgZG8gfHN8CiAgIHMu YWRkX2RlcGVuZGVuY3kgIm1pbWUtdHlwZXMiLCAifj4gMSIKICAgcy5hZGRf ZGVwZW5kZW5jeSAiZ2V0dGV4dCIKICAgcy5hZGRfZGVwZW5kZW5jeSAiZmFz dHRocmVhZCIKKyAgcy5hZGRfZGVwZW5kZW5jeSAicmNoYXJkZXQiLCAiPj0g MS4zIgogZW5kCiAKIFJha2U6OkdlbVBhY2thZ2VUYXNrLm5ldyhzcGVjKSBk byB8cGtnfApkaWZmIC0tZ2l0IGEvbGliL3N1cC91dGlsLnJiIGIvbGliL3N1 cC91dGlsLnJiCmluZGV4IGY5OWUxYzEuLjdiNzQ3ZmIgMTAwNjQ0Ci0tLSBh L2xpYi9zdXAvdXRpbC5yYgorKysgYi9saWIvc3VwL3V0aWwucmIKQEAgLTMs NiArMyw3IEBAIHJlcXVpcmUgJ2xvY2tmaWxlJwogcmVxdWlyZSAnbWltZS90 eXBlcycKIHJlcXVpcmUgJ3BhdGhuYW1lJwogcmVxdWlyZSAnc2V0JworcmVx dWlyZSAncmNoYXJkZXQnCiAKICMjIHRpbWUgZm9yIHNvbWUgbW9ua2V5cGF0 Y2hpbmchCiBjbGFzcyBMb2NrZmlsZQpAQCAtNzEsOCArNzIsMTQgQEAgbW9k dWxlIFJNYWlsCiAKICAgICBkZWYgc2VsZi5tYWtlX2F0dGFjaG1lbnQgcGF5 bG9hZCwgbWltZV90eXBlLCBlbmNvZGluZywgZmlsZW5hbWUKICAgICAgIGEg PSBNZXNzYWdlLm5ldworCisgICAgICBjcyA9IENoYXJEZXQuZGV0ZWN0KHBh eWxvYWQpWydlbmNvZGluZyddIGlmIG1pbWVfdHlwZSA9fiAvXnRleHRcLy9p CitkZWJ1ZyhjcykKKyAgICAgIGN0ID0gIiN7bWltZV90eXBlfTsgbmFtZT0j e2ZpbGVuYW1lLmluc3BlY3R9IgorICAgICAgY3QgKz0gIjsgY2hhcnNldD0j e2NzfSIgaWYgY3MKKyAgICAgIAogICAgICAgYS5oZWFkZXIuYWRkICJDb250 ZW50LURpc3Bvc2l0aW9uIiwgImF0dGFjaG1lbnQ7IGZpbGVuYW1lPSN7Zmls ZW5hbWUuaW5zcGVjdH0iCi0gICAgICBhLmhlYWRlci5hZGQgIkNvbnRlbnQt VHlwZSIsICIje21pbWVfdHlwZX07IG5hbWU9I3tmaWxlbmFtZS5pbnNwZWN0 fSIKKyAgICAgIGEuaGVhZGVyLmFkZCAiQ29udGVudC1UeXBlIiwgY3QKICAg ICAgIGEuaGVhZGVyLmFkZCAiQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZyIs IGVuY29kaW5nIGlmIGVuY29kaW5nCiAgICAgICBhLmJvZHkgPQogICAgICAg ICBjYXNlIGVuY29kaW5nCi0tIAoxLjUuNi41Cgo= --=-1257276208-662659-24792-2891-4-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk --=-1257276208-662659-24792-2891-4-=--