Re: [sup-talk] [PATCH] detect and set charset on text/* attachments

From: William Morgan <wmorgan-sup@masanjin.net>
To: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] [PATCH] detect and set charset on text/* attachments
Date: Tue, 03 Nov 2009 09:16:32 -0800	[thread overview]
Message-ID: <1257264198-sup-8152@masanjin.net> (raw)
In-Reply-To: <1255961127-sup-3168@tihlde.org>

Reformatted excerpts from Helge Titlestad's message of 2009-10-19:
> I got some feedback from non-suppers that my utf-8 text attachments
> were messed up. When I checked they (the MIME headers) lacked any info
> on charset, which I believe should be set for text/*.

After reviewing the RFCs, yeah, I think you're basically right. The
charset parameter is not required to be set for text/* mime types, but
if it's unset, the part is assumed to be us-ascii.

> Here's a patch that uses the chardet gem to (try to) detect the
> appropriate charset and sets it in the Content-Type header.

Although I don't relish adding yet another gem dependency, I think this
is the right approach.

It looks like the chardet gem is unmaintained. But someone decided to
make their own special version called rchardet which is completely
equivalent version but *is* maintained. (What is it with these goddamn
ruby people.)

I suggest we use rchardet instead of chardet. Would you like to change
the patch? If not, I will get to it at some point.

> Please tell me if I should use some different way of sending
> patches... This git flow is a bit new to me. (=

Nope, this is perfect. Thanks!
-- 
William <wmorgan-sup@masanjin.net>
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk