[sup-talk] A fix for the joining threads bug with Ferret

From: Gregor Hoffleit <gregor@hoffleit.de>
To: sup-talk <sup-talk@rubyforge.org>
Subject: [sup-talk] A fix for the joining threads bug with Ferret
Date: Fri, 23 Oct 2009 13:48:31 +0200	[thread overview]
Message-ID: <1256297205-sup-683@sam.mediasupervision.de> (raw)

I did a little bit research regarding the problem that joining threads
isn't persistent (as described in [1]-[3]).

I managed to track down the problem until the following line in
FerretIndex#sync_message in lib/sup/ferret_index.rb.

  d = { ...  :refs => (entry[:refs] || (m.refs + m.replytos).uniq.join(" ")) }

I have problems to understand what this line is supposed to do.

For me, it always evaluates to "entry[:refs]" (even if that's an empty
string!), losing the reference in the modified message m, which was added
by add_ref. Therefore the manual join is always lost.

With my limited Ruby knowledge, my quick and dirty fix was:

    if entry[:refs]!="" then
       d[:refs]=entry[:refs]
    else
       d[:refs]=(m.refs + m.replytos).uniq.join(" ")
    end

Is this what the above code is about?

Btw, the code in xapian_index.rb looks much different. Still, I'd like
to see this fixed for Xapian.

Regards,
    Gregor Hoffleit

[1] http://sup.rubyforge.org/ditz/issue-4e501973cea5bd1f28739ae4cea98edce8249895.html
[2] http://rubyforge.org/pipermail/sup-talk/2009-April/002050.html
[3] http://rubyforge.org/pipermail/sup-talk/2009-April/002060.html
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk